...@samsung.com
Looks good for me. FWIW, I could probably add
Acked-by: Karol Lewandowski k.lewando...@samsung.com
Regards,
--
Karol Lewandowski | Samsung Poland RD Center | Linux/Platform
___
devicetree-discuss mailing list
devicetree-discuss
,
.dt_compat = exynos5250_dt_compat,
.restart= exynos5_restart,
+ .reserve= exynos5_reserve,
MACHINE_END
Regards,
--
Karol Lewandowski | Samsung Poland RD Center | Linux/Platform
___
devicetree-discuss mailing list
-size, len);
if (!prop)
return;
lsize = of_read_ulong(prop, len/4);
...
Regards,
--
Karol Lewandowski | Samsung Poland RD Center | Linux/Platform
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo
to make this memory reservation dependent
on mfc* node being present in DTS. It's to early to use of_* functions
(because tree is not populated at this stage) but fdt_* family of functions
work just fine.
Regards,
--
Karol Lewandowski | Samsung Poland RD Center | Linux/Platform
On 24.04.2012 16:44, Wolfram Sang wrote:
On Tue, Apr 24, 2012 at 10:40:49AM +0200, Karol Lewandowski wrote:
On 23.04.2012 20:20, Wolfram Sang wrote:
+ if (pdev-dev.of_node) {
+ const struct of_device_id *match;
+ match = of_match_node(s3c24xx_i2c_match, pdev-dev.of_node
,
--
Karol Lewandowski | Samsung Poland RD Center | Linux/Platform
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
for
corrections (I feel kinda confident on this issue, though ;))
I'm quite happy with doing it the way you just described.
I'll resend whole patchset in a minute.
Thanks!
--
Karol Lewandowski | Samsung Poland RD Center | Linux/Platform
___
devicetree
reworks i2c-s3c2410 driver a bit to better handle
device tree-enabled platforms and adds two quirks required by
exynos4210-specific I2C controller used by s5p-hdmi driver.
This patchset is based on i2c-bjdooks/for-34/i2c/i2c-samsung branch
taken from:
git://git.fluff.org/bjdooks/linux.git
Karol
-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/i2c/busses/i2c-s3c2410.c | 75 +-
1 file changed, 34 insertions(+), 41 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses
...@samsung.com
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Tested-by: Tomasz Stanislawski t.stanisl...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
.../devicetree/bindings/i2c/samsung-i2c.txt|8 --
drivers/i2c/busses/i2c-s3c2410.c
On 17.04.2012 19:31, Wolfram Sang wrote:
Hi,
Hi Wolfram!
On Wed, Mar 21, 2012 at 08:11:52PM +0100, Karol Lewandowski wrote:
Reorganize driver a bit to better handle device tree-based systems:
- move machine type to driver's private structure instead of
quering platform device
, pdata-sda_delay);
of_property_read_u32(np, samsung,i2c-slave-addr, pdata-slave_addr);
of_property_read_u32(np, samsung,i2c-max-bus-freq,
Regards,
--
Karol Lewandowski | Samsung Poland RD Center | Linux/Platform
___
devicetree-discuss
On 21.03.2012 20:11, Karol Lewandowski wrote:
Changes since v2:
- Merge device type and flags into flat bitmask named quirks -
Consequently, treat s3c24xx as baseline hardware platform and
support all hw variations via quirks [Suggested by Mark Brown]
Changes since v1:
- Move
://permalink.gmane.org/gmane.linux.drivers.i2c/10414 ]
Karol Lewandowski (13):
regulator: Fix DT node name checking in max8997-pmic
ARM: Add document to list devices with trivial DT description
s5p-g2d: Make it possible to instantiate driver from DT
i2c-pxa: Drop leftover comment
i2c
Make it possible to instantiate SiI9234, Mobile HD Link driver (MHL),
from regular device tree description.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Tomasz Stanislawski t.stanisl...@samsung.com
---
.../devicetree
.
This patch updates few more drivers (missed out in original patch)
to use this functionality.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Wolfram Sang w.s...@pengutronix.de
---
drivers/i2c/busses/i2c-gpio.c |7
Commit 488bf314b (i2c: Allow i2c_add_numbered_adapter() to assign a
bus id) reworked i2c-pxa driver leaving obsolete comment.
This commit simply drops it.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Wolfram Sang w.s
Avoid hard lockup when someone provides non-supported regulator
name.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Thomas Abraham thomas.abra...@linaro.org
---
drivers/regulator/max8997.c |7 +++
1 files changed, 7
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Tomasz Stanislawski t.stanisl...@samsung.com
---
.../devicetree/bindings/arm/exynos/tvmixer.txt | 26
drivers/media/video/s5p-tv/mixer_drv.c
Add arm/trivial-devices.txt to enumerate devices for which only
basic resources are provided (compat, address and irq line).
This is based on i2c's trivial-devices.txt by Olof Johansson.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p
Includes v4l2/dt helper function (hdmi_of_get_i2c_subdev() that probably
should be implemented in v4l2 core itself.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Cc: Tomasz Stanislawski t.stanisl...@samsung.com
---
drivers/media/video/s5p-tv/hdmi_drv.c | 68
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Thomas Abraham thomas.abra...@linaro.org
---
arch/arm/boot/dts/exynos4210.dtsi | 16
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/arch/arm
These are needed for clk_get() to work properly in respective
drivers.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Thomas Abraham thomas.abra...@linaro.org
---
arch/arm/mach-exynos/mach-exynos4-dt.c | 10 ++
1
-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Thomas Abraham thomas.abra...@linaro.org
---
arch/arm/boot/dts/exynos4210-nuri.dts | 527 +
1 files changed, 527 insertions(+), 0 deletions(-)
create mode 100644
,
+reg_np-name);
+ continue;
+ }
+
rdata-id = i;
rdata-initdata = of_get_regulator_init_data(
iodev-dev, reg_np);
Regards,
--
Karol Lewandowski | Samsung
On 18.03.2012 19:24, Grant Likely wrote:
On Fri, 16 Mar 2012 16:42:12 +0100, Karol Lewandowski
k.lewando...@samsung.com wrote:
Make it possible to instantiate driver from device tree description.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park
On 19.03.2012 20:55, Mark Brown wrote:
On Thu, Mar 15, 2012 at 05:54:33PM +0100, Karol Lewandowski wrote:
If you consider code to be inherently less readable because of this
approach I'll rework it. If it's not a such big deal for you I would
prefer to keep it as is.
The thing
On 21.03.2012 12:50, Mark Brown wrote:
On Wed, Mar 21, 2012 at 11:33:58AM +0100, Karol Lewandowski wrote:
What do you think about following changes, then?
That looks reasonable.
Thanks. I'll incorporate this change and post whole patchset again.
Regards,
--
Karol Lewandowski | Samsung
Use standard of_match_ptr() to avoid defining variable unused
in non device tree builds.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Grant Likely grant.lik...@secretlab.ca
---
drivers/i2c/busses/i2c-s3c2410.c |4
by s5p-hdmi driver.
This patchset is based on i2c-bjdooks/for-34/i2c/i2c-samsung branch
taken from:
git://git.fluff.org/bjdooks/linux.git
Karol Lewandowski (3):
i2c-s3c2410: Drop unused define
i2c-s3c2410: Rework device type handling
i2c-s3c2410: Add HDMIPHY quirk for S3C2440
...@samsung.com
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Tested-by: Tomasz Stanislawski t.stanisl...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
.../devicetree/bindings/i2c/samsung-i2c.txt| 11 +-
drivers/i2c/busses/i2c-s3c2410.c
-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/i2c/busses/i2c-s3c2410.c | 47 ++---
1 files changed, 23 insertions(+), 24 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/video/s5p-tv/mixer_drv.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/s5p-tv/mixer_drv.c
b/drivers/media
.
DT support for s5p-tv driver itself would benefit from changes to v4l
core (missing OF helper functions) and thus, will be sent later in
separate patchset.
Karol Lewandowski (2):
s5p-tv: Add initial DT-support for TV mixer
s5p-tv: Add initial DT-support for HDMIPHY
drivers/media/video/s5p-tv
Make it possible to instantiate driver from device tree description.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Reviewed-by: Thomas Abraham thomas.abra...@linaro.org
---
drivers/media/video/s5p-tv/hdmiphy_drv.c | 10
On 14.03.2012 18:29, Mark Brown wrote:
On Tue, Mar 13, 2012 at 05:54:38PM +0100, Karol Lewandowski wrote:
- replace s3c24xx_i2c_type enum with plain unsigned int that can
hold not only device type but also hw revision-specific quirks
Would it not be clearer to just have explicit flags
On 15.03.2012 13:56, Mark Brown wrote:
On Thu, Mar 15, 2012 at 11:04:56AM +0100, Karol Lewandowski wrote:
Introducing separate type (TYPE_S3C2440_HDMIPHY) has been our original
attempt to solve this issue. However, this required adding explicit
checks to driver code all over the place
On 13.03.2012 20:21, Anton Vorontsov wrote:
On Wed, Feb 22, 2012 at 07:06:21PM +0100, Karol Lewandowski wrote:
Add fields originally found in platform data back to max17042_chip,
as the former data structure might be not available on device
tree-based systems.
This commit makes it possible
This driver requires standard properties like (address and irq)
which are automatically marshalled for drivers by OF core.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/video/s5p-g2d/g2d.c | 10 ++
1
On 13.03.2012 20:22, Anton Vorontsov wrote:
On Wed, Feb 22, 2012 at 07:06:22PM +0100, Karol Lewandowski wrote:
Allow both device tree (preferred) and platform data-based driver
instantiation.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p
by
exynos4210-specific I2C controller used by s5p-hdmi driver.
This patchset is based on i2c-bjdooks/for-34/i2c/i2c-samsung branch
taken from:
git://git.fluff.org/bjdooks/linux.git
Karol Lewandowski (3):
i2c-s3c2410: Drop unused define
i2c-s3c2410: Rework device type handling
i2c-s3c2410: Add
...@samsung.com
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Tested-by: Tomasz Stanislawski t.stanisl...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
.../devicetree/bindings/i2c/samsung-i2c.txt| 10 -
drivers/i2c/busses/i2c-s3c2410.c
Use standard of_match_ptr() to avoid defining variable unused
in non device tree builds.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/i2c/busses/i2c-s3c2410.c |4 +---
1 files changed, 1 insertions(+), 3
-specific quirks
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/i2c/busses/i2c-s3c2410.c | 53 +++---
1 files changed, 32 insertions(+), 21 deletions(-)
diff --git a/drivers/i2c/busses/i2c
On 13.03.2012 18:27, Tomasz Stanislawski wrote:
Hi Karol,
Please refer to comments below,
Regards,
Tomasz Stanislawski
On 03/13/2012 05:54 PM, Karol Lewandowski wrote:
This patch adds support for s3c2440 I2C bus controller dedicated HDMIPHY
device on
Exynos4 platform. Some quirks
...@samsung.com
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Tested-by: Tomasz Stanislawski t.stanisl...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
.../devicetree/bindings/i2c/samsung-i2c.txt| 11 +-
drivers/i2c/busses/i2c-s3c2410.c
On 12.03.2012 06:58, Thomas Abraham wrote:
Hi Thomas!
On 9 March 2012 22:34, Karol Lewandowski k.lewando...@samsung.com wrote:
Reorganize driver a bit to better handle device tree-based systems:
- move machine type to driver's private structure instead of
quering platform device variants
/bjdooks/linux.git
Karol Lewandowski (1):
i2c-s3c2410: Rework device type handling
Tomasz Stanislawski (1):
i2c-s3c2410: Add HDMIPHY quirk for S3C2440
.../devicetree/bindings/i2c/samsung-i2c.txt| 10 ++-
drivers/i2c/busses/i2c-s3c2410.c | 90
2
-specific quirks
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/i2c/busses/i2c-s3c2410.c | 56 +
1 files changed, 20 insertions(+), 36 deletions(-)
diff --git a/drivers/i2c/busses/i2c
Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Tested-by: Tomasz Stanislawski t.stanisl...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
.../devicetree/bindings/i2c/samsung-i2c.txt| 10
On 08.03.2012 09:50, Jean-Christophe PLAGNIOL-VILLARD wrote:
+static int __devinit of_i2c_gpio_probe(struct device_node *np,
+ struct i2c_gpio_platform_data *pdata)
+{
+ u32 reg;
+
+ if (of_gpio_count(np) 2)
+ return -ENODEV;
+
+
On 01.03.2012 04:09, Thomas Abraham wrote:
Hi Karol,
Hi!
On 29 February 2012 20:21, Karol Lewandowski k.lewando...@samsung.com wrote:
Make it possible to instantiate sii9234, HDMI's MHL, from regular
device tree description.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
On 01.03.2012 04:18, Thomas Abraham wrote:
On 29 February 2012 20:21, Karol Lewandowski k.lewando...@samsung.com wrote:
---
drivers/media/video/s5p-tv/mixer_drv.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/s5p-tv/mixer_drv.c
b
This patchset adds initial device tree support to drivers used by
s5p-tv on Exynos4.
DT support for s5p-tv driver itself would benefit from changes to v4l
core (missing OF helper functions) and thus, will be sent later in
separate patchset.
Karol Lewandowski (3):
[media] s5p-tv: Add initial DT
.
Karol Lewandowski (3):
max17042_battery: Use devm_kzalloc() where applicable
max17042_battery: Preserve properties outside of platform data
max17042_battery: Make it possible to instantiate driver from DT
.../bindings/power_supply/max17042_battery.txt | 18 +
drivers/power
This allows us to simplify probe and exit function.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/power/max17042_battery.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/power
Add fields originally found in platform data back to max17042_chip,
as the former data structure might be not available on device
tree-based systems.
This commit makes it possible to safely declare platform data with
__initdata tag.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Allow both device tree (preferred) and platform data-based driver
instantiation.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
.../bindings/power_supply/max17042_battery.txt | 18
drivers/power
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
arch/arm/boot/dts/exynos4210.dtsi | 16
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4210.dtsi
b/arch/arm/boot/dts
- my email address lacks 'i' at the end, i.e. it's
k.lewandowsk@ :)
Signed-off-by: Thomas Abrahamthomas.abra...@linaro.org
---
This patch solves the issue of boot failure with SMP enabled kernel for
Exynos4 device tree enabled machine.
Tested-by: Karol Lewandowski k.lewando...@samsung.com
On 31.01.2012 18:56, Thomas Abraham wrote:
Add device tree based discovery support for Samsung's sdhci controller
Works fine on nuri hardware using exynos4-dt (with custom dts).
Thanks
___
devicetree-discuss mailing list
-by: Tushar Beheratushar.beh...@linaro.org
Signed-off-by: Thomas Abrahamthomas.abra...@linaro.org
Tested-by: Karol Lewandowski k.lewando...@samsung.com
Fixes following Oops in i2c-s3c24xx.
Thanks
1Unable to handle kernel NULL pointer dereference at virtual address
1pgd = c0004000
1
[] = {
+ { .compatible = gpio-i2c, },
There seem to be no good reason to make DT-compatible string different
from driver's name that's already in use:
static struct platform_driver i2c_gpio_driver = {
.driver = {
.name = i2c-gpio,
Regards,
--
Karol Lewandowski | Samsung
On 07.02.2012 04:25, Jean-Christophe PLAGNIOL-VILLARD wrote:
On 19:38 Mon 06 Feb , Karol Lewandowski wrote:
+ - udelay: half clock cycle time in us (may depend on each platform)
Could we use clock-frequency as Grant have suggested during review
of previous patch to i2c-gpio
64 matches
Mail list logo
