} else
> + if (!np)
I'm assuming you've reversed the semantics here for >80 chars reasons?
I see no harm in it though.
Acked-by: Lee Jones
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook
blockid);
> + continue;
> + }
> +
> + ret = stmpe_add_device(stmpe, block->cell);
> + if (ret)
> + return ret;
> + }
> +
> + return ret;
> +}
> +
> +#else
> +stat
t.
Cc: Samuel Ortiz
Cc: devicetree-discuss@lists.ozlabs.org
Signed-off-by: Lee Jones
---
Documentation/devicetree/bindings/mfd/stmpe.txt |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/stmpe.txt
b/Documentation/devicetree/bindings
, "ts,mod-12b", &val))
> >> + pdata->mod_12b = val;
> >> + if (!of_property_read_u32(np, "ts,ref-sel", &val))
> >> + pdata->ref_sel = val;
> >> + if (!of_property_read_u32(np, "ts,adc-freq&qu
On Thu, 22 Nov 2012, Viresh Kumar wrote:
> On 22 November 2012 21:16, Lee Jones wrote:
> >> >> diff --git a/Documentation/devicetree/bindings/mfd/stmpe.txt
> >> >> b/Documentation/devicetree/bindings/mfd/stmpe.txt
> >> >> +- irq-over-gpio: bool
On Fri, 23 Nov 2012, Shiraz Hashim wrote:
> On Thu, Nov 22, 2012 at 10:31:48PM +0530, Viresh Kumar wrote:
> > On 22 November 2012 21:16, Lee Jones wrote:
> > > The STMPE GPIO controller can't be used by Device Tree yet in
> > > any case, because it doe
On Fri, 23 Nov 2012, Viresh Kumar wrote:
> On 22 November 2012 16:54, Lee Jones wrote:
> >> diff --git a/Documentation/devicetree/bindings/mfd/stmpe.txt
> >> b/Documentation/devicetree/bindings/mfd/stmpe.txt
> >> stmpe1601: stmpe1601@40 {
>
> >>
On Fri, 23 Nov 2012, Viresh Kumar wrote:
> On 22 November 2012 16:54, Lee Jones wrote:
> >> diff --git a/Documentation/devicetree/bindings/mfd/stmpe.txt
> >> b/Documentation/devicetree/bindings/mfd/stmpe.txt
> >> +Optional properties:
> >> +- irq-trigger:
On Thu, 22 Nov 2012, Viresh Kumar wrote:
> On 22 November 2012 15:57, Lee Jones wrote:
> > On Thu, 22 Nov 2012, Viresh Kumar wrote:
> >
> >> This patch frees stmpe driver from tension of freeing resources :)
> >> devm_* derivatives of multiple routines are used
On Fri, 23 Nov 2012, Lee Jones wrote:
> On Thu, 22 Nov 2012, Viresh Kumar wrote:
>
> > On 22 November 2012 15:57, Lee Jones wrote:
> > > On Thu, 22 Nov 2012, Viresh Kumar wrote:
> > >
> > >> This patch frees stmpe driver from tension of freeing resource
ings.
> - Bindings are updated in binding document.
>
> Signed-off-by: Vipul Kumar Samar
> Signed-off-by: Viresh Kumar
> ---
> V2->V3:
> --
> - Removed sub-modules DT bindings from this patch
> - Retain original work done by Lee Jones
>
>
name = "stmpe-gpio",
> + .of_compatible = "st,stmpe-gpio",
There's no need for any of the STMPE to have their own compatible
string, as they are MFD devices. They are registered as platform
devices from the MFD subsystem.
> .resources = stmpe_g
,0 +1,18 @@
> > +STMPE gpio
> > +--
> > +
> > +Required properties:
> > + - compatible: "st,stmpe-gpio"
... but this is wrong.
> > +Example:
> > + stmpe_gpio {
> > + compatible = "st,stmpe-gpio";
> > + st
c-freq = <1>;
> + st,ave-ctrl = <1>;
> + st,touch-det-delay = <2>;
> + st,settling = <2>;
> + st,fraction-z = <7>;
> + st,i-drive = <1>;
> +
_node, np) {
> if (of_device_is_compatible(np, cell->of_compatible))
> {
> pdev->dev.of_node = np;
> break;
> }
> }
> }
>
> This
u32(np, "st,norequest-mask",
> >> + &pdata->norequest_mask);
> >
> > Can you explain to me what this does?
>
> You mean pdata->norequest_mask? It marks few gpios as unusable.
> Because these pads might be u
On Fri, 23 Nov 2012, Viresh Kumar wrote:
> On 23 November 2012 15:06, Lee Jones wrote:
> > On Fri, 23 Nov 2012, Viresh Kumar wrote:
> >> pdev = platform_device_alloc(cell->name, id + cell->id);
> >>
> >> This is required when we have multiple ins
On Fri, 23 Nov 2012, Viresh Kumar wrote:
> On 23 November 2012 17:44, Lee Jones wrote:
> > I'm saying, just leave it where it is.
>
> So you are suggesting this code:
>
> stmpe_gpio->chip.base = pdata ? pdata->gpio_base : -1;
>
>
he host
> >> + - irq-invert-polarity : bool, IRQ line is connected with
> >> reversed polarity
> >
> > This looks odd. Normally the interrupt polarity should be encoded in the irq
> > specifier flags field.
>
> Hi Grant and Lee Jones,
>
> This
> .num_resources = ARRAY_SIZE(stmpe_gpio_resources),
> };
>
> static struct mfd_cell stmpe_gpio_cell_noirq = {
> .name = "stmpe-gpio",
> + .of_compatible = "st,stmpe-gpio",
> /* gpio cell resources consist of an irq o
On Fri, 23 Nov 2012, Shiraz Hashim wrote:
> On Fri, Nov 23, 2012 at 12:14:13PM +0000, Lee Jones wrote:
> > > >> + if (np)
> > > >> + of_property_read_u32(np, "st,norequest-mask",
> > > >> +
d, i sorted it out
> in a separate patch.
Why do you need to sort them? Is there _really_ a need?
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
___
On Mon, 26 Nov 2012, Viresh Kumar wrote:
> On 26 November 2012 18:55, Lee Jones wrote:
>
> > Why do you need to sort them? Is there _really_ a need?
>
> Many people & maintainers like to have their header files ordered. The
> reason for that is:
>
> If t
ose interrupt controller needs Rising edge interrupt, but
> the board has inverted the line between stmpe and IC. So, we will get
> Rising high from the routine you mentioned, but we need to generate
> opposite of that to make it rising high.
Surely that would be a hardware design error/q
On Wed, 28 Nov 2012, Viresh Kumar wrote:
> On 28 November 2012 01:25, Rabin Vincent wrote:
> > 2012/11/27 Viresh Kumar :
> >> On 27 November 2012 14:10, Lee Jones wrote:
> >> I haven't seen this in any of SPEAr boards i have worked on. Maybe Rabin
> >>
> some board mistakes or quirks.
>
> So, better get rid of it. This is earlier discussed here:
>
> https://lkml.org/lkml/2012/11/27/636
>
> Signed-off-by: Viresh Kumar
Glad to see the back of it:
Acked-by: Lee Jones
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.o
pdata->blocks |= STMPE_BLOCK_GPIO;
> - }
> - if (!strcmp(child->name, "stmpe_keypad")) {
> + } else if (!strcmp(child->name, "stmpe_keypad")) {
> pdata->blocks |= STMPE_BLOCK_KEYPAD;
&
On Thu, 29 Nov 2012, Lee Jones wrote:
> On Thu, 29 Nov 2012, Viresh Kumar wrote:
>
> > From: Vipul Kumar Samar
> >
> > This patch extends existing DT support for stmpe devices. This updates:
> > - DT support from stmpe SPI and I2C drivers
> &g
gt;irq, NULL,
> - stmpe_irq, pdata->irq_trigger | IRQF_ONESHOT,
> - "stmpe", stmpe);
> + stmpe_irq, IRQF_ONESHOT, "stmpe", stmpe);
Forgive my ignorance, but you're no longe
; V4->V5:
> > --
> > - 2/3 and 3/3 merged.
> > - irq_trigger is kept same for non-DT booti.
> >
> > @Lee: I haven't added your Acked-by, because this differs from your Acked
> > version.
> Lee, are you ok with this one ? Could you give it a test
On Fri, 30 Nov 2012, Viresh Kumar wrote:
> On 30 November 2012 18:15, Lee Jones wrote:
> > The patch doesn't apply for me - does it for you?
> >
> > Viresh, what's it based on?
>
> Because this was applied 2 days back by Samuel, and i didn'
t ?
Okay, I've tested it, and it doesn't break anything.
But ... I don't see how the changes in the -i2c and -spi files
are of benefit either. When I boot without the ID table I still
get "stmpe-i2c 0-0040: stmpe1601 detected, chip id: 0x212".
What is it that actually uses t
; > On 30 November 2012 21:15, Lee Jones wrote:
> >> But ... I don't see how the changes in the -i2c and -spi files
> >> are of benefit either. When I boot without the ID table I still
> >> get "stmpe-i2c 0-0040: stmpe1601 detected, chip id: 0x212&
ecause you
think it's the right thing to do?
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.
On Thu, 06 Dec 2012, Viresh Kumar wrote:
> On 6 December 2012 15:20, Lee Jones wrote:
> >> > But regardless, it is the responsiblity of the probe function to go and
> >> > look if of_driver_match_device() matches against anything if it cares
> >> > about t
On Thu, 06 Dec 2012, Viresh Kumar wrote:
> On 6 December 2012 15:41, Lee Jones wrote:
> > So then I'm back to my original question, why?
> >
> > What is it used for? What difference does it make?
> >
> > I could understand if the .data attribute was used in
On Thu, 06 Dec 2012, Viresh Kumar wrote:
> On 6 December 2012 16:05, Lee Jones wrote:
> >> > Or you could not put unnecessary bindings into the Device Tree
> >> > by putting two and two together and realise that using the table
> >> > is the correct t
On Thu, 06 Dec 2012, Viresh Kumar wrote:
> On 6 December 2012 16:42, Lee Jones wrote:
> > I thought we'd be over this? The 'ID' will be represented by the
> > address of the chip i.e. stmpe1601@40, where '40' will be
> > distinguishing factor?
ent.
>
> Acked-by: Lee Jones
> Signed-off-by: Vipul Kumar Samar
> Signed-off-by: Viresh Kumar
> ---
> Hi Samuel,
>
> I have added acked by Lee as he earlier Acked this patch, most of the part is
> still the same. And nothing new added.
>
> V5->V6:
ing DT to work with their systems, like the V4L people with the
> order
> of initialization; see http://lwn.net/Articles/531068/. I think the V4L
> problem is
> cleanly solved by the overlay being contained in the V4L device node an
On Tue, 08 Jan 2013, Pantelis Antoniou wrote:
> Hi Lee,
>
> On Jan 8, 2013, at 12:00 PM, Lee Jones wrote:
>
> >>>>> At the end of the line, some kind of hardware glue is going to be
> >>>>> needed.
> >>>>>
> >&g
On Tue, 08 Jan 2013, Arnd Bergmann wrote:
> On Tuesday 08 January 2013, Pantelis Antoniou wrote:
> > On Jan 8, 2013, at 2:12 PM, Arnd Bergmann wrote:
> >
> > > On Tuesday 08 January 2013, Lee Jones wrote:
> > >>> If there is not, there is no way to automa
On Thu, 10 Jan 2013, Linus Walleij wrote:
> On Tue, Jan 8, 2013 at 12:14 PM, Viresh Kumar wrote:
> > On 8 January 2013 16:41, Lee Jones wrote:
> >>> Hmm.. I tried a bit, but couldn't find any such call :(
> >>> Probably an assumption is taken here. GPIO pin
nit(v2m_sysreg_base + V2M_SYS_24MHZ,
> 2400);
> }
>
> -static struct of_device_id vexpress_irq_match[] __initdata = {
> - { .compatible = "arm,cortex-a9-gic", .data = gic_of_init, },
> - {}
> -};
> -
> -static void __in
L),
> OF_DEV_AUXDATA("st,nomadik-i2c", 0x80004000, "nmk-i2c.0", NULL),
In this case, once we have added common clk functionality to our
Device Trees, these will vanish.
Kind regards,
Lee
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for AR
On Mon, 25 Mar 2013, Linus Walleij wrote:
> On Mon, Mar 25, 2013 at 5:46 PM, Lee Jones wrote:
>
> >> > res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> >> >"prcmu-tcpm");
> >> >
On Tue, 26 Mar 2013, Linus Walleij wrote:
> On Tue, Mar 26, 2013 at 9:17 AM, Lee Jones wrote:
> > On Mon, 25 Mar 2013, Linus Walleij wrote:
> >> On Mon, Mar 25, 2013 at 5:46 PM, Lee Jones wrote:
> >>
> >> >> > res = plat
On Tue, 26 Mar 2013, Arnd Bergmann wrote:
> On Tuesday 26 March 2013, Lee Jones wrote:
> > Bit for information for you.
> >
> > I have confirmed that the address locations are the same for
> > all SoCs are the same. However, the size of the TCDM changes from 4k
>
ode, loopback clock
> > (in devconf0/devconf1/prog_io1 register for omap3) and pull strength
> > configuration (in control_mmc1 for omap4)
> >
> > Signed-off-by: Balaji T K
>
> You *need* Lee Jones and Mark Brown to review this.
> Maybe Laurent has something t
On Thu, 13 Jun 2013, Balaji T K wrote:
> On Thursday 13 June 2013 04:17 PM, Lee Jones wrote:
> >On Thu, 13 Jun 2013, Linus Walleij wrote:
> >
> >>On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote:
> >>
> >>>PBIAS register configuration is based on th
Ortiz
Why does Grant have to pull this?
Do you know why Sam didn't take it?
I'd be happy to, if it wasn't stepping on anyone's toes.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_
> and also the generic series names
>ti,palmas
> - interrupt-controller : palmas has its own internal IRQs
Applied.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
changed, 6 insertions(+), 0 deletions(-)
Applied with Stephen and Mark's RB.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
___
devicetree-discuss
On Thu, 11 Jul 2013, Lee Jones wrote:
> On Wed, 19 Jun 2013, Keerthy wrote:
>
> > From: J Keerthy
> >
> > Check if irq value obtained is valid. If it is not valid
> > then skip the irq request step and go ahead with the probe.
> >
> > Signed-o
to supply this as AUXDATA for an I2C
> device. The style and bindings are heavily inspired by
> Lee Jones' style for AB8500.
>
> Cc: Lee Jones
> Cc: Mark Brown
> Signed-off-by: Linus Walleij
I don't see any issues with it.
Acked-by: Lee Jones
> ---
> Hi Mar
Williams
Cc: Per Forlin
Cc: Rabin Vincent
Cc: Rob Herring
Cc: devicetree-discuss@lists.ozlabs.org
Reviewed-by: Arnd Bergmann
Signed-off-by: Lee Jones
---
.../devicetree/bindings/dma/ste-dma40.txt | 62
drivers/dma/ste_dma40.c| 52
This patch will allow ux500-musb to be probed and configured solely from
configuration found in Device Tree.
Cc: Felipe Balbi
Cc: Rob Herring
Cc: linux-...@vger.kernel.org
Cc: devicetree-discuss@lists.ozlabs.org
Acked-by: Linus Walleij
Acked-by: Fabio Baltieri
Signed-off-by: Lee Jones
tely in the wrong subsystem (not your
> fault) so I suspect the binding doc should be in
> Documentation/devicetree/bindings/adc/ab8500.txt or
> something.
All of the AB8500 devices are covered in the aforementioned file and
to my knowledge none of them are represen
This patch will allow ux500-musb to be probed and configured solely from
configuration found in Device Tree.
Cc: Felipe Balbi
Cc: Rob Herring
Cc: linux-...@vger.kernel.org
Cc: devicetree-discuss@lists.ozlabs.org
Acked-by: Linus Walleij
Acked-by: Fabio Baltieri
Signed-off-by: Lee Jones
insertions(+), 8 deletions(-)
Acked-by: Lee Jones
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
___
devicetree-discuss mailing list
devicetree-dis
es and
> functionality does not vary with board family.
>
> This moves the enablement into the SoC file.
>
> Cc: Lee Jones
> Signed-off-by: Linus Walleij
> ---
> arch/arm/boot/dts/dbx5x0.dtsi | 4
> arch/arm/boot/dts/snowball.dts | 8
> 2 files chan
On Fri, 24 May 2013, Linus Walleij wrote:
> On Fri, May 24, 2013 at 10:27 AM, Lee Jones wrote:
> > On Fri, 24 May 2013, Linus Walleij wrote:
> >> From: Linus Walleij
> >>
> >> Commits:
> >> "ARM: ux500: Add Device Tree nodes for the ux500 Cry
Sounds fine.
Acked-by: Lee Jones
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://li
t; ---
> arch/arm/boot/dts/dbx5x0.dtsi | 104
> +
> arch/arm/boot/dts/href.dtsi| 5 +-
> arch/arm/boot/dts/snowball.dts | 2 +-
> arch/arm/boot/dts/stuib.dtsi | 4 +-
> 4 files changed, 60 insertions(+), 55 deletions(-)
/me lik
t; i2c@80128000 {
> > - lp5521@0x33 {
> > - compatible = "lp5521";
> > + lp5521@33 {
>
> Is this right, I guess it should be still "lp5521@0x33", although it's
> jus
regulator-max-microvolt = <1500000>;
> + };
> +
> + ldo7_reg: ldo7 {
> + regulator-name = "ldo7";
> + regulator-min-microvolt = <150>;
> + regulator-max-microv
On Mon, 03 Jun 2013, Stephen Warren wrote:
> On 06/03/2013 08:18 AM, Lee Jones wrote:
> > On Mon, 03 Jun 2013, J Keerthy wrote:
> >> Add the various binding files for the palmas family of chips. There is a
> >> top level MFD binding then a seperate binding for regulato
On Mon, 03 Jun 2013, Bryan Wu wrote:
> On Mon, Jun 3, 2013 at 1:18 AM, Lee Jones wrote:
> > On Fri, 31 May 2013, Bryan Wu wrote:
> >
> >> On Wed, May 22, 2013 at 1:12 AM, Linus Walleij
> >> wrote:
> >> > From: Linus Walleij
> >> >
On Tue, 04 Jun 2013, Linus Walleij wrote:
> From: Linus Walleij
>
> This removes the "0x" prefix in front of the I2C DT device
> address designation for each I2C DT node in the ux500
> devicetree files.
>
> Reported-by: Bryan Wu
> Cc: Lee Jones
> Signed
regulator/palmas-pmic.txt
Is there a driver to go with this patch, or was the documentation an
afterthought in this case? If the latter is true I'd be happy to apply
this patch with an Ack from Stephen or one of the other previous
reviewers.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
0_MGT_SET as described
by the design specification, and use that as our indexer.
> I hope Mike can give some better insight to what his preferences are.
>
> Arnd
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebo
reate mode 100644 Documentation/devicetree/bindings/mfd/palmas.txt
> create mode 100644
> Documentation/devicetree/bindings/regulator/palmas-pmic.tx
Applied, thanks.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for A
On Thu, 06 Jun 2013, Lee Jones wrote:
> On Thu, 06 Jun 2013, J Keerthy wrote:
>
> > Add the various binding files for the palmas family of chips. There is a
> > top level MFD binding then a seperate binding for regulators IP blocks on
> > chips.
> >
>
for _all_ platforms which include
them. Anything that is only relevant to a sub-set of boards should be
in a higher ranking .dtsi file and finally, any settings which are
board specific should be in the board's .dts file.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open sourc
rovolt = <330>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldoln_reg: ldoln {
> + regulator-min-mi
On Mon, 10 Jun 2013, J, KEERTHY wrote:
> Hello Grant/Lee Jones,
>
> > -Original Message-
> > From: Lee Jones [mailto:lee.jo...@linaro.org]
> > Sent: Thursday, June 06, 2013 12:36 PM
> > To: J, KEERTHY
> > Cc: linux-ker...@vger.kernel.org; gra
ulator-max-microvolt = <330>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + ldoln_reg: ldoln {
> + regulator-min-microvolt = <180>;
> +
77 matches
Mail list logo
