Re: [PATCH v2 3/4] usb: chipidea: ci13xxx-imx: add dr_mode property to device tree bindings

2012-07-03 Thread Lothar Waßmann
? And to decide whether it's otg controller or not, the driver read the capability registers. A user may wish to restrict even a 'fine otg hw design' to be used in pure host or device mode. That's where the dr_mode property jumps in. Lothar Waßmann

Re: [PATCH] MXS: Add DT binding support into stmp3xxx-rtc

2012-06-06 Thread Lothar Waßmann
Hi, Shawn Guo writes: On Sun, May 27, 2012 at 04:11:29AM +0200, Marek Vasut wrote: Add simple binding for the stmp3xxx-rtc. Signed-off-by: Marek Vasut ma...@denx.de Cc: Alessandro Zummo a.zu...@towertech.it Cc: devicetree-discuss@lists.ozlabs.org Cc: Grant Likely

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-20 Thread Lothar Waßmann
Hi, Dong Aisheng writes: On Mon, Mar 19, 2012 at 3:02 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Mon, 19 Mar 2012 17:49:02 +0100, Lothar Waßmann l...@karo-electronics.de wrote: Hi, Grant Likely writes: On Mon, 19 Mar 2012 07:54:33 +0100, Lothar Waßmann l...@karo

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-19 Thread Lothar Waßmann
Hi, Grant Likely writes: On Fri, 16 Mar 2012 11:01:35 +0800, Dong Aisheng aisheng.d...@freescale.com wrote: On Thu, Mar 15, 2012 at 07:22:04PM +0800, Lothar Waßmann wrote: Hi, Dong Aisheng writes: On Thu, Mar 15, 2012 at 02:53:29PM +0800, Lothar Waßmann wrote: Hi

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-19 Thread Lothar Waßmann
Hi, Grant Likely writes: On Mon, 19 Mar 2012 07:54:33 +0100, Lothar Waßmann l...@karo-electronics.de wrote: Grant Likely writes: On Fri, 16 Mar 2012 11:01:35 +0800, Dong Aisheng aisheng.d...@freescale.com wrote: On Thu, Mar 15, 2012 at 07:22:04PM +0800, Lothar Waßmann wrote

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-16 Thread Lothar Waßmann
Hi, Dong Aisheng writes: On Thu, Mar 15, 2012 at 07:22:04PM +0800, Lothar Waßmann wrote: [...] My proposal is only set the fixed part(first two octets) in board dts file, each board knows it's value, and read the left 4 octets from OCOTP dynamically. The OUI part is three bytes, not two

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-15 Thread Lothar Waßmann
Hi, Dong Aisheng writes: On Thu, Mar 15, 2012 at 02:53:29PM +0800, Lothar Waßmann wrote: Hi, Dong Aisheng writes: On Wed, Mar 14, 2012 at 10:16:43PM +0800, s.ha...@pengutronix.de wrote: On Wed, Mar 14, 2012 at 08:45:23PM +0800, Dong Aisheng wrote: On Wed, Mar 14, 2012 at 01:23

RE: [RFC PATCH v3 1/5] dt: add of_get_child_count helper function

2011-12-20 Thread Lothar Waßmann
someone used '=' instead of '=='. You should make it clear that that's not the case like: | while ((child = of_get_next_child(np, child)) != NULL) Lothar Waßmann -- ___ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen

Re: [PATCH REPOST 2/2] i2c-imx: add device tree probe support

2011-09-09 Thread Lothar Waßmann
have no errata. Fortunately there is an i2c-gpio driver that can be used on the corresponding pins. ;-) Lothar Waßmann -- ___ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10

Re: [PATCH v2 1/7] spi/imx: do not make copy of spi_imx_devtype_data

2011-07-22 Thread Lothar Waßmann
Hi, Shawn Guo writes: On Mon, Jul 11, 2011 at 09:15:34AM +0200, Lothar Waßmann wrote: Hi, Shawn Guo writes: spi_imx_devtype_data has already been driver private data. There is really no need to make a copy in spi_imx_data. Instead, a reference pointer works perfectly fine

Re: [PATCH v2 1/7] spi/imx: do not make copy of spi_imx_devtype_data

2011-07-22 Thread Lothar Waßmann
needed and discard everything else after initialisation. Lothar Waßmann -- ___ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag