On Fri, Jul 19, 2013 at 05:42:57PM +0800, Bo Shen wrote:
> Add wm8904 based audio machine driver for Atmel EK board
Applied, thanks though...
> + mclk = clk_get(NULL, "pck0");
> + if (IS_ERR(mclk)) {
> + dev_err(&pdev->dev, "failed to get pck0\n");
> + ret = PTR_ER
On Fri, Jul 19, 2013 at 06:14:51PM +0800, Robin Gong wrote:
> Add pfuze100 regulator driver.
Looks good, there's some minor issues below but they should be small.
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -158,6 +158,13 @@ config REGULATOR_MC13892
> Say y h
On Thu, Jul 18, 2013 at 07:00:32PM +0200, Gerhard Sittig wrote:
> + psc_num = master->bus_num;
> + snprintf(clk_name, sizeof(clk_name), "psc%d_mclk", psc_num);
> + mps->clk_mclk = clk_get(dev, clk_name);
> + if (IS_ERR(mps->clk_mclk))
> + goto free_irq;
Should be using
On Thu, Jul 18, 2013 at 10:06:57AM +0200, Sascha Hauer wrote:
> I think regmap has the potential to solve a number of issues like the
> hardcoded readl/writel in the common clock blocks, issues with i2c
> clocks and your endianess issue. The biggest question probably is how
> to get there without
On Wed, Jul 17, 2013 at 06:34:48PM +0300, Dan Carpenter wrote:
> In xilinx_spi_probe() we use xspi->irq to store negative error codes so
> it has to be signed. We weren't going to use the upper bit any way so
> this is fine.
Applied, thanks.
signature.asc
Description: Digital signature
On Wed, Jul 17, 2013 at 04:26:28PM +0200, Gerhard Sittig wrote:
> On Wed, Jul 17, 2013 at 13:07 +0100, Mark Brown wrote:
> > This is a pretty long e-mail. It'd probably have taken less time to
> > fix the issues than to reply to the e-mail... but anyway.
> Not quite
On Wed, Jul 17, 2013 at 03:26:38PM +0300, Dan Carpenter wrote:
> "xspi->irq" is unsigned int so it's never less than zero. I have added
> a cast.
Why is this better than changing irq to a signed type?
signature.asc
Description: Digital signature
___
d
On Wed, Jul 17, 2013 at 01:22:29PM +0200, Gerhard Sittig wrote:
> On Mon, Jul 15, 2013 at 21:17 +0100, Mark Brown wrote:
> > On Mon, Jul 15, 2013 at 08:47:30PM +0200, Gerhard Sittig wrote:
> > > sprintf(name, "psc%d_mclk", master->bus_num);
> > &g
On Tue, Jul 16, 2013 at 11:41:08AM -0500, Nishanth Menon wrote:
> We seem to have a few missing updates to device tree bindings with the
> latest set of changes getting merged in.
Applied both, thanks.
signature.asc
Description: Digital signature
___
d
On Tue, Jul 16, 2013 at 09:27:10AM -0500, Nishanth Menon wrote:
> On 09:23-20130716, Nishanth Menon wrote:
> > We seem to have a few missing updates to device tree bindings with the
> > latest set of changes getting merged in.
> Oops.. seems like I have an old mailID for Mark :(
I'll need the ac
On Tue, Jul 16, 2013 at 08:05:07PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
Applied, thanks.
signature.asc
Description: Digital signature
__
From: Mark Brown
Currently there is no specific handling for it but the tlv320aic3106 is
supported using this driver.
Signed-off-by: Mark Brown
---
Documentation/devicetree/bindings/sound/tlv320aic3x.txt | 1 +
sound/soc/codecs/tlv320aic3x.c | 2 ++
2 files changed, 3
From: Mark Brown
The driver supports a range of devices but currently doesn't allow those
device names to be used for enumeration on DT. Add the currently listed
I2C IDs as compatible strings.
Signed-off-by: Mark Brown
---
Documentation/devicetree/bindings/sound/tlv320aic3x.tx
On Mon, Jul 15, 2013 at 08:47:30PM +0200, Gerhard Sittig wrote:
> clocks need to get prepared before they can get enabled,
> fix the MPC512x PSC SPI master's initialization
> Signed-off-by: Gerhard Sittig
> ---
> drivers/spi/spi-mpc512x-psc.c |2 +-
> 1 file changed, 1 insertion(+), 1 deleti
On Mon, Jul 15, 2013 at 11:41:57AM -0700, Greg KH wrote:
> On Mon, Jul 15, 2013 at 06:06:00PM +0100, Mark Brown wrote:
> > At the minute it's about at the level of saying that if you're not sure
> > or don't know you should get the devicetree-discuss mailing l
On Mon, Jul 15, 2013 at 09:56:20AM -0700, Greg KH wrote:
> How about a hint for subsystem maintainers as to what exactly we should
> be looking for with these bindings? I for one have no idea what is
> "right" vs. "wrong" with them, so a document explaining this would be
> good to have.
> Or if
On Mon, Jul 15, 2013 at 04:53:46PM +0200, Richard Genoud wrote:
> 2013/7/12 Mark Brown :
> > This isn't going to work with systems which have a variable clock as the
> > input to the CODEC. If it's imposing constraints the driver needs to
> > allow setting the clo
On Sat, Jul 13, 2013 at 12:15:12AM +0800, Robin Gong wrote:
Please fix your mail program to word wrap between paragraphs.
> On Fri, Jul 12, 2013 at 03:40:37PM +0100, Mark Brown wrote:
> > > +static const int pfuze100_swbst[] = {
> > > + 500, 505, 510, 515
On Fri, Jul 12, 2013 at 12:54:15PM +0800, Robin Gong wrote:
> Add pfuze100 regulator driver.
This looks mostly good. A few small issues below but nothing major.
> +enum pfuze_id {
> + PFUZE_ID_PFUZE100,
> + PFUZE_ID_INVALID,
> +};
> +struct pfuze_chip {
Missing blank line here - there a
On Thu, Jul 11, 2013 at 06:15:54PM +0200, Richard Genoud wrote:
> From: Nicolas Ferre
>
> Description of the Asoc machine driver for an at91sam9x5 based board
ASoC.
> +sam9x5 pins:
> + * LOUT
> + * ROUT
> + * LHPOUT
> + * RHPOUT
> + * LLINEIN
> + * RLINEIN
> + * MICIN
These aren't pins on the
On Thu, Jul 11, 2013 at 06:15:53PM +0200, Richard Genoud wrote:
Please always try to use commit logs that look like normal commit logs
for the subsystem.
> switch (freq) {
> - case 11289600:
> case 1200:
> + wm8731->constraints = &wm8731_constraints_1200;
> +
On Mon, Jun 03, 2013 at 03:18:51PM +0100, Lee Jones wrote:
> On Mon, 03 Jun 2013, J Keerthy wrote:
> > + optional chip specific regulator fields :-
> > + ti,warm-reset - maintain voltage during warm reset(boolean)
> Pushing the boat out a bit here, but is it possible to reuse
>
On Wed, Jul 10, 2013 at 11:48:27AM +0200, Richard Genoud wrote:
> 2013/7/9 Mark Brown :
> > ...this first example is now invalid and should probably just be being
> > extended with the new required properties.
> Well, I have to rewrite that to make it clearer.
> The th
On Wed, Jul 10, 2013 at 11:25:37AM +0200, Richard Genoud wrote:
> 2013/7/9 Mark Brown :
> > Shouldn't the SSC driver be enforcing this constraint if it comes from
> > the SSC hardware? If the clock is reprogrammable the usual convention
> > for drivers is to not constr
On Tue, Jul 09, 2013 at 11:04:23AM -0500, Nishanth Menon wrote:
> On 07/09/2013 10:29 AM, Mark Brown wrote:
> >This seems like something we should be able to cope with by for example
> >adding a bus for the custom PMIC interface or otherwise finding a way to
> I had consid
On Mon, Jul 08, 2013 at 12:22:36PM -0500, Nishanth Menon wrote:
> case #1 - TPS62361 has a single SMPS and a single generic i2c bus,
> one can talk on. In this case, you'd associate the regulator device
> in one place - i2cX or on custom SoC hardware interface.
> When used with custom SoC hardwar
On Tue, Jul 09, 2013 at 04:25:29PM +0200, Richard Genoud wrote:
> - reg: Should contain SSC registers location and length
> - interrupts: Should contain SSC interrupt
> +For dma transfer:
> +- dmas: DMA specifier, consisting of a phandle to DMA controller node,
> + the memory interface and SSC
On Tue, Jul 09, 2013 at 04:25:28PM +0200, Richard Genoud wrote:
> This add the sound DT binding for sam9x5ek-wm8731 machine driver
>
> Signed-off-by: Richard Genoud
> ---
> .../bindings/sound/atmel-sam9x5-wm8731-audio.txt | 30
>
Put new binding documents in the same pa
On Tue, Jul 09, 2013 at 04:25:27PM +0200, Richard Genoud wrote:
> +/*
> + * Authorized rates are:
> + * Rate = MCLK_RATE / (n * 2)
> + * Where n is in [1..4095]
> + * (cf register SSC_CMR)
> + */
> +static unsigned int rates[] = {
> + 8000,
> + 16000,
> + 32000,
> + 48000,
> +
On Tue, Jul 09, 2013 at 04:25:26PM +0200, Richard Genoud wrote:
> [I've just seen that I forgot to cc Uwe to the cover letter, sorry for that.]
This is the second or third copy of this patch set I've been sent
*today*. Worse, everything seems to be being sent in reply to the same
thread increasin
On Tue, Jul 09, 2013 at 10:27:53AM +0200, Richard Genoud wrote:
> The dma binding is documented here
> Documentation/devicetree/bindings/dma/atmel-dma.txt
> But you're right, I shoud update
> Documentation/devicetree/bindings/misc/atmel-ssc.txt.
No, you need to write a binding for this machine dr
On Tue, Jul 09, 2013 at 10:19:45AM +0200, Richard Genoud wrote:
> 2013/7/8 Mark Brown :
> > The obvious question here is of course if we can use the same driver for
> > both of them.
> I haven't got a g20 to test that, but that's the goal.
I think I do somewhere.
&g
On Tue, Jul 09, 2013 at 07:26:27AM +0200, Michal Simek wrote:
> On 07/08/2013 04:51 PM, Mark Brown wrote:
> > Applied, thanks.
> have you applied this patch?
Yes, network is spotty here so pushes aren't working so well.
signature.asc
Description:
On Mon, Jul 08, 2013 at 03:29:50PM +0200, Richard Genoud wrote:
> Signed-off-by: Richard Genoud
> ---
> arch/arm/boot/dts/at91sam9x5.dtsi |3 +++
There was no binding document in your first patch - there should be one
for any new DT bindings.
signature.asc
Description: Digital signature
___
On Mon, Jul 08, 2013 at 03:29:17PM +0200, Michal Simek wrote:
> It simplifies driver probing.
Applied, thanks.
signature.asc
Description: Digital signature
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org
On Mon, Jul 08, 2013 at 03:29:51PM +0200, Richard Genoud wrote:
> The WM8731 codec on sam9x5ek board is on i2c, address 1A
>
> Signed-off-by: Richard Genoud
Acked-by: Mark Brown
This should go via arm-soc.
signature.asc
Description: Digital
On Sat, Jul 06, 2013 at 07:13:23PM +0200, Markus Pargmann wrote:
> On Wed, Jul 03, 2013 at 05:06:37PM +0100, Mark Brown wrote:
> > On Thu, Jun 20, 2013 at 03:20:23PM +0200, Markus Pargmann wrote:
> > > + ssi_private->use_dma = !of_property_read_bool(np, "fsl,imx-fiq"
On Sun, Jul 07, 2013 at 09:19:49AM +0200, Markus Pargmann wrote:
> On Wed, Jul 03, 2013 at 05:17:27PM +0100, Mark Brown wrote:
> > > +extern void pca100_ac97_cold_reset(struct snd_ac97 *ac97);
> > > +extern void pca100_ac97_warm_reset(struct snd_ac97 *ac97);
> >
From: Mark Brown
It is not used outside of this file so doesn't need to be in the global
namespace.
Signed-off-by: Mark Brown
---
drivers/of/platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index e0a6514..b0
On Fri, Jul 05, 2013 at 05:15:05PM +0200, Richard Genoud wrote:
> 2013/7/2 Bo Shen :
> >> From: Nicolas Ferre
> >>
> >> Description of the Asoc machine driver for an at91sam9x5 based board
> >> with a wm8731 audio DAC. Wm8731 is clocked by a crystal and used as a
> >> master on the SSC/I2S interf
On Fri, Jul 05, 2013 at 12:33:10PM -0500, Nishanth Menon wrote:
> Taking an example of twl-regulator and omap_pmic, are you suggesting
> omap_pmic to be a user twl-regulator using
> include/linux/regulator/consumer.h? or are you suggesting that
> omap_pmic should not be a regulator at all?
No, I'
On Fri, Jul 05, 2013 at 09:50:34AM -0500, Nishanth Menon wrote:
> On 07/05/2013 09:08 AM, Mark Brown wrote:
> >>option 1) we just bypass get_voltage/set_voltage to point through to
> >>this function. result will be something similar to what we got here[1]
> >I don&
On Fri, Jul 05, 2013 at 08:55:07AM -0500, Nishanth Menon wrote:
Please write in paragraphs, an enormous wall of unbroken text isn't
helpful for legibility.
> On 16:41-20130704, Mark Brown wrote:
> > So, this still has the thing where all the data about the PMIC is
> > re
On Thu, Jul 04, 2013 at 06:56:24PM +0200, Daniel Mack wrote:
> Unless I missed some recent discussion, this case is not easy to handle.
> Yes, I know that these kind of things should be handled by a
> next-generation bootloader, but in our case, we want to avoid a loader
> update of already shippe
On Fri, Jun 21, 2013 at 04:25:42PM -0500, Nishanth Menon wrote:
> +static const struct omap_pmic_info omap_twl4030_vdd1 = {
> + .slave_addr = 0x12,
> + .voltage_reg_addr = 0x00,
> + .cmd_reg_addr = 0x00,
> + .i2c_timeout_us = 200,
> + .slew_rate_uV = 4000,
> + .step_size_uV
On Tue, Jun 18, 2013 at 11:22:13AM +0100, Lorenzo Pieralisi wrote:
> On Mon, Jun 17, 2013 at 06:44:51PM +0100, Olof Johansson wrote:
> > That'll trim down the driver to a point where I think you'll find it much
> > easier to get merged. :-)
> To start with I have to understand in which directory
On Thu, Jun 20, 2013 at 03:20:29PM +0200, Markus Pargmann wrote:
> Update the fsl-ssi bindings. DMA is no required property anymore and
> uses the generic DMA bindings. imx-fiq is a new alternative to DMA
These updates should be done as part of the patches making the code
changes - see the review
On Thu, Jun 20, 2013 at 03:20:27PM +0200, Markus Pargmann wrote:
> Notes:
> Changes in v9:
> - Fix blank line at end of file.
>
Please don't include enormous changelogs like this, they're just noise.
> +config SND_SOC_PHYCORE_AC97_DT
> + bool "SoC Audio support for Phytec phyCO
On Thu, Jun 20, 2013 at 03:20:20PM +0200, Markus Pargmann wrote:
> This patch removes the NO_DT flag. The pdev pointer may have a proper
> of_node with the dmas property, so we can use it to request DMA
> channels.
Applied, thanks.
signature.asc
Description: Digital signature
___
On Thu, Jun 20, 2013 at 03:20:28PM +0200, Markus Pargmann wrote:
> fsl-ssi was located in powerpc/fsl/ssi.txt. This is no powerpc specific
> device, so it should be moved to sound/ as it connects to differen audio
> codecs.
Applied, thanks.
signature.asc
Description: Digital signature
__
On Thu, Jun 20, 2013 at 03:20:22PM +0200, Markus Pargmann wrote:
> fsl_ssi and imx-ssi can be both enabled at the same time. To be able to
> add AC97 support to fsl_ssi, soc_ac97_ops have to be available to both
> drivers.
This needs to be redone on top of the changes that went into v3.11 to
suppo
On Thu, Jun 20, 2013 at 03:20:23PM +0200, Markus Pargmann wrote:
> + ssi_private->use_dma = !of_property_read_bool(np, "fsl,imx-fiq");
> +
This binding should be documented. I'm not sure it really needs to be
a binding, though - is it not possible for the driver to just figure out
that DMA w
On Thu, Jun 20, 2013 at 03:20:21PM +0200, Markus Pargmann wrote:
> Cleaner parameter passing for imx-pcm-fiq. Create a seperated fiq-params
> struct to pass all arguments.
Applied, thanks.
signature.asc
Description: Digital signature
___
devicetree-dis
On Mon, Jun 24, 2013 at 03:06:57PM +0530, Sachin Kamat wrote:
> s5m8767 regulator is used on Exynos platforms which use pin controller
> to configure GPIOs. Update the example accordingly.
Applied, thanks. Please use subject lines that match the subsystem and
try to make your changelogs clearer.
On Tue, Jul 02, 2013 at 05:25:37PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Add missing .owner of struct snd_soc_card. This prevents the
> module from being removed from underneath its users.
Applied, thanks.
signature.asc
Description: Digital signature
___
On Tue, Jul 02, 2013 at 08:37:44AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
Applied, thanks.
signature.asc
Description: Digital signature
___
From: Mark Brown
It is not used outside of this file so doesn't need to be in the global
namespace.
Signed-off-by: Mark Brown
---
drivers/of/platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index e0a6514..b0
On Tue, Jun 25, 2013 at 11:56:12AM +0530, Sachin Kamat wrote:
> There is no change in the bindings, but just a correction in the
> documentation to reflect the
> implementation. Earlier when Samsung platforms did not have pinctrl
> driver, legacy GPIO driver
> was used which took those 5 parameter
On Wed, Jun 26, 2013 at 03:05:28PM +0200, Marek Belisko wrote:
> +#define PCM1681_ATT_CONTROL(X) (X <= 6 ? X : X + 9) /* Attenuation
> level */
Write a function for this.
> +static bool pcm1681_writeable_reg(struct device *dev, unsigned register reg)
> +{
> + return pcm1681_accessible
On Wed, Jun 26, 2013 at 03:16:56PM +0200, Daniel Mack wrote:
> Hi Marek,
>
> On 26.06.2013 15:05, Marek Belisko wrote:
> > PCM1681 can be controlled via I2C, SPI or in bootstrap mode. This code add
> > support only for I2C mode.
Guys, please delete unneeded context from replies so it's possible t
On Thu, Jun 20, 2013 at 03:05:38PM +0100, Srinivas KANDAGATLA wrote:
> This patch add pinctrl support to ST SoCs.
>
> About hardware:
> ST Set-Top-Box parts have two blocks called PIO and PIO-mux which handle
> pin configurations.
Applied, thanks.
signature.asc
Description: Digital signature
__
On Mon, Jun 24, 2013 at 03:06:57PM +0530, Sachin Kamat wrote:
> s5m8767 regulator is used on Exynos platforms which use pin controller
> to configure GPIOs. Update the example accordingly.
This smells bad, why does a driver using GPIOs through the GPIO API see
a change in the binding?
signature.
On Mon, Jun 24, 2013 at 05:31:59PM +0530, Sourav Poddar wrote:
> The binding definition is based on the generic DMA request binding
Applied, thanks.
signature.asc
Description: Digital signature
___
devicetree-discuss mailing list
devicetree-discuss@li
On Mon, Jun 24, 2013 at 01:57:56PM +0200, Linus Walleij wrote:
> This seems fairly complete, but I cannot have such a basic dependency onto
> the regmap tree this late in the merge window, i.e. I'm not ready to pull
> all of regmap into the pinctrl tree. I'd consider this for merging
> for the nex
On Fri, Jun 21, 2013 at 04:07:51PM +0530, Sekhar Nori wrote:
> We can resend the patch if you don't have it from the mailing list.
I'll probably have it assuming it's been sent to some mailing list I
read (the CC list here looks absurldy large...) but if you don't send me
the patch and/or ignore
On Thu, Jun 20, 2013 at 02:07:37PM +0530, Kishon Vijay Abraham I wrote:
> Added a property to indicate if the regulator supports bypass mode.
> Also modified of_get_regulation_constraints() to check for that
> property and set appropriate constraints.
Applied, thanks.
signature.asc
Description:
the chips are
essentially nonexistant now your current approach seems sensible so
Reviwed-by: Mark Brown
signature.asc
Description: Digital signature
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
On Wed, Jun 19, 2013 at 11:27:47AM +0530, Keerthy wrote:
> From: J Keerthy
>
> Check if irq value obtained is valid. If it is not valid
> then skip the irq request step and go ahead with the probe.
>
> Signed-off-by: J Keerthy
Reviewed-by: Mark Brown
signature.asc
De
On Wed, Jun 19, 2013 at 11:27:50AM +0530, Keerthy wrote:
> From: J Keerthy
>
> Add TPS659038 support.
>
> Signed-off-by: J Keerthy
This doesn't apply against my current tree as the PMIC bindings document
isn't in mainline yet.
Acked-by: Mark Brown
assuming there
On Tue, Jun 18, 2013 at 04:11:16PM +0100, Russell King - ARM Linux wrote:
> On Tue, Jun 18, 2013 at 05:02:49PM +0200, Linus Walleij wrote:
> > Nowadays I would do the above with regmap_update_bits().
> > Mutual exclusion for read-modify-write of individual bits in a
> > register is one of those ca
On Mon, Jun 17, 2013 at 04:31:06PM +0300, Illia Smyrnov wrote:
> The MCSPI controller has a built-in FIFO buffer to unload the DMA or interrupt
> handler and improve data throughput. This patch adds FIFO buffer support for
> SPI
> transfers in DMA mode.
Applied, thanks.
signature.asc
Descriptio
On Fri, Jun 14, 2013 at 07:12:08PM +0300, Illia Smyrnov wrote:
> The MCSPI controller has a built-in FIFO buffer to unload the DMA or interrupt
> handler and improve data throughput. This patch adds FIFO buffer support for
> SPI
> transfers in DMA mode.
This looks good but doesn't apply against m
On Fri, Jun 14, 2013 at 07:12:07PM +0300, Illia Smyrnov wrote:
> Introduce mcspi_bytes_per_word function as replacement for the next code
> fragment:
Applied, thanks.
signature.asc
Description: Digital signature
___
devicetree-discuss mailing list
devi
On Thu, Jun 13, 2013 at 09:29:38AM -0700, Tony Lindgren wrote:
> * Linus Walleij [130613 08:35]:
> > No. If we go down that road *anything* that is connected to a
> > pad becomes part of the pinctrl subsystem, then pinctrl-single
> > becomes some kind of hardware abstraction or BIOS, and that
> >
On Thu, Jun 13, 2013 at 09:58:03AM -0500, Nishanth Menon wrote:
> I am proposing moving the following into OF match data.
> ti,i2c-slave-address
> ti,i2c-voltage-register
> ti,i2c-command-register
> ti,slew-rate-microvolt
> ti,step-size-micro-volts
> ti,voltage-selector-set-bits
> ti,voltage-selec
On Thu, Jun 13, 2013 at 08:39:50AM -0500, Nishanth Menon wrote:
> I am having a bit of a difficulty trying to understand your concern
> here.
Your device tree for this stuff appears to mostly consist of repeating
the description of the PMIC that we already have - this really doesn't
seem like a g
On Wed, Jun 12, 2013 at 11:35:34AM -0600, Stephen Warren wrote:
> + RT5640 pins:
> +
> + * DMIC1
> + * DMIC2
> + * MICBIAS1
> + * IN1P
> + * IN1R
> + * IN2P
> + * IN2R
> + * HPOL
> + * HPOR
> + * LOUTL
> + * LOUTR
> + * MONOP
> + * MONON
> + * SPOLP
> + * SPOLN
> + * SPORP
> + *
On Wed, Jun 12, 2013 at 11:34:30AM -0600, Stephen Warren wrote:
> From: Stephen Warren
>
> Modify the RT5640 driver to parse platform data from device tree. Write
> a DT binding document to describe those properties.
Applied, thanks.
signature.asc
Description: Digital signature
___
On Wed, Jun 12, 2013 at 10:56:46AM -0600, Stephen Warren wrote:
> On 06/12/2013 10:46 AM, Mark Brown wrote:
> > Unfortunately gpio_is_valid() is unhelpful for platform data since
> > often zero is a valid GPIO but it's also the default "do nothing"
> > plat
On Tue, Jun 11, 2013 at 02:40:40PM -0600, Stephen Warren wrote:
> +- realtek,ldo1-en-gpios : The GPIO that controls the CODEC's LDO1_EN pin.
Why gpios and not gpio?
> - if (rt5640->pdata.ldo1_en) {
> + if (gpio_is_valid(rt5640->pdata.ldo1_en)) {
> ret = devm_gpio_request_on
On Tue, Jun 11, 2013 at 08:09:15PM +0300, Illia Smyrnov wrote:
> The MCSPI controller has a built-in FIFO buffer to unload the DMA or interrupt
> handler and improve data throughput. This patch adds FIFO buffer support for
> SPI
> transfers in DMA mode.
> The FIFO could be enabled for SPI module
On Mon, Jun 10, 2013 at 10:21:58AM +0100, Srinivas KANDAGATLA wrote:
> It is common to access regmap registers at bit level, using
> regmap_update_bits or regmap_read functions, however the end user has to
> take care of a mask or shifting. This becomes overhead when such use
> cases are high. Havi
On Tue, Jun 11, 2013 at 02:43:30AM +0800, Nicolin Chen wrote:
> This is the initial imx-wm8962 device-tree-only machine driver working with
> fsl_ssi driver. More features can be added on top of it later.
Applied, thanks.
signature.asc
Description: Digital signature
_
On Mon, Jun 10, 2013 at 12:51:42PM -0500, Nishanth Menon wrote:
> a) Tegra seems to use Lookup Table for sending predefinied voltage
> values to PMIC. OMAP has no concept of lookup table.
They seem to be doing basically the same thing here, you've got a linear
map of selector to voltage too AFAIC
On Fri, Jun 07, 2013 at 08:26:14PM +0800, Nicolin Chen wrote:
> +
> +struct imx_priv {
> + int hp_gpio;
> + int hp_active_low;
> + int hp_status;
> + int amic_gpio;
> + int amic_active_low;
> + int amic_status;
These are just recorded in the struct but never actually seem
On Mon, Jun 10, 2013 at 11:16:59AM -0500, Nishanth Menon wrote:
> On Mon, Jun 10, 2013 at 5:31 AM, Mark Brown wrote:
> > On Wed, May 22, 2013 at 01:18:34PM -0500, Nishanth Menon wrote:
> > So, the biggest problem here has been patch 4 (having to have a hack to
> > deplo
On Wed, May 22, 2013 at 01:18:34PM -0500, Nishanth Menon wrote:
So, the biggest problem here has been patch 4 (having to have a hack to
deploy this stuff is a bit worrying) plus the general not having a real
driver thing.
> +- ti,i2c-slave-address - I2C slave address of the PMIC
> +- ti,i2c-volta
On Sun, Jun 09, 2013 at 04:07:28PM +0300, Dan Carpenter wrote:
> '!' has higher precedence than comparisons so the original condition
> is equivalent to "if (xspi->remaining_bytes == 0)". This makes the
> static checkers complain.
Applied, thanks.
signature.asc
Description: Digital signature
__
On Fri, Jun 07, 2013 at 06:14:13PM +0800, Nicolin Chen wrote:
> +Optional properties:
> +- hp-det-gpios : The gpio pin to detect plug in/out event that happens to
> + Headphone jack.
> +
> +- mic-det-gpios: The gpio pin to detect plug in/out event that happens to
> + Micphone jack.
So this is f
On Fri, Jun 07, 2013 at 12:19:58PM +0200, Tomasz Figa wrote:
> On Thursday 06 of June 2013 21:46:45 Doug Anderson wrote:
> > dw_mmc is probed. This regulator is optional, though a warning will
> > be printed if it's missing. The fact that the regulator is optional
> > means that (at the moment)
On Fri, Jun 07, 2013 at 01:59:47PM +0800, Nicolin Chen wrote:
> +Optional properties:
> +- hp-det-gpios : The gpio port of Headphone jack detection.
> +- mic-det-gpios: The gpio port of Micphone jack detection.
These still need better documentation to say what they are electrically.
Like I say
On Fri, Jun 07, 2013 at 11:23:27AM +0800, Nicolin Chen wrote:
> Document the device tree binding for the WM8962 codec, and modify the
> driver to extract platform data from the device tree, if present.
Applied, thanks.
signature.asc
Description: Digital signature
On Thu, Jun 06, 2013 at 11:02:43AM -0300, Fabio Estevam wrote:
> You could try something like (pass the real clock in the device tree):
> http://permalink.gmane.org/gmane.linux.alsa.devel/107614
> (I will re-post this patch later)
That's exactly what I'm suggesting.
signature.asc
Description:
On Thu, Jun 06, 2013 at 08:49:53PM +0800, Nicolin Chen wrote:
> On Wed, Jun 05, 2013 at 12:55:44PM +0100, Mark Brown wrote:
> > Since it's easy to define a fixed rate clock (there's a generic driver
> > for that) I'd just require the user to provide a clock API cl
On Thu, Jun 06, 2013 at 07:38:46PM +0800, Nicolin Chen wrote:
> +Optional properties:
> + - spk-mono: Default register value for SPK_MONO of R51 (Class D Control 2).
This doesn't correspond to the code. This is a boolean property, if
it's present then that bit gets set indicating that the speak
On Thu, Jun 06, 2013 at 07:38:45PM +0800, Nicolin Chen wrote:
> Embed a copy of struct wm8962_pdata in stuct wm8962_priv
> so that there's no need to check validity of pdata any more.
Applied, thanks.
signature.asc
Description: Digital signature
___
de
On Thu, Jun 06, 2013 at 01:08:56PM +0300, Illia Smyrnov wrote:
> On 06/05/2013 03:03 PM, Mark Brown wrote:
> >Why is this defined for slaves? Surely the size of the FIFO in the
> >controller is a property of the controller not the slave?
> According to OMAP TRM [1] the FIFO
On Thu, Jun 06, 2013 at 01:08:46PM +0300, Illia Smyrnov wrote:
> On 06/05/2013 02:57 PM, Mark Brown wrote:
> Turbo mode gives the expected results not for all cases. There are
> some limitations:
> - works only if a single channel is enabled (no effect when several
> chan
On Thu, Jun 06, 2013 at 02:01:14AM +0200, Tomasz Figa wrote:
> I don't see any other solution here than moving all the Allwinner code to
> DT (as it has been suggested in this thread several times already), as
> this is the only hardware description method supported by ARM Linux.
Well, the serv
On Thu, Jun 06, 2013 at 12:39:20PM +0800, Nicolin Chen wrote:
> On Wed, Jun 05, 2013 at 12:55:44PM +0100, Mark Brown wrote:
> > > +- hp-det-gpios : The gpio port of Headphone detection.
> > > +- mic-det-gpios: The gpio port of Micphone detection.
> > I'd say a
1 - 100 of 927 matches
Mail list logo
