Re: [alsa-devel] [PATCH 1/5 v7][RFC] ASoC: add snd_soc_register_cpu()

2013-03-04 Thread Mark Brown
On Mon, Mar 04, 2013 at 07:48:36PM +, Liam Girdwood wrote: > I think we probably have more in common between platforms and codecs now > than we have that is different (certainly, things were very different in > the past). But you are right, is it really worth the big churn. Definitely, I

Re: [PATCH 06/10] ARM: soc-audio phycore-ac97: fix driver init order

2013-03-11 Thread Mark Brown
On Sun, Mar 10, 2013 at 07:33:07PM +0100, Markus Pargmann wrote: > Adding a soc-audio sound driver internally uses snd_soc_register_device, > which tries to bind it with the codec. The adding of the driver is > deferred because the codec driver is not loaded. > This patch changes the order of regi

Re: [PATCH -next] ASoC: tas5086: use module_i2c_driver to simplify the code

2013-03-12 Thread Mark Brown
On Tue, Mar 12, 2013 at 09:36:24PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Use the module_i2c_driver() macro to make the code smaller > and a bit simpler. Applied, thanks. signature.asc Description: Digital signature ___ devicetree-discuss

Re: [PATCH] ASoC: core: fix possible memory leak in snd_soc_bytes_put()

2013-03-12 Thread Mark Brown
On Tue, Mar 12, 2013 at 12:35:14AM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > 'data' is malloced in snd_soc_bytes_put() and should be freed > before leaving from the error handling cases, otherwise it will cause > memory leak. Applied, thanks. signature.asc Description: Digital signatur

Re: [PATCH 01/10] imx-ssi: Fix AC97 rates

2013-03-12 Thread Mark Brown
On Sun, Mar 10, 2013 at 07:33:02PM +0100, Markus Pargmann wrote: > From: Sascha Hauer > > This device supports multiple rates as described in later AC97 > standards. This patch allows playback of different sample frequencies > without conversion. Applied, but some notes about why this is already

Re: [PATCH 02/10] imx-ssi: Fix occasional AC97 reset failure

2013-03-12 Thread Mark Brown
On Sun, Mar 10, 2013 at 07:33:03PM +0100, Markus Pargmann wrote: > From: Sascha Hauer > > Signed-off-by: Sascha Hauer > Signed-off-by: Markus Pargmann Applied but *always* use subject lines appropriate to the subsystem and bugfixes like this should be pulled to the front of the series as they

Re: [PATCH 03/10] mx-ssi: flush fifos

2013-03-12 Thread Mark Brown
On Sun, Mar 10, 2013 at 07:33:04PM +0100, Markus Pargmann wrote: > From: Sascha Hauer > > Signed-off-by: Sascha Hauer > Signed-off-by: Markus Pargmann Why? Is this a bug fix? I'm guessing it is but... signature.asc Description: Digital signature

Re: [PATCH 04/10] ASoC: Kconfig: imx-ssi needs imx-fiq and imx-dma

2013-03-12 Thread Mark Brown
On Sun, Mar 10, 2013 at 07:33:05PM +0100, Markus Pargmann wrote: > config SND_SOC_IMX_SSI > + select SND_SOC_IMX_PCM_DMA > + select SND_SOC_IMX_PCM_FIQ > tristate Really? I'd expect this to be an or, if we've got DMA I can't see any reason why we'd want to use the FIQ. signature

Re: [PATCH 05/10] ASoC: pcm030 audio fabric: remove __init from probe

2013-03-12 Thread Mark Brown
On Sun, Mar 10, 2013 at 07:33:06PM +0100, Markus Pargmann wrote: > Remove probe function from the init section. > > Signed-off-by: Markus Pargmann Applied, thanks. signature.asc Description: Digital signature ___ devicetree-discuss mailing list devic

Re: [PATCH 07/10] ASoC: phycore-ac97: Add DT support

2013-03-12 Thread Mark Brown
On Sun, Mar 10, 2013 at 07:33:08PM +0100, Markus Pargmann wrote: > Add devicetree support for this audio soc fabric driver. > > Signed-off-by: Markus Pargmann > --- > sound/soc/fsl/phycore-ac97.c | 148 > --- > 1 file changed, 125 insertions(+), 23 deleti

Re: [PATCH 08/10] ASoC: dmaengine_pcm: Add open function for DT DMA request

2013-03-12 Thread Mark Brown
On Sun, Mar 10, 2013 at 07:33:09PM +0100, Markus Pargmann wrote: > Add a function to open a DMA PCM substream using devicetree data > provided via the client device node. The patch introduces a public > function and a private subfunction that is called by both open > functions. Someone (I think it

Re: [PATCH v2 1/2] leds: Add support for Palmas LEDs

2013-03-12 Thread Mark Brown
On Tue, Mar 12, 2013 at 11:57:50AM -0700, Bryan Wu wrote: > On Thu, Feb 28, 2013 at 7:21 AM, Ian Lartey wrote: > > + spinlock_t value_lock; > I think you don't need this spinlock to protect the value, the mutex is > enough. You need to use a spinlock because values can be set from hard I

Re: [PATCH 08/10] ASoC: dmaengine_pcm: Add open function for DT DMA request

2013-03-13 Thread Mark Brown
On Wed, Mar 13, 2013 at 10:18:29AM +0800, Shawn Guo wrote: > I did not see any objection from you on that patch, so I'm waiting for > you to publish a branch for it, so that my mxs-dma generic binding > series can move forward. I commented on the removal of the const from the name parameter (and

Re: [patch] ALSA: ASoC: tas5086: signedness bug in tas5086_hw_params()

2013-03-13 Thread Mark Brown
On Wed, Mar 13, 2013 at 08:32:53AM +0300, Dan Carpenter wrote: > "val" has to be signed for the error handling to work. Applied, thanks. signature.asc Description: Digital signature ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.or

Re: [PATCH 08/10] ASoC: dmaengine_pcm: Add open function for DT DMA request

2013-03-14 Thread Mark Brown
On Thu, Mar 14, 2013 at 02:04:45PM +0800, Shawn Guo wrote: > I just double checked my mailbox and can only see the conversation > between you and rmk, nothing particularly on the removal of the const > from the name parameter. Or I'm still missing something? You're missing the bit where I compla

Re: [PATCH v3 2/3] regulator: as3711: add OF support

2013-03-22 Thread Mark Brown
On Fri, Mar 22, 2013 at 05:15:48PM +0100, Guennadi Liakhovetski wrote: > AS3711 regulator OF support only evaluates standard regulator DT > properties. It looks like this has no dependencies on the MFD patch, is that correct? signature.asc Description: Digital signature _

Re: [PATCH v10 0/12] Palmas updates

2013-03-24 Thread Mark Brown
On Sat, Mar 23, 2013 at 06:04:55AM +1100, Stephen Rothwell wrote: > On Fri, 22 Mar 2013 14:55:10 + Ian Lartey wrote: > > Patches based on linux-next-20130319 > I can't really comment on the patch set except to say that you should not > base on linux-next, you should base on the tree to which

Re: [PATCH v10 12/12] regulator: palmas remove palmas-charger option from DT bindings

2013-03-24 Thread Mark Brown
On Fri, Mar 22, 2013 at 02:55:22PM +, Ian Lartey wrote: > Signed-off-by: Ian Lartey Applied, thanks. signature.asc Description: Digital signature ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/list

Re: [PATCH v3 2/3] regulator: as3711: add OF support

2013-03-24 Thread Mark Brown
On Fri, Mar 22, 2013 at 05:15:48PM +0100, Guennadi Liakhovetski wrote: > AS3711 regulator OF support only evaluates standard regulator DT > properties. Applied, thanks. signature.asc Description: Digital signature ___ devicetree-discuss mailing list de

Re: [PATCH v9 11/11] regulator: palmas remove palmas-charger option from DT bindings

2013-03-24 Thread Mark Brown
On Fri, Mar 22, 2013 at 01:36:13PM +, Ian Lartey wrote: > Signed-off-by: Ian Lartey Applied, thanks. signature.asc Description: Digital signature ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/list

Re: [PATCH v3 3/3] backlight: as3711: add OF support

2013-03-25 Thread Mark Brown
On Mon, Mar 25, 2013 at 02:12:21PM +0900, Jingoo Han wrote: > On Saturday, March 23, 2013 1:16 AM, Guennadi Liakhovetski wrote: > But, there is a typo in comment. > > +* At least one su2-auto-curr* must be specified iff > s/iff/if Are you sure that's a typo? "Iff" is a bit of mathema

Re: [PATCH 1/2] ASoC: tegra: add Tegra114 support to the AHUB driver

2013-03-25 Thread Mark Brown
On Thu, Mar 21, 2013 at 01:56:41PM -0600, Stephen Warren wrote: > From: Stephen Warren > > Tegra114's AHUB shares a design with Tegra30, with the followin changes: > * Supports more (10 vs. 4) bi-directional FIFO channels into RAM. Applied but... > + clocks = <&tegra_car 106>, <&tegra_car 1

Re: [PATCH 1/2] ASoC: tegra: add Tegra114 support to the AHUB driver

2013-03-25 Thread Mark Brown
On Mon, Mar 25, 2013 at 10:19:05AM -0600, Stephen Warren wrote: > On 03/25/2013 09:52 AM, Mark Brown wrote: > > On Thu, Mar 21, 2013 at 01:56:41PM -0600, Stephen Warren wrote: > >> + clocks = <&tegra_car 106>, <&tegra_car 107>, <&tegra_ca

Re: [PATCH v10 01/12] mfd: DT bindings for the palmas family MFD

2013-03-25 Thread Mark Brown
On Mon, Mar 25, 2013 at 11:59:11AM -0600, Stephen Warren wrote: > On 03/22/2013 08:55 AM, Ian Lartey wrote: > > From: Graeme Gregory > > +Optional nodes: > > +- regulators : should contain the constrains and init information for the > > + regulators. It should contain a subnode per regul

Re: [PATCH v3 12/12] clocksource: samsung-time: Add Device Tree support

2013-03-28 Thread Mark Brown
On Sat, Mar 09, 2013 at 09:23:21PM +0100, Tomasz Figa wrote: > +CLOCKSOURCE_OF_DECLARE(s3c24xx_timer, > + "samsung,s3c24xx-pwm", samsung_of_timer_init) > +CLOCKSOURCE_OF_DECLARE(s3c64xx_timer, > + "samsung,s3c64xx-pwm", samsung_of_timer_init)

Re: [PATCH -next] spi: remove unused variable in tegra_slink_read_rx_fifo_to_client_rxbuf()

2013-04-01 Thread Mark Brown
On Wed, Mar 13, 2013 at 09:29:12PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > The variable bits_per_word is initialized but never used > otherwise, so remove the unused variable. Applied, thanks. signature.asc Description: Digital signature __

[PATCH] mfd: Add device tree bindings for Arizona class devices

2013-04-02 Thread Mark Brown
Signed-off-by: Mark Brown --- Documentation/devicetree/bindings/mfd/arizona.txt | 62 + drivers/mfd/arizona-core.c| 53 ++ drivers/mfd/arizona-i2c.c | 10 +++- drivers/mfd/arizona-spi.c

Re: [PATCH] mfd: Add device tree bindings for Arizona class devices

2013-04-02 Thread Mark Brown
On Tue, Apr 02, 2013 at 09:51:18PM +0100, Mark Brown wrote: > Signed-off-by: Mark Brown *sigh* ignore this one, revised version coming shortly. signature.asc Description: Digital signature ___ devicetree-discuss mailing list devicetree-disc

[PATCH] mfd: Add device tree bindings for Arizona class devices

2013-04-02 Thread Mark Brown
Signed-off-by: Mark Brown --- Documentation/devicetree/bindings/mfd/arizona.txt | 62 drivers/mfd/arizona-core.c| 64 + drivers/mfd/arizona-i2c.c | 10 +++- drivers/mfd/arizona-spi.c

Re: [PATCH -next] mxs/spi: fix error return code in mxs_spi_probe()

2013-04-03 Thread Mark Brown
On Wed, Apr 03, 2013 at 09:06:40PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return a negative error code from the error handling > case instead of 0, as returned elsewhere in this function. Applied, thanks. signature.asc Description: Digital signature __

Re: [RFC PATCH 1/4] regulator: Introduce OMAP regulator to control PMIC over VC/VP

2013-06-10 Thread Mark Brown
On Wed, May 22, 2013 at 01:18:34PM -0500, Nishanth Menon wrote: So, the biggest problem here has been patch 4 (having to have a hack to deploy this stuff is a bit worrying) plus the general not having a real driver thing. > +- ti,i2c-slave-address - I2C slave address of the PMIC > +- ti,i2c-volta

Re: [RFC PATCH 1/4] regulator: Introduce OMAP regulator to control PMIC over VC/VP

2013-06-10 Thread Mark Brown
On Mon, Jun 10, 2013 at 11:16:59AM -0500, Nishanth Menon wrote: > On Mon, Jun 10, 2013 at 5:31 AM, Mark Brown wrote: > > On Wed, May 22, 2013 at 01:18:34PM -0500, Nishanth Menon wrote: > > So, the biggest problem here has been patch 4 (having to have a hack to > > deplo

Re: [PATCH V5] ASoC: fsl: add imx-wm8962 machine driver

2013-06-10 Thread Mark Brown
On Fri, Jun 07, 2013 at 08:26:14PM +0800, Nicolin Chen wrote: > + > +struct imx_priv { > + int hp_gpio; > + int hp_active_low; > + int hp_status; > + int amic_gpio; > + int amic_active_low; > + int amic_status; These are just recorded in the struct but never actually seem

Re: [RFC PATCH 1/4] regulator: Introduce OMAP regulator to control PMIC over VC/VP

2013-06-10 Thread Mark Brown
On Mon, Jun 10, 2013 at 12:51:42PM -0500, Nishanth Menon wrote: > a) Tegra seems to use Lookup Table for sending predefinied voltage > values to PMIC. OMAP has no concept of lookup table. They seem to be doing basically the same thing here, you've got a linear map of selector to voltage too AFAIC

Re: [PATCH V6] ASoC: fsl: add imx-wm8962 machine driver

2013-06-11 Thread Mark Brown
On Tue, Jun 11, 2013 at 02:43:30AM +0800, Nicolin Chen wrote: > This is the initial imx-wm8962 device-tree-only machine driver working with > fsl_ssi driver. More features can be added on top of it later. Applied, thanks. signature.asc Description: Digital signature _

Re: [PATCH v2 03/11] regmap: Add regmap_field APIs

2013-06-11 Thread Mark Brown
On Mon, Jun 10, 2013 at 10:21:58AM +0100, Srinivas KANDAGATLA wrote: > It is common to access regmap registers at bit level, using > regmap_update_bits or regmap_read functions, however the end user has to > take care of a mask or shifting. This becomes overhead when such use > cases are high. Havi

Re: [PATCH v2 2/2] spi: omap2-mcspi: Add FIFO buffer support

2013-06-12 Thread Mark Brown
On Tue, Jun 11, 2013 at 08:09:15PM +0300, Illia Smyrnov wrote: > The MCSPI controller has a built-in FIFO buffer to unload the DMA or interrupt > handler and improve data throughput. This patch adds FIFO buffer support for > SPI > transfers in DMA mode. > The FIFO could be enabled for SPI module

Re: [PATCH] ASoC: rt5640: add device tree support

2013-06-12 Thread Mark Brown
On Tue, Jun 11, 2013 at 02:40:40PM -0600, Stephen Warren wrote: > +- realtek,ldo1-en-gpios : The GPIO that controls the CODEC's LDO1_EN pin. Why gpios and not gpio? > - if (rt5640->pdata.ldo1_en) { > + if (gpio_is_valid(rt5640->pdata.ldo1_en)) { > ret = devm_gpio_request_on

Re: [PATCH] ASoC: rt5640: add device tree support

2013-06-12 Thread Mark Brown
On Wed, Jun 12, 2013 at 10:56:46AM -0600, Stephen Warren wrote: > On 06/12/2013 10:46 AM, Mark Brown wrote: > > Unfortunately gpio_is_valid() is unhelpful for platform data since > > often zero is a valid GPIO but it's also the default "do nothing" > > plat

Re: [PATCH V2] ASoC: rt5640: add device tree support

2013-06-12 Thread Mark Brown
On Wed, Jun 12, 2013 at 11:34:30AM -0600, Stephen Warren wrote: > From: Stephen Warren > > Modify the RT5640 driver to parse platform data from device tree. Write > a DT binding document to describe those properties. Applied, thanks. signature.asc Description: Digital signature ___

Re: [PATCH] ASoC: tegra: add tegra+RT5640 machine driver

2013-06-12 Thread Mark Brown
On Wed, Jun 12, 2013 at 11:35:34AM -0600, Stephen Warren wrote: > + RT5640 pins: > + > + * DMIC1 > + * DMIC2 > + * MICBIAS1 > + * IN1P > + * IN1R > + * IN2P > + * IN2R > + * HPOL > + * HPOR > + * LOUTL > + * LOUTR > + * MONOP > + * MONON > + * SPOLP > + * SPOLN > + * SPORP > + *

Re: [RFC PATCH 1/4] regulator: Introduce OMAP regulator to control PMIC over VC/VP

2013-06-13 Thread Mark Brown
On Thu, Jun 13, 2013 at 08:39:50AM -0500, Nishanth Menon wrote: > I am having a bit of a difficulty trying to understand your concern > here. Your device tree for this stuff appears to mostly consist of repeating the description of the PMIC that we already have - this really doesn't seem like a g

Re: [RFC PATCH 1/4] regulator: Introduce OMAP regulator to control PMIC over VC/VP

2013-06-13 Thread Mark Brown
On Thu, Jun 13, 2013 at 09:58:03AM -0500, Nishanth Menon wrote: > I am proposing moving the following into OF match data. > ti,i2c-slave-address > ti,i2c-voltage-register > ti,i2c-command-register > ti,slew-rate-microvolt > ti,step-size-micro-volts > ti,voltage-selector-set-bits > ti,voltage-selec

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Mark Brown
On Thu, Jun 13, 2013 at 09:29:38AM -0700, Tony Lindgren wrote: > * Linus Walleij [130613 08:35]: > > No. If we go down that road *anything* that is connected to a > > pad becomes part of the pinctrl subsystem, then pinctrl-single > > becomes some kind of hardware abstraction or BIOS, and that > >

Re: [PATCH v3 1/2] spi: omap2-mcspi: Move bytes per word calculation to the function

2013-06-17 Thread Mark Brown
On Fri, Jun 14, 2013 at 07:12:07PM +0300, Illia Smyrnov wrote: > Introduce mcspi_bytes_per_word function as replacement for the next code > fragment: Applied, thanks. signature.asc Description: Digital signature ___ devicetree-discuss mailing list devi

Re: [PATCH v3 2/2] spi: omap2-mcspi: Add FIFO buffer support

2013-06-17 Thread Mark Brown
On Fri, Jun 14, 2013 at 07:12:08PM +0300, Illia Smyrnov wrote: > The MCSPI controller has a built-in FIFO buffer to unload the DMA or interrupt > handler and improve data throughput. This patch adds FIFO buffer support for > SPI > transfers in DMA mode. This looks good but doesn't apply against m

Re: [PATCH v4] spi: omap2-mcspi: Add FIFO buffer support

2013-06-17 Thread Mark Brown
On Mon, Jun 17, 2013 at 04:31:06PM +0300, Illia Smyrnov wrote: > The MCSPI controller has a built-in FIFO buffer to unload the DMA or interrupt > handler and improve data throughput. This patch adds FIFO buffer support for > SPI > transfers in DMA mode. Applied, thanks. signature.asc Descriptio

Re: [PATCH v4 02/10] pinctrl: mvebu: dove pinctrl driver

2013-06-18 Thread Mark Brown
On Tue, Jun 18, 2013 at 04:11:16PM +0100, Russell King - ARM Linux wrote: > On Tue, Jun 18, 2013 at 05:02:49PM +0200, Linus Walleij wrote: > > Nowadays I would do the above with regmap_update_bits(). > > Mutual exclusion for read-modify-write of individual bits in a > > register is one of those ca

Re: [PATCH v3 4/4] regulator: Palmas: Add TPS659038 support

2013-06-19 Thread Mark Brown
On Wed, Jun 19, 2013 at 11:27:50AM +0530, Keerthy wrote: > From: J Keerthy > > Add TPS659038 support. > > Signed-off-by: J Keerthy This doesn't apply against my current tree as the PMIC bindings document isn't in mainline yet. Acked-by: Mark Brown assuming there

Re: [PATCH v3 1/4] MFD: Palmas: Check if irq is valid

2013-06-19 Thread Mark Brown
On Wed, Jun 19, 2013 at 11:27:47AM +0530, Keerthy wrote: > From: J Keerthy > > Check if irq value obtained is valid. If it is not valid > then skip the irq request step and go ahead with the probe. > > Signed-off-by: J Keerthy Reviewed-by: Mark Brown signature.asc De

Re: [PATCH] MFD: Change TWL6025 references to TWL6032

2013-06-19 Thread Mark Brown
the chips are essentially nonexistant now your current approach seems sensible so Reviwed-by: Mark Brown signature.asc Description: Digital signature ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 1/2] regulator: of: Added a property to indicate bypass mode support

2013-06-20 Thread Mark Brown
On Thu, Jun 20, 2013 at 02:07:37PM +0530, Kishon Vijay Abraham I wrote: > Added a property to indicate if the regulator supports bypass mode. > Also modified of_get_regulation_constraints() to check for that > property and set appropriate constraints. Applied, thanks. signature.asc Description:

Re: [PATCH v12 09/11] spi: omap2-mcspi: convert to dma_request_slave_channel_compat()

2013-06-21 Thread Mark Brown
On Fri, Jun 21, 2013 at 04:07:51PM +0530, Sekhar Nori wrote: > We can resend the patch if you don't have it from the mailing list. I'll probably have it assuming it's been sent to some mailing list I read (the CC list here looks absurldy large...) but if you don't send me the patch and/or ignore

Re: [PATCH v3 03/10] pinctrl:st: Add pinctrl and pinconf support.

2013-06-24 Thread Mark Brown
On Mon, Jun 24, 2013 at 01:57:56PM +0200, Linus Walleij wrote: > This seems fairly complete, but I cannot have such a basic dependency onto > the regmap tree this late in the merge window, i.e. I'm not ready to pull > all of regmap into the pinctrl tree. I'd consider this for merging > for the nex

Re: [PATCHv12] spi: omap2-mcspi: add generic DMA request support to the DT binding

2013-06-24 Thread Mark Brown
On Mon, Jun 24, 2013 at 05:31:59PM +0530, Sourav Poddar wrote: > The binding definition is based on the generic DMA request binding Applied, thanks. signature.asc Description: Digital signature ___ devicetree-discuss mailing list devicetree-discuss@li

Re: [PATCH 1/1] of/documentation: Update s5m8767-regulator bindings document

2013-06-24 Thread Mark Brown
On Mon, Jun 24, 2013 at 03:06:57PM +0530, Sachin Kamat wrote: > s5m8767 regulator is used on Exynos platforms which use pin controller > to configure GPIOs. Update the example accordingly. This smells bad, why does a driver using GPIOs through the GPIO API see a change in the binding? signature.

Re: [PATCH v3 03/10] pinctrl:st: Add pinctrl and pinconf support.

2013-06-25 Thread Mark Brown
On Thu, Jun 20, 2013 at 03:05:38PM +0100, Srinivas KANDAGATLA wrote: > This patch add pinctrl support to ST SoCs. > > About hardware: > ST Set-Top-Box parts have two blocks called PIO and PIO-mux which handle > pin configurations. Applied, thanks. signature.asc Description: Digital signature __

Re: [PATCH] ASoC: Add PCM1681 codec driver.

2013-06-26 Thread Mark Brown
On Wed, Jun 26, 2013 at 03:16:56PM +0200, Daniel Mack wrote: > Hi Marek, > > On 26.06.2013 15:05, Marek Belisko wrote: > > PCM1681 can be controlled via I2C, SPI or in bootstrap mode. This code add > > support only for I2C mode. Guys, please delete unneeded context from replies so it's possible t

Re: [PATCH] ASoC: Add PCM1681 codec driver.

2013-06-26 Thread Mark Brown
On Wed, Jun 26, 2013 at 03:05:28PM +0200, Marek Belisko wrote: > +#define PCM1681_ATT_CONTROL(X) (X <= 6 ? X : X + 9) /* Attenuation > level */ Write a function for this. > +static bool pcm1681_writeable_reg(struct device *dev, unsigned register reg) > +{ > + return pcm1681_accessible

Re: [PATCH 1/1] of/documentation: Update s5m8767-regulator bindings document

2013-06-28 Thread Mark Brown
On Tue, Jun 25, 2013 at 11:56:12AM +0530, Sachin Kamat wrote: > There is no change in the bindings, but just a correction in the > documentation to reflect the > implementation. Earlier when Samsung platforms did not have pinctrl > driver, legacy GPIO driver > was used which took those 5 parameter

[PATCH] of/platform: Staticize of_platform_device_create_pdata()

2013-07-01 Thread Mark Brown
From: Mark Brown It is not used outside of this file so doesn't need to be in the global namespace. Signed-off-by: Mark Brown --- drivers/of/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index e0a6514..b0

Re: [PATCH -next] spi: tegra114: remove redundant dev_err call in tegra_spi_probe()

2013-07-02 Thread Mark Brown
On Tue, Jul 02, 2013 at 08:37:44AM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. Applied, thanks. signature.asc Description: Digital signature ___

Re: [PATCH] ASoC: mop500: add .owner to struct snd_soc_card

2013-07-02 Thread Mark Brown
On Tue, Jul 02, 2013 at 05:25:37PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Add missing .owner of struct snd_soc_card. This prevents the > module from being removed from underneath its users. Applied, thanks. signature.asc Description: Digital signature ___

Re: [PATCH 1/1] of/documentation: Update s5m8767-regulator bindings document

2013-07-03 Thread Mark Brown
On Mon, Jun 24, 2013 at 03:06:57PM +0530, Sachin Kamat wrote: > s5m8767 regulator is used on Exynos platforms which use pin controller > to configure GPIOs. Update the example accordingly. Applied, thanks. Please use subject lines that match the subsystem and try to make your changelogs clearer.

Re: [PATCH v9 02/10] ASoC: imx-pcm-fiq: Introduce pcm-fiq-params

2013-07-03 Thread Mark Brown
On Thu, Jun 20, 2013 at 03:20:21PM +0200, Markus Pargmann wrote: > Cleaner parameter passing for imx-pcm-fiq. Create a seperated fiq-params > struct to pass all arguments. Applied, thanks. signature.asc Description: Digital signature ___ devicetree-dis

Re: [PATCH v9 04/10] ASoC: fsl-ssi: Add support for imx-pcm-fiq

2013-07-03 Thread Mark Brown
On Thu, Jun 20, 2013 at 03:20:23PM +0200, Markus Pargmann wrote: > + ssi_private->use_dma = !of_property_read_bool(np, "fsl,imx-fiq"); > + This binding should be documented. I'm not sure it really needs to be a binding, though - is it not possible for the driver to just figure out that DMA w

Re: [PATCH v9 03/10] ASoC: fsl: Move soc_ac97_ops from imx-ssi to fsl_ssi

2013-07-03 Thread Mark Brown
On Thu, Jun 20, 2013 at 03:20:22PM +0200, Markus Pargmann wrote: > fsl_ssi and imx-ssi can be both enabled at the same time. To be able to > add AC97 support to fsl_ssi, soc_ac97_ops have to be available to both > drivers. This needs to be redone on top of the changes that went into v3.11 to suppo

Re: [PATCH v9 09/10] ASoC: fsl: Move fsl-ssi binding doc to sound/

2013-07-03 Thread Mark Brown
On Thu, Jun 20, 2013 at 03:20:28PM +0200, Markus Pargmann wrote: > fsl-ssi was located in powerpc/fsl/ssi.txt. This is no powerpc specific > device, so it should be moved to sound/ as it connects to differen audio > codecs. Applied, thanks. signature.asc Description: Digital signature __

Re: [PATCH v9 01/10] ASoC: imx-pcm-dma: DT support

2013-07-03 Thread Mark Brown
On Thu, Jun 20, 2013 at 03:20:20PM +0200, Markus Pargmann wrote: > This patch removes the NO_DT flag. The pdev pointer may have a proper > of_node with the dmas property, so we can use it to request DMA > channels. Applied, thanks. signature.asc Description: Digital signature ___

Re: [PATCH v9 08/10] ASoC: Add phycore-ac97-dt driver

2013-07-03 Thread Mark Brown
On Thu, Jun 20, 2013 at 03:20:27PM +0200, Markus Pargmann wrote: > Notes: > Changes in v9: > - Fix blank line at end of file. > Please don't include enormous changelogs like this, they're just noise. > +config SND_SOC_PHYCORE_AC97_DT > + bool "SoC Audio support for Phytec phyCO

Re: [PATCH v9 10/10] ASoC: fsl: Update fsl-ssi binding doc

2013-07-03 Thread Mark Brown
On Thu, Jun 20, 2013 at 03:20:29PM +0200, Markus Pargmann wrote: > Update the fsl-ssi bindings. DMA is no required property anymore and > uses the generic DMA bindings. imx-fiq is a new alternative to DMA These updates should be done as part of the patches making the code changes - see the review

Re: [RFC PATCH v4 2/2] drivers: mfd: vexpress: add Serial Power Controller (SPC) support

2013-07-03 Thread Mark Brown
On Tue, Jun 18, 2013 at 11:22:13AM +0100, Lorenzo Pieralisi wrote: > On Mon, Jun 17, 2013 at 06:44:51PM +0100, Olof Johansson wrote: > > That'll trim down the driver to a point where I think you'll find it much > > easier to get merged. :-) > To start with I have to understand in which directory

Re: [RFC PATCH V2 1/8] regulator: Introduce OMAP regulator to control PMIC over VC/VP

2013-07-04 Thread Mark Brown
On Fri, Jun 21, 2013 at 04:25:42PM -0500, Nishanth Menon wrote: > +static const struct omap_pmic_info omap_twl4030_vdd1 = { > + .slave_addr = 0x12, > + .voltage_reg_addr = 0x00, > + .cmd_reg_addr = 0x00, > + .i2c_timeout_us = 200, > + .slew_rate_uV = 4000, > + .step_size_uV

Re: Appended DTB files for multi-machine kernels

2013-07-04 Thread Mark Brown
On Thu, Jul 04, 2013 at 06:56:24PM +0200, Daniel Mack wrote: > Unless I missed some recent discussion, this case is not easy to handle. > Yes, I know that these kind of things should be handled by a > next-generation bootloader, but in our case, we want to avoid a loader > update of already shippe

Re: [RFC PATCH V2 1/8] regulator: Introduce OMAP regulator to control PMIC over VC/VP

2013-07-05 Thread Mark Brown
On Fri, Jul 05, 2013 at 08:55:07AM -0500, Nishanth Menon wrote: Please write in paragraphs, an enormous wall of unbroken text isn't helpful for legibility. > On 16:41-20130704, Mark Brown wrote: > > So, this still has the thing where all the data about the PMIC is > > re

Re: [RFC PATCH V2 1/8] regulator: Introduce OMAP regulator to control PMIC over VC/VP

2013-07-05 Thread Mark Brown
On Fri, Jul 05, 2013 at 09:50:34AM -0500, Nishanth Menon wrote: > On 07/05/2013 09:08 AM, Mark Brown wrote: > >>option 1) we just bypass get_voltage/set_voltage to point through to > >>this function. result will be something similar to what we got here[1] > >I don&

Re: [RFC PATCH V2 1/8] regulator: Introduce OMAP regulator to control PMIC over VC/VP

2013-07-05 Thread Mark Brown
On Fri, Jul 05, 2013 at 12:33:10PM -0500, Nishanth Menon wrote: > Taking an example of twl-regulator and omap_pmic, are you suggesting > omap_pmic to be a user twl-regulator using > include/linux/regulator/consumer.h? or are you suggesting that > omap_pmic should not be a regulator at all? No, I'

Re: [RFC PATCH 08/13] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-05 Thread Mark Brown
On Fri, Jul 05, 2013 at 05:15:05PM +0200, Richard Genoud wrote: > 2013/7/2 Bo Shen : > >> From: Nicolas Ferre > >> > >> Description of the Asoc machine driver for an at91sam9x5 based board > >> with a wm8731 audio DAC. Wm8731 is clocked by a crystal and used as a > >> master on the SSC/I2S interf

[PATCH] of/platform: Staticize of_platform_device_create_pdata()

2013-07-08 Thread Mark Brown
From: Mark Brown It is not used outside of this file so doesn't need to be in the global namespace. Signed-off-by: Mark Brown --- drivers/of/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index e0a6514..b0

Re: [PATCH v9 08/10] ASoC: Add phycore-ac97-dt driver

2013-07-08 Thread Mark Brown
On Sun, Jul 07, 2013 at 09:19:49AM +0200, Markus Pargmann wrote: > On Wed, Jul 03, 2013 at 05:17:27PM +0100, Mark Brown wrote: > > > +extern void pca100_ac97_cold_reset(struct snd_ac97 *ac97); > > > +extern void pca100_ac97_warm_reset(struct snd_ac97 *ac97); > >

Re: [PATCH v9 04/10] ASoC: fsl-ssi: Add support for imx-pcm-fiq

2013-07-08 Thread Mark Brown
On Sat, Jul 06, 2013 at 07:13:23PM +0200, Markus Pargmann wrote: > On Wed, Jul 03, 2013 at 05:06:37PM +0100, Mark Brown wrote: > > On Thu, Jun 20, 2013 at 03:20:23PM +0200, Markus Pargmann wrote: > > > + ssi_private->use_dma = !of_property_read_bool(np, "fsl,imx-fiq"

Re: [alsa-devel] [PATCH v2 3/5] ARM: AT91: DTS: sam9x5ek: add WM8731 codec

2013-07-08 Thread Mark Brown
On Mon, Jul 08, 2013 at 03:29:51PM +0200, Richard Genoud wrote: > The WM8731 codec on sam9x5ek board is on i2c, address 1A > > Signed-off-by: Richard Genoud Acked-by: Mark Brown This should go via arm-soc. signature.asc Description: Digital

Re: [PATCH v1 4/4] spi/xilinx: Use of_property_read_u32 for reading value from node

2013-07-08 Thread Mark Brown
On Mon, Jul 08, 2013 at 03:29:17PM +0200, Michal Simek wrote: > It simplifies driver probing. Applied, thanks. signature.asc Description: Digital signature ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org

Re: [PATCH v2 2/5] ARM: AT91: DTS: sam9x5: add SSC DMA parameters

2013-07-08 Thread Mark Brown
On Mon, Jul 08, 2013 at 03:29:50PM +0200, Richard Genoud wrote: > Signed-off-by: Richard Genoud > --- > arch/arm/boot/dts/at91sam9x5.dtsi |3 +++ There was no binding document in your first patch - there should be one for any new DT bindings. signature.asc Description: Digital signature ___

Re: [PATCH v1 4/4] spi/xilinx: Use of_property_read_u32 for reading value from node

2013-07-09 Thread Mark Brown
On Tue, Jul 09, 2013 at 07:26:27AM +0200, Michal Simek wrote: > On 07/08/2013 04:51 PM, Mark Brown wrote: > > Applied, thanks. > have you applied this patch? Yes, network is spotty here so pushes aren't working so well. signature.asc Description:

Re: [PATCH v2 1/5] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-09 Thread Mark Brown
On Tue, Jul 09, 2013 at 10:19:45AM +0200, Richard Genoud wrote: > 2013/7/8 Mark Brown : > > The obvious question here is of course if we can use the same driver for > > both of them. > I haven't got a g20 to test that, but that's the goal. I think I do somewhere. &g

Re: [PATCH v2 2/5] ARM: AT91: DTS: sam9x5: add SSC DMA parameters

2013-07-09 Thread Mark Brown
On Tue, Jul 09, 2013 at 10:27:53AM +0200, Richard Genoud wrote: > The dma binding is documented here > Documentation/devicetree/bindings/dma/atmel-dma.txt > But you're right, I shoud update > Documentation/devicetree/bindings/misc/atmel-ssc.txt. No, you need to write a binding for this machine dr

Re: [PATCH v4 0/7] Sound support for at91sam9x5-wm8731 based boards

2013-07-09 Thread Mark Brown
On Tue, Jul 09, 2013 at 04:25:26PM +0200, Richard Genoud wrote: > [I've just seen that I forgot to cc Uwe to the cover letter, sorry for that.] This is the second or third copy of this patch set I've been sent *today*. Worse, everything seems to be being sent in reply to the same thread increasin

Re: [PATCH v4 1/7] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-09 Thread Mark Brown
On Tue, Jul 09, 2013 at 04:25:27PM +0200, Richard Genoud wrote: > +/* > + * Authorized rates are: > + * Rate = MCLK_RATE / (n * 2) > + * Where n is in [1..4095] > + * (cf register SSC_CMR) > + */ > +static unsigned int rates[] = { > + 8000, > + 16000, > + 32000, > + 48000, > +

Re: [PATCH v4 2/7] Documentation: DT: add sam9x5ek-wm8731 machine driver

2013-07-09 Thread Mark Brown
On Tue, Jul 09, 2013 at 04:25:28PM +0200, Richard Genoud wrote: > This add the sound DT binding for sam9x5ek-wm8731 machine driver > > Signed-off-by: Richard Genoud > --- > .../bindings/sound/atmel-sam9x5-wm8731-audio.txt | 30 > Put new binding documents in the same pa

Re: [PATCH v4 3/7] Documentation: DT: update atmel SSC with DMA binding

2013-07-09 Thread Mark Brown
On Tue, Jul 09, 2013 at 04:25:29PM +0200, Richard Genoud wrote: > - reg: Should contain SSC registers location and length > - interrupts: Should contain SSC interrupt > +For dma transfer: > +- dmas: DMA specifier, consisting of a phandle to DMA controller node, > + the memory interface and SSC

Re: [RFC PATCH V2 1/8] regulator: Introduce OMAP regulator to control PMIC over VC/VP

2013-07-09 Thread Mark Brown
On Mon, Jul 08, 2013 at 12:22:36PM -0500, Nishanth Menon wrote: > case #1 - TPS62361 has a single SMPS and a single generic i2c bus, > one can talk on. In this case, you'd associate the regulator device > in one place - i2cX or on custom SoC hardware interface. > When used with custom SoC hardwar

Re: [RFC PATCH V2 1/8] regulator: Introduce OMAP regulator to control PMIC over VC/VP

2013-07-10 Thread Mark Brown
On Tue, Jul 09, 2013 at 11:04:23AM -0500, Nishanth Menon wrote: > On 07/09/2013 10:29 AM, Mark Brown wrote: > >This seems like something we should be able to cope with by for example > >adding a bus for the custom PMIC interface or otherwise finding a way to > I had consid

Re: [PATCH v4 1/7] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-10 Thread Mark Brown
On Wed, Jul 10, 2013 at 11:25:37AM +0200, Richard Genoud wrote: > 2013/7/9 Mark Brown : > > Shouldn't the SSC driver be enforcing this constraint if it comes from > > the SSC hardware? If the clock is reprogrammable the usual convention > > for drivers is to not constr

Re: [PATCH v4 3/7] Documentation: DT: update atmel SSC with DMA binding

2013-07-10 Thread Mark Brown
On Wed, Jul 10, 2013 at 11:48:27AM +0200, Richard Genoud wrote: > 2013/7/9 Mark Brown : > > ...this first example is now invalid and should probably just be being > > extended with the new required properties. > Well, I have to rewrite that to make it clearer. > The th

Re: [PATCH] mfd: DT bindings for the palmas family MFD

2013-07-10 Thread Mark Brown
On Mon, Jun 03, 2013 at 03:18:51PM +0100, Lee Jones wrote: > On Mon, 03 Jun 2013, J Keerthy wrote: > > + optional chip specific regulator fields :- > > + ti,warm-reset - maintain voltage during warm reset(boolean) > Pushing the boat out a bit here, but is it possible to reuse >

Re: [PATCH v5 1/7] sound: codec: wm8731: add rates constraints

2013-07-12 Thread Mark Brown
On Thu, Jul 11, 2013 at 06:15:53PM +0200, Richard Genoud wrote: Please always try to use commit logs that look like normal commit logs for the subsystem. > switch (freq) { > - case 11289600: > case 1200: > + wm8731->constraints = &wm8731_constraints_1200; > +

Re: [PATCH v5 2/7] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-12 Thread Mark Brown
On Thu, Jul 11, 2013 at 06:15:54PM +0200, Richard Genoud wrote: > From: Nicolas Ferre > > Description of the Asoc machine driver for an at91sam9x5 based board ASoC. > +sam9x5 pins: > + * LOUT > + * ROUT > + * LHPOUT > + * RHPOUT > + * LLINEIN > + * RLINEIN > + * MICIN These aren't pins on the

Re: [PATCH v2] regulator: pfuze100: add pfuze100 regulator driver

2013-07-12 Thread Mark Brown
On Fri, Jul 12, 2013 at 12:54:15PM +0800, Robin Gong wrote: > Add pfuze100 regulator driver. This looks mostly good. A few small issues below but nothing major. > +enum pfuze_id { > + PFUZE_ID_PFUZE100, > + PFUZE_ID_INVALID, > +}; > +struct pfuze_chip { Missing blank line here - there a

Re: [PATCH v2] regulator: pfuze100: add pfuze100 regulator driver

2013-07-15 Thread Mark Brown
On Sat, Jul 13, 2013 at 12:15:12AM +0800, Robin Gong wrote: Please fix your mail program to word wrap between paragraphs. > On Fri, Jul 12, 2013 at 03:40:37PM +0100, Mark Brown wrote: > > > +static const int pfuze100_swbst[] = { > > > + 500, 505, 510, 515

<    2   3   4   5   6   7   8   9   10   >