Re: [PATCH] Documentation: dt: bindings: TI WiLink modules

2013-06-28 Thread Mark Rutland
[resending again with the doubly corrected address for Mike Turquette, apologies for the spam] On Fri, Jun 28, 2013 at 10:53:35AM +0100, Luciano Coelho wrote: > On Fri, 2013-06-28 at 10:38 +0100, Mark Rutland wrote: > > On Tue, Jun 25, 2013 at 09:35:30AM +0100, Luciano Coe

Re: [PATCH] Documentation: dt: bindings: TI WiLink modules

2013-06-28 Thread Mark Rutland
[resending with the correct address for Mike Turquette] On Fri, Jun 28, 2013 at 10:53:35AM +0100, Luciano Coelho wrote: > On Fri, 2013-06-28 at 10:38 +0100, Mark Rutland wrote: > > On Tue, Jun 25, 2013 at 09:35:30AM +0100, Luciano Coelho wrote: > > > +O

Re: [PATCH] Documentation: dt: bindings: TI WiLink modules

2013-06-28 Thread Mark Rutland
On Fri, Jun 28, 2013 at 10:53:35AM +0100, Luciano Coelho wrote: > On Fri, 2013-06-28 at 10:38 +0100, Mark Rutland wrote: > > On Tue, Jun 25, 2013 at 09:35:30AM +0100, Luciano Coelho wrote: > > > +Optional properties: > > > + > > > +

Re: [PATCH] Documentation: dt: bindings: TI WiLink modules

2013-06-28 Thread Mark Rutland
On Tue, Jun 25, 2013 at 09:35:30AM +0100, Luciano Coelho wrote: > Add device tree bindings documentation for the TI WiLink modules. > Currently only the WLAN part of the WiLink6, WiLink7 and WiLink8 > modules is supported. > > Signed-off-by: Luciano Coelho > --- > > I created a new directory und

Re: [PATCH v3 3/5] clk: dt: binding for basic multiplexer clock

2013-06-26 Thread Mark Rutland
Hi, I have a couple of minor comments. On Fri, Jun 21, 2013 at 07:14:14AM +0100, Mike Turquette wrote: > Device Tree binding for the basic clock multiplexer, plus the setup > function to register the clock. Based on the existing fixed-clock > binding. > > Includes minor beautification of clk-pr

Re: [PATCH] ARM: kernel: document ARM CPUs clock-frequency property

2013-06-19 Thread Mark Rutland
On Wed, Jun 19, 2013 at 10:47:17AM +0100, Florian Fainelli wrote: > ARM CPU device tree nodes may contain an optional clock-frequency > property, when set, this property must contain the CPU frequency in Hz, > which is then used by the topology parsing code in > arch/arm/kernel/topology.c to infer

Re: [PATCH v2 09/11] ARM:stixxxx: Add stixxxx options to multi_v7_defconfig

2013-06-17 Thread Mark Rutland
On Thu, Jun 13, 2013 at 10:24:45AM +0100, Srinivas KANDAGATLA wrote: > On 10/06/13 14:15, Mark Rutland wrote: > > CONFIG_EXPERIMENTAL's gone as of 3d374d09f1: "final removal of > > CONFIG_EXPERIMENTAL", so that's fine to go. CONFIG_GPIO_PL061 and > >

Re: [PATCH v2 09/11] ARM:stixxxx: Add stixxxx options to multi_v7_defconfig

2013-06-10 Thread Mark Rutland
On Mon, Jun 10, 2013 at 11:58:38AM +0100, Srinivas KANDAGATLA wrote: > Thanks for testing... > On 10/06/13 11:40, Mark Rutland wrote: > > On Mon, Jun 10, 2013 at 10:27:57AM +0100, Srinivas KANDAGATLA wrote: > >> > This patch adds stih415 and stih416 support to multi_v7_defc

Re: [PATCH v2 09/11] ARM:stixxxx: Add stixxxx options to multi_v7_defconfig

2013-06-10 Thread Mark Rutland
On Mon, Jun 10, 2013 at 10:27:57AM +0100, Srinivas KANDAGATLA wrote: > This patch adds stih415 and stih416 support to multi_v7_defconfig. This seems to drop a few options also: CONFIG_ARM_ARCH_TIMER CONFIG_ARM_ERRATA_754322 CONFIG_EXPERIMENTAL CONFIG_GPIO_PL061 CONFIG_MMC_WMT I just applied this

Re: [RFC PATCH v3 02/17] Documentation: devicetree: arm: cpus/cpu nodes bindings updates

2013-04-26 Thread Mark Rutland
On Fri, Apr 26, 2013 at 11:18:40AM +0100, Lorenzo Pieralisi wrote: > On Fri, Apr 26, 2013 at 03:51:10AM +0100, Rob Herring wrote: > > On Wed, Apr 24, 2013 at 12:28 PM, Lorenzo Pieralisi > > wrote: > > > In order to extend the current cpu nodes bindings to newer CPUs > > > inclusive of AArch64 and

Re: [PATCHv2 1/4] Documentation: Add memory mapped ARM architected timer binding

2013-04-26 Thread Mark Rutland
On Fri, Apr 26, 2013 at 12:06:21AM +0100, Rob Herring wrote: > On 04/25/2013 05:48 PM, Stephen Boyd wrote: > > On 04/25/13 14:47, Rob Herring wrote: > >> On 04/15/2013 04:33 PM, Stephen Boyd wrote: > >>> On 04/15/13 14:20, Rob Herring wrote: > On Fri, Apr 12, 2013 at 7:27 PM, Stephen Boyd >

Re: [RFC PATCH 2/2] ARM: DT: kernel: DT cpu node bindings update

2013-04-17 Thread Mark Rutland
Hi Stephen, > > + - enable-method > > + Usage: required on ARM 64-bit systems, optional on ARM 32-bit > > + systems > > + Value type: > > + Definition: On ARM 64-bit systems must be "spin-table" [1]. > > Can that be an integer instead? with dtc+cp

Re: [RFCv2 0/2] Representing interrupt affinity in devicetree

2013-04-15 Thread Mark Rutland
On Sat, Apr 13, 2013 at 10:33:22PM +0100, Grant Likely wrote: > On Tue, 5 Mar 2013 09:28:49 +0000, Mark Rutland wrote: > > On Mon, Mar 04, 2013 at 02:51:14AM +, Grant Likely wrote: > > > I could use some more context for how this will be used. Do device > > > driver

Re: [PATCH 1/4] Documentation: Add memory mapped ARM architected timer binding

2013-04-11 Thread Mark Rutland
On Thu, Apr 11, 2013 at 03:52:52AM +0100, Stephen Boyd wrote: > On 04/10/13 03:13, Mark Rutland wrote: > >>>> + > >>>> +- #size-cells : Must be 1. > >>>> + > >>>> +- ranges : Indicates parent and child bus address space are the same.

[RFC PATCH 11/11] arm: dts: add all PMUs for A15x2 A7x3 coretile

2013-04-11 Thread Mark Rutland
their reg properties. As the A15 PMU has different events than the A9 PMU, this patch also removes the "arm,cortex-a9-pmu" compatible string from the dts. Signed-off-by: Mark Rutland --- arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts | 44 ++ 1 file changed, 39

[RFC PATCH 10/11] arm: perf: allow multiple CPU PMUs to be registered

2013-04-11 Thread Mark Rutland
multiple PMUs simultaneously. This patch replaces the global cpu_pmu pointer with a list of cpu_pmus, enabling multiple PMUs to be registered and used simultaneously. Signed-off-by: Mark Rutland --- arch/arm/kernel/perf_event_cpu.c | 61 +--- 1 file changed, 38

[RFC PATCH 09/11] arm: perf: parse cpu affinity from dt

2013-04-11 Thread Mark Rutland
systems do not have a contiguous range of cpu ids. This patch parses cpu affinity information for interrupts from an optional "interrupts-affinity" devicetree property described in the devicetree binding document. Currently only SPIs are supported. Signed-off-by: Mark Rutland --- Doc

[RFC PATCH 08/11] arm: perf: probe number of counters on affine CPUs

2013-04-11 Thread Mark Rutland
In heterogeneous systems, the number of counters may differ across clusters. To find the number of counters for a cluster, we must probe the PMU from a CPU in that cluster. Signed-off-by: Mark Rutland Reviewed-by: Will Deacon --- arch/arm/kernel/perf_event_v7.c | 35

[RFC PATCH 07/11] arm: perf: treat PMUs as CPU affine

2013-04-11 Thread Mark Rutland
. Currently the cpumask is set to match all CPUs. Signed-off-by: Mark Rutland Reviewed-by: Will Deacon --- arch/arm/include/asm/pmu.h | 1 + arch/arm/kernel/perf_event.c | 20 arch/arm/kernel/perf_event_cpu.c | 10 +- 3 files changed, 30 insertions(+), 1 deletion

[RFC PATCH 06/11] arm: perf: dynamically allocate cpu hardware data

2013-04-11 Thread Mark Rutland
To support multiple PMUs, each PMU will need its own accounting data. As we don't know how (in general) many PMUs we'll have to support at compile-time, we must allocate the data at runtime dynamically Signed-off-by: Mark Rutland Reviewed-by: Will Deacon --- arch/arm/kernel/perf_e

[RFC PATCH 05/11] arm: perf: make get_hw_events take arm_pmu

2013-04-11 Thread Mark Rutland
d the correct set of pmu_hw_events structures. This patch changes the interface of get_hw_events to take a struct arm_pmu pointer, to enable future support for multiple PMUs. Signed-off-by: Mark Rutland Reviewed-by: Will Deacon --- arch/arm/include/asm/pmu.h | 2 +- arch/arm/k

[RFC PATCH 04/11] arm: perf: use IDR types for CPU PMUs

2013-04-11 Thread Mark Rutland
hichever PMU happens to be earlier in the pmus list (which currently will be the last compatible PMU registered). Signed-off-by: Mark Rutland Reviewed-by: Will Deacon --- arch/arm/kernel/perf_event.c | 6 +- arch/arm/kernel/perf_event_cpu.c | 2 +- 2 files changed, 6 insertions(+), 2 del

[RFC PATCH 03/11] arm: perf: clean up PMU names

2013-04-11 Thread Mark Rutland
istinguish them in the sys/bus/event_source namespace. This patch replaces the spaces and dashes in pmu names with underscores, and renames "v6" => "ARMv6" to better describe the PMU to userspace. The oprofile name conversion code is updated to handle this. Signed-off-by:

[RFC PATCH 02/11] arm: add functions to parse cpu affinity from dt

2013-04-11 Thread Mark Rutland
e topology nodes referenced - for describing coherency controls an affinity property may indicate a whole cluster (uncluding any non-CPU logic it contains) is affected by some configuration. Signed-off-by: Mark Rutland --- arch/arm/include/asm/dt_affinity.h | 12 arch/arm/kernel

[RFC PATCH 01/11] Documentation: DT: arm: define CPU topology bindings

2013-04-11 Thread Mark Rutland
documentation in the kernel required to define the device tree bindings describing the CPU topology for ARM 32-bit and 64-bit systems. Signed-off-by: Lorenzo Pieralisi Signed-off-by: Mark Rutland --- Documentation/devicetree/bindings/arm/topology.txt | 524 + 1 file changed, 524

[RFC PATCH 00/11] Topology bindings / Perf for big.LITTLE systems

2013-04-11 Thread Mark Rutland
e CPU topology bindings Mark Rutland (10): arm: add functions to parse cpu affinity from dt arm: perf: clean up PMU names arm: perf: use IDR types for CPU PMUs arm: perf: make get_hw_events take arm_pmu arm: perf: dynamically allocate cpu hardware data arm: perf: treat PMUs as CPU affine

Re: [PATCH 1/4] Documentation: Add memory mapped ARM architected timer binding

2013-04-10 Thread Mark Rutland
On Tue, Apr 09, 2013 at 05:42:38PM +0100, Stephen Boyd wrote: > On 04/09/13 02:08, Mark Rutland wrote: > > On Tue, Apr 09, 2013 at 03:30:20AM +0100, Stephen Boyd wrote: > >> > >> -** Timer node properties: > >> +** CP15 Timer node properties: > >>

Re: [PATCH 1/4] Documentation: Add memory mapped ARM architected timer binding

2013-04-09 Thread Mark Rutland
st support a physical > timer. It's optional for a frame to support a virtual timer. > > Cc: devicetree-discuss@lists.ozlabs.org > Cc: Mark Rutland > Cc: Marc Zyngier > Signed-off-by: Stephen Boyd > --- > .../devicetree/bindings/arm/arch_timer.txt | 62

Re: [PATCH 01/11] OF: add empty of_device_is_available for !OF

2013-03-21 Thread Mark Rutland
On Wed, Mar 20, 2013 at 10:54:01PM +, Rob Herring wrote: > From: Rob Herring > > Add an empty version of of_device_is_available. > > Signed-off-by: Rob Herring > --- > include/linux/of.h |5 + > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/of.h b/include/linux/of

Re: [RFCv2 0/2] Representing interrupt affinity in devicetree

2013-03-05 Thread Mark Rutland
On Mon, Mar 04, 2013 at 02:51:14AM +, Grant Likely wrote: > On Thu, 13 Dec 2012 16:49:26 +0000, Mark Rutland wrote: > > [This is an updated version of my previous RFC, which can be found at > > http://lists.infradead.org/pipermail/linux-arm-kernel/2012-October/128205.html] &

Re: [PATCH v2 12/12] clocksource: samsung-time: Add Device Tree support

2013-02-18 Thread Mark Rutland
Hi, [...] > +static void samsung_timer_parse_dt(struct device_node *np, > + const struct of_device_id *match) > +{ > + int i; > + u32 val; > + > + timer_base = of_iomap(np, 0); > + if (!timer_base) > + panic("failed to map timer regi

Re: [PATCHi v2] net: sh_eth: Add support of device tree probe

2013-02-15 Thread Mark Rutland
Hello, I have a couple of comments on the binding and the way it's parsed. On Thu, Feb 14, 2013 at 12:51:31AM +, Nobuhiro Iwamatsu wrote: > This adds support of device tree probe for Renesas sh-ether driver. > > Signed-off-by: Nobuhiro Iwamatsu > > --- > V2: - Removed ether_setup(). >

Re: [PATCH 12/12] clocksource: samsung-time: Add Device Tree support

2013-02-12 Thread Mark Rutland
Hi Tomasz, [...] > > > +Required properties: > > > +- compatible : should be one of following: > > > +samsung,s3c24xx-pwm-timer - for 16-bit timers present on S3C24xx > > > +samsung,s3c64xx-pwm-timer - for 32-bit timers present on S3C64xx > > > and newer +- reg: base address and size of r

Re: [PATCH v3 1/3] mmc: davinci_mmc: add DT support

2013-02-12 Thread Mark Rutland
Hi Prakash, I think this looks pretty good now :) Reviewed-by: Mark Rutland Thanks, Mark. On Tue, Feb 12, 2013 at 06:37:36AM +, Manjunathappa, Prakash wrote: > Adds device tree support for davinci_mmc. Also add binding documentation. > As of now in non-dma PIO mode and withou

Re: [PATCH 12/12] clocksource: samsung-time: Add Device Tree support

2013-02-11 Thread Mark Rutland
On Sun, Feb 10, 2013 at 01:20:23PM +, Tomasz Figa wrote: > This patch adds support for parsing all platform-specific data from > Device Tree and instantiation using clocksource_of_init to samsung-time > clocksource driver. > > Cc: devicetree-discuss@lists.ozlabs.org > Signed-off-by: Tomasz Fig

Re: [PATCH RFC 3/7] ARM: OMAP: gpmc-smsc911x: add DT dev node init function

2013-02-11 Thread Mark Rutland
Hi, I have a few comments on the binding and the way it's parsed. On Sat, Feb 09, 2013 at 08:44:27PM +, Javier Martinez Canillas wrote: > This patch adds a helper function to parse a device node that > contains all the properties needed to initialize an smsc911x > device connected to an OMAP

Re: [PATCH v2 2/3] mmc: davinci_mmc: add DT support

2013-02-08 Thread Mark Rutland
Hi, [...] > > > diff --git a/Documentation/devicetree/bindings/mmc/davinci_mmc.txt > > > b/Documentation/devicetree/bindings/mmc/davinci_mmc.txt > > > new file mode 100644 > > > index 000..6717ab1 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/mmc/davinci_mmc.txt > > > @@

Re: [PATCH] ARM: dts: add minimal DT support for DevKit8000

2013-02-07 Thread Mark Rutland
Hello, I have a couple of minor comments. On Thu, Feb 07, 2013 at 02:11:37PM +, Anil Kumar wrote: > DevKit8000 is a beagle board clone from Timll, sold by > armkits.com. The DevKit8000 has RS232 serial port, LCD, DVI-D, > S-Video, Ethernet, SD/MMC, keyboard, camera, SPI, I2C, USB and > JTAG i

Re: [PATCH v2 2/3] mmc: davinci_mmc: add DT support

2013-02-07 Thread Mark Rutland
Hello, I have a couple of comments on the dt bindings and the way it's parsed. On Thu, Feb 07, 2013 at 07:57:04AM +, Manjunathappa, Prakash wrote: > Adds device tree support for davinci_mmc. Also add binding documentation. > Tested in non-dma PIO mode and without GPIO card_detect/write_protec

Re: [PATCH/RFC] mmc: add DT bindings for more MMC capability flags

2013-02-06 Thread Mark Rutland
Hi, On Wed, Jan 23, 2013 at 04:45:11PM +, Guennadi Liakhovetski wrote: > Many MMC capability flags are platform-dependent and are traditionally set > in platform data. With DT often each such capability requires a special > binding. Add bindings for MMC_CAP_SD_HIGHSPEED, MMC_CAP_MMC_HIGHSPEED

Re: [PATCH 09/13] mfd: omap-usb-host: Add device tree support and binding information

2013-02-05 Thread Mark Rutland
[...] > >> + > >> +- single_ulpi_bypass: Must be present if the controller contains a single > >> + ULPI bypass control bit. e.g. OMAP3 silicon <= ES2.1 > > > > Again it would be nicer to have '-' rather than '_' here. It might be worth > > prefixing this "ti,". > > Is prefixing with "ti" reall

Re: [PATCH 09/13] mfd: omap-usb-host: Add device tree support and binding information

2013-02-05 Thread Mark Rutland
Hi, I have a few comments on the binding and the way it's parsed. On Mon, Feb 04, 2013 at 03:58:56PM +, Roger Quadros wrote: > Allows the OMAP HS USB host controller to be specified > via device tree. > > CC: Samuel Ortiz > Signed-off-by: Roger Quadros > --- > .../devicetree/bindings/mfd/

Re: [PATCH 08/13] USB: ehci-omap: Add device tree support and binding information

2013-02-05 Thread Mark Rutland
On Mon, Feb 04, 2013 at 03:58:55PM +, Roger Quadros wrote: > Allows the OMAP EHCI controller to be specified via device tree. > > Signed-off-by: Roger Quadros > --- > .../devicetree/bindings/usb/omap-ehci.txt | 34 ++ > drivers/usb/host/ehci-omap.c

Re: [PATCH 2/3] mmc: davinci_mmc: add DT support

2013-02-04 Thread Mark Rutland
Hi, On Mon, Feb 04, 2013 at 01:28:14PM +, Manjunathappa, Prakash wrote: > Hi Mark, > > On Thu, Jan 31, 2013 at 16:53:03, Mark Rutland wrote: > > Hello, > > > > I have a few comments on the devicetree binding and the way it's parsed. > > > > Thank

Re: [PATCH 2/3] mmc: davinci_mmc: add DT support

2013-01-31 Thread Mark Rutland
Hello, I have a few comments on the devicetree binding and the way it's parsed. On Thu, Jan 31, 2013 at 10:33:06AM +, Manjunathappa, Prakash wrote: > Adds device tree support for davinci_mmc. Also add > binding documentation. > Tested with non-dma PIO mode and without GPIO > card_detect/write

Re: [PATCH] ARM: architected timers: allow dt based discovery using clocksource_of_init

2013-01-30 Thread Mark Rutland
Thomas, On Tue, Jan 22, 2013 at 11:04:56AM +, Mark Rutland wrote: > On Mon, Jan 21, 2013 at 06:30:47PM +, Thomas Abraham wrote: > > Hi Stephen, > > > > On 21 January 2013 09:21, Stephen Warren wrote: > > > On 01/20/2013 06:22 PM, Thomas Abraham

Re: [PATCH v3 3/3] arm: omap2: gpmc: add DT bindings for OneNAND

2013-01-28 Thread Mark Rutland
On Fri, Jan 25, 2013 at 06:11:28PM +, Ezequiel Garcia wrote: > Hi Mark, > > First of all: thanks for reviewing. > > On Fri, Jan 25, 2013 at 12:56 PM, Mark Rutland wrote: > > Hi, > > > > I have a couple more comments after looking though this a bit more &g

Re: [PATCH 5/6] ARM: dts: Add basic dts include files for Samsung S3C64xx SoCs

2013-01-28 Thread Mark Rutland
On Fri, Jan 25, 2013 at 07:15:48PM +, Kukjin Kim wrote: > Tomasz Figa wrote: > > [...] > > > > Well, the number of CPU types does not grow rapidly. It will be much > > > less than one per SoC -- so keeping the list up to date shouldn't be > > > that much effort. > > > > > > For ARM1176JZF-S,

Re: [PATCH v4 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-25 Thread Mark Rutland
On Fri, Jan 25, 2013 at 04:23:46PM +, Felipe Balbi wrote: > Hi, > > On Fri, Jan 25, 2013 at 04:14:02PM +0000, Mark Rutland wrote: > > On Fri, Jan 25, 2013 at 02:59:28PM +, Felipe Balbi wrote: > > > Hi, > > > > > > On Fri, Jan 25, 20

Re: [PATCH v4 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-25 Thread Mark Rutland
On Fri, Jan 25, 2013 at 02:59:28PM +, Felipe Balbi wrote: > Hi, > > On Fri, Jan 25, 2013 at 12:29:43PM +0000, Mark Rutland wrote: > > > > > + depending upon omap4 or omap5. > > > > > + - reg-names: The names of the register addresses co

Re: [PATCH v3 3/3] arm: omap2: gpmc: add DT bindings for OneNAND

2013-01-25 Thread Mark Rutland
quiel Garcia > --- > Changes from v2: > * Remove unneeded of_node_put() as reported by Mark Rutland > > Changes from v1: > * Fix typo in Documentation/devicetree/bindings/mtd/gpmc-onenand.txt > > .../devicetree/bindings/mtd/gpmc-onenand.txt | 43 +

Re: [PATCH v4 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-25 Thread Mark Rutland
[...] > > > +OMAP CONTROL USB > > > + > > > +Required properties: > > > + - compatible: Should be "ti,omap-control-usb" > > > + - reg : Address and length of the register set for the device. It > > > contains > > > + the address of "control_dev_conf" and "otghs_control" or > > > "phy_power_usb

Re: [PATCH v4 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-25 Thread Mark Rutland
On Fri, Jan 25, 2013 at 10:23:57AM +, Kishon Vijay Abraham I wrote: > Added a new driver for the usb part of control module. This has an API > to power on the USB2 phy and an API to write to the mailbox depending on > whether MUSB has to act in host mode or in device mode. > > Writing to contr

Re: [PATCH] ARM: dts: specify all the per-cpu interrupts of arch timer for exynos5440

2013-01-23 Thread Mark Rutland
On Tue, Jan 22, 2013 at 10:05:18PM +, Kukjin Kim wrote: > Mark Rutland wrote: > > > + devicetree-discuss, Grant Likely, Rob Herring and Tony Lindgren > > > On Tue, Jan 22, 2013 at 01:41:27AM +, Kukjin Kim wrote: > > > From: Thomas Abraham > > > &

Re: [PATCH V2 0/5] W1: Support onewire master on i.MX53

2013-01-22 Thread Mark Rutland
arm-soc. Both series should be sufficiently > >> orthogonal. > >> > > Evgeniy has already ACK-ed the v1 series, so maybe he does not see any > > problem with the whole series going through one tree. In that case, > > we may just have it go via arm-soc tree? O

Re: [PATCH] ARM: architected timers: allow dt based discovery using clocksource_of_init

2013-01-22 Thread Mark Rutland
On Mon, Jan 21, 2013 at 06:30:47PM +, Thomas Abraham wrote: > Hi Stephen, > > On 21 January 2013 09:21, Stephen Warren wrote: > > On 01/20/2013 06:22 PM, Thomas Abraham wrote: > >> Add an entry in __clksrc_of_table so that ARMv7 architected timer is > >> discoverable using call to clocksource

Re: [PATCH v1 5/6] usb: otg: add device tree support to otg library

2013-01-22 Thread Mark Rutland
> +struct usb_phy *devm_usb_get_phy_by_phandle(struct device *dev, > + const char *phandle, u8 index) > +{ > + struct usb_phy *phy = NULL, **ptr; > + unsigned long flags; > + struct device_node *node; > + > + if (!dev->of_node) { > + dev_dbg(dev, "device does not

Re: [PATCH v4 3/7] ARM: Exynos: add device tree support for MCT controller driver

2013-01-21 Thread Mark Rutland
On Mon, Jan 21, 2013 at 10:02:18AM +, Thomas Abraham wrote: > Allow the MCT controller base address and interrupts to be obtained from > device tree and remove unused static definitions of these. The non-dt support > for Exynos5250 is removed but retained for Exynos4210 based platforms. > > Cc

Re: [PATCH v2 3/3] arm: omap2: gpmc: add DT bindings for OneNAND

2013-01-21 Thread Mark Rutland
[...] > diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c > index 01ce462..f7de9eb 100644 > --- a/arch/arm/mach-omap2/gpmc.c > +++ b/arch/arm/mach-omap2/gpmc.c > @@ -39,6 +39,7 @@ > #include "omap_device.h" > #include "gpmc.h" > #include "gpmc-nand.h" > +#include "gpmc-onenan

Re: [PATCH] ARM: architected timers: allow dt based discovery using clocksource_of_init

2013-01-21 Thread Mark Rutland
Hi Thomas, This looks really useful, and it's going to conflict with my arch_timer / arm_generic driver unification series [1]. I'm happy to take this as part of my series if that's ok with you? On Mon, Jan 21, 2013 at 01:22:06AM +, Thomas Abraham wrote: > Add an entry in __clksrc_of_table s

Re: [PATCH 5/6] ARM: dts: Add basic dts include files for Samsung S3C64xx SoCs

2013-01-14 Thread Mark Rutland
Hello, This all looks good. I just have a couple of comments about the cpus node. On Sun, Jan 13, 2013 at 01:10:57AM +, Tomasz Figa wrote: > This patch adds basic device tree definitions for Samsung S3C64xx SoCs. > > Since all the SoCs in the series are very similar, the files are created >

Re: PMU node location

2013-01-14 Thread Mark Rutland
On Mon, Jan 14, 2013 at 09:36:10AM +, Michal Simek wrote: > 2013/1/14 Mark Rutland : > > On Sat, Jan 12, 2013 at 03:54:42PM +, Rob Herring wrote: > >> On 01/10/2013 07:47 AM, Michal Simek wrote: > >> > Hi Rob, Mark, Grant and others, > >> > >

Re: [PATCH 02/11] ARM: nomadik: initial devicetree support

2013-01-14 Thread Mark Rutland
On Mon, Jan 14, 2013 at 07:02:06AM +, Linus Walleij wrote: > On Fri, Jan 11, 2013 at 6:57 PM, Mark Rutland wrote: > > On Fri, Jan 11, 2013 at 05:04:11PM +, Grant Likely wrote: > >> On Tue, 8 Jan 2013 09:57:29 +, Mark Rutland > >> wrote: > >> &

Re: PMU node location

2013-01-14 Thread Mark Rutland
On Sat, Jan 12, 2013 at 03:54:42PM +, Rob Herring wrote: > On 01/10/2013 07:47 AM, Michal Simek wrote: > > Hi Rob, Mark, Grant and others, > > > > I want to check with you the location of ARM pmu node > > I see that > > 1) highbank and dbx5x0 have it in soc node > > > > 2) vexpress and tegra

Re: [PATCH 1/8] SH: intc: Add support OF for INTC

2013-01-09 Thread Mark Rutland
ctures have just been converted to lists in dt, without any thought as to whether or not this is a clean representation of the hardware. > > Cc: Magnus Damm > Signed-off-by: Nobuhiro Iwamatsu > Signed-off-by: Simon Horman > > --- > > v9 > * As suggested by Mark Rutlan

Re: [PATCH 3/8] ARM: shmobile: Add support OF of INTC for sh7372

2013-01-09 Thread Mark Rutland
On Wed, Jan 09, 2013 at 06:30:02AM +, Simon Horman wrote: > From: Nobuhiro Iwamatsu > > This CPU has four interrupt controllers (INTCA, pins-High and pins-Low). > This supports these. > Note: This supports DT of INTCA only. > > Cc: Magnus Damm > Signed-off-by: Nobuhiro Iwamatsu > Signed-of

Re: [PATCH 01/10] ARM: shmobile: Add support OF for INTC of shmobile

2012-12-18 Thread Mark Rutland
Hi, I have some comments on the devicetree binding. On Sat, Dec 15, 2012 at 09:03:35AM +, Simon Horman wrote: > From: Nobuhiro Iwamatsu > > This provides OF support of SH/INTC. > > The SH/INTC driver is used by SuperH and ARM/SH-MOBILE. > At the moment, SuperH does not have the plan correspo

Re: [RESEND PATCH 2/2] ARM: dts: OMAP2+: Add PMU nodes

2012-12-17 Thread Mark Rutland
On Fri, Dec 14, 2012 at 09:26:37PM +, Jon Hunter wrote: > Add PMU nodes for OMAP2, OMAP3 and OMAP4460 devices. > > Please note that the node for OMAP4460 has been placed in a separate > header file for OMAP4460, because the node is not compatible with > OMAP4430. > > Signed-off-by: Jon Hunter

Re: [RFC 2/5] ARM: dts: Add Cross Trigger Interface binding

2012-12-17 Thread Mark Rutland
On Thu, Dec 13, 2012 at 07:21:30PM +, Jon Hunter wrote: > > On 12/13/2012 11:41 AM, Will Deacon wrote: > > On Wed, Dec 12, 2012 at 09:43:05PM +, Jon Hunter wrote: > >> Adds a device-tree binding for the ARM Cross Trigger Interface (CTI). > >> The ARM Cross Trigger Interface provides a way

[RFCv2 2/2] ARM: add functions to parse irq affinity from dt

2012-12-13 Thread Mark Rutland
The level-specifier is in the range [0-3]. When the value is 3, MPIDR affinity levels 2,1,0 are ignored, and all CPUs are matched. Affinity bits which are not to be matched should be set to zero. Signed-off-by: Mark Rutland --- arch/arm/include/asm/dt_irq.h |9 arch/arm/k

[RFCv2 1/2] of: add of_property_read_u32_index

2012-12-13 Thread Mark Rutland
trary index in a list, making this case easier. Signed-off-by: Mark Rutland --- drivers/of/base.c | 36 include/linux/of.h | 11 +++ 2 files changed, 47 insertions(+), 0 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index af

[RFCv2 0/2] Representing interrupt affinity in devicetree

2012-12-13 Thread Mark Rutland
ng whether an interrupt targets multiple cpus. The patches are based on rmk's for-next branch. Any thoughts? Thanks, Mark. Mark Rutland (2): of: add of_property_read_u32_index ARM: add functions to parse irq affinity from dt arch/arm/include/asm/dt_irq.h |9 arch/arm/kernel/dev

Re: [PATCH v4 4/7] ARM: kernel: add device tree init map function

2012-11-19 Thread Mark Rutland
On Mon, Nov 19, 2012 at 12:45:03PM +, Lorenzo Pieralisi wrote: > When booting through a device tree, the kernel cpu logical id map can be > initialized using device tree data passed by FW or through an embedded blob. > > This patch adds a function that parses device tree "cpu" nodes and > retr

Re: [PATCH v3 2/5] ARM: kernel: add device tree init map function

2012-11-19 Thread Mark Rutland
Hi, Just a couple of comments on the binding documentation. > diff --git a/Documentation/devicetree/bindings/arm/cpus.txt > b/Documentation/devicetree/bindings/arm/cpus.txt > new file mode 100644 > index 000..1fab07a > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/cpus.txt > @@

Re: [PATCH v8 1/3] Runtime Interpreted Power Sequences

2012-11-16 Thread Mark Rutland
On Fri, Nov 16, 2012 at 06:38:21AM +, Alexandre Courbot wrote: > Some device drivers (e.g. panel or backlights) need to follow precise > sequences for powering on and off, involving GPIOs, regulators, PWMs > with a precise powering order and delays to respect between steps. > These sequences ar

Re: [PATCH v2 2/5] ARM: kernel: add device tree init map function

2012-11-12 Thread Mark Rutland
On Fri, Nov 09, 2012 at 02:34:11PM +, Lorenzo Pieralisi wrote: > When booting through a device tree, the kernel cpu logical id map can be > initialized using device tree data passed by FW or through an embedded blob. > > This patch adds a function that parses device tree "cpu" nodes and > retr

[PATCH 2/2] ARM: Add functions to parse dt irq affinity

2012-10-26 Thread Mark Rutland
e, and has an "affinity" value, then the interrupt at index i in the interrupts list is affine to the cpu or cluster pointed to by the entry in the affinity list at index i. Interrupts affine to a cluster are PPIs, and interrupts affine to a single cpu are SPIs. Signed-off-by: Mar

[PATCH 1/2] of: add of_property_count_phandles

2012-10-26 Thread Mark Rutland
Though of_parse_phandle handles lists of phandles, and takes an index parameter, there is no standard way of discovering how many phandles are present on a node. This patch adds a function to count how many phandles are in a phandle list. Signed-off-by: Mark Rutland --- drivers/of/base.c

[RFC 0/2] Representing interrupt affinity in devicetree

2012-10-26 Thread Mark Rutland
> request_percpu_irq(...); > } > } Does anyone have any better ideas? Any and all feedback welcome. Thanks, Mark. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2012-January/080869.html [2] http://lists.infradead.org/pipermail/linux-a

[PATCH] Add interrupts property to L2x0 OF binding

2011-08-11 Thread Mark Rutland
). Unfortunately the OF binding does not represent the interrupt. This patch adds an "interrupts" property to the L2x0 OF binding, representing the combined interrupt line. Signed-off-by: Mark Rutland Cc: Rob Herring Cc: Grant Likely Cc: Arnd Bergmann Cc: Olof Johansson Cc: Barry

Subject: L2x0 OF properties do not include interrupt #

2011-08-10 Thread Mark Rutland
Hi all, I'm working on a driver for the PMU found in L220/PL310 L2 Cache Controllers (as an extension to the existing L2x0 code). I've taken a look into what BSP support would be required and mocked up some platform_device support, though I notice that Rob Herring has provided devicetree bindings

RE: [PATCH 1/3] ARM: pmu: add OF probing support

2011-06-20 Thread Mark Rutland
Hi, > static int __devinit pmu_device_probe(struct platform_device *pdev) > { > + enum arm_pmu_type type = pdev->id; > > - if (pdev->id < 0 || pdev->id >= ARM_NUM_PMU_DEVICES) { > + if (pdev->dev.of_node) > + type = ARM_PMU_DEVICE_CPU; > + > + if (type < 0 || type >=