Re: [RFC PATCH] CLK: Allow parent clock and rate to be configured in DT.

2013-04-08 Thread Martin Fuzzey
On 07/04/13 15:26, Sascha Hauer wrote: Honestly I'm annoyed by this aswell. The devicetree contains a nice and complete hardware description and it seems convenient to put hardware related configuration data there aswell. Yes The problem is that hardware description and configuration data are

Re: [RFC PATCH] CLK: Allow parent clock and rate to be configured in DT.

2013-04-06 Thread Martin Fuzzey
On Sat, Apr 6, 2013 at 3:21 PM, Tomasz Figa wrote: > Hi, > > [RANT] > > I tend to disagree about this whole hype about device tree usage for other > things than pure hardware description. I don't think device tree should be > a way to force some kind of new world order, but rather a more convenien

Re: [PATCH v2 10/11] ARM i.MX53: Add LDB device to device tree

2013-03-28 Thread Martin Fuzzey
On 28/03/13 08:32, Shawn Guo wrote: On Wed, Mar 27, 2013 at 07:43:40PM +0100, Martin Fuzzey wrote: Maybe pinctrl entries should also be added? Generally, the pinctrl entries should be added in .dts. Yes sorry I meant the pinctrl groups under the iomuxc node. Regards, Martin

Re: [PATCH v2 10/11] ARM i.MX53: Add LDB device to device tree

2013-03-27 Thread Martin Fuzzey
On 27/03/13 18:30, Philipp Zabel wrote: Signed-off-by: Philipp Zabel --- arch/arm/boot/dts/imx53.dtsi | 27 +++ 1 file changed, 27 insertions(+) diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi index b07bbdcc..30aed40 100644 --- a/arch/arm/boot

Re: [PATCH v2 01/11] staging: drm/imx: Add LDB support

2013-03-27 Thread Martin Fuzzey
Hi Philipp, On 27/03/13 18:30, Philipp Zabel wrote: +static bool imx_ldb_encoder_mode_fixup(struct drm_encoder *encoder, + const struct drm_display_mode *mode, + struct drm_display_mode *adjusted_mode) +{ +/* + struct imx_ldb_channel *imx_l

Re: [PATCH 01/11] staging: drm/imx: Add LDB support

2013-03-27 Thread Martin Fuzzey
Hi Philipp, On 26/03/13 15:13, Philipp Zabel wrote: +static void imx_ldb_encoder_disable(struct drm_encoder *encoder) +{ + struct imx_ldb_channel *imx_ldb_ch = enc_to_imx_ldb_ch(encoder); + struct imx_ldb *ldb = imx_ldb_ch->ldb; + + if (gpio_is_valid(imx_ldb_ch->enable_gpio))

Re: [RFC PATCH] CLK: Allow parent clock and rate to be configured in DT.

2013-03-26 Thread Martin Fuzzey
On 25/03/13 14:29, Sascha Hauer wrote: Put it differently. OpenBSD might have much better clock support. Imagine it can dynamically figure out the correct esdhc frequencies for different usecases on the fly. In this situation it would be counterproductive if Linux requires static values for the

Re: [RFC PATCH] CLK: Allow parent clock and rate to be configured in DT.

2013-03-25 Thread Martin Fuzzey
Hi Sascha, thanks for the comments. [corrected Mike's email address - I originally sent it to the old one] On 25/03/13 11:17, Sascha Hauer wrote: On Tue, Mar 19, 2013 at 06:09:33PM +0100, Martin Fuzzey wrote: Even on platforms where the entire clock tree is not represented in the DT i

[RFC PATCH] CLK: Allow parent clock and rate to be configured in DT.

2013-03-19 Thread Martin Fuzzey
specific information and thus would be better in the DT. Signed-off-by: Martin Fuzzey --- Sending as RFC for the moment in a single patch together with an example for i.MX53. Will split if this goes anywhere. --- .../bindings/clock/clock-configuration.txt | 35 + arch/arm/mach-imx

Re: [PATCH 1/2] Drivers: w1: mxc_w1, Add support for DT

2013-02-24 Thread Martin Fuzzey
Hi Markus, I've already submitted basically this and it's in linux-next: http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=28c55dc1acc863cb29832b5be2464ebcdafdc3d5 Also: +Example: + w1: w1@10009000 { + compatible = "fsl,imx27-w1"; +

Re: [PATCH 1/5] W1: Add device tree support to MXC onewire master.

2013-02-03 Thread Martin Fuzzey
On 16/01/13 17:36, Mark Rutland wrote: Hi, This looks nice and simple, I just have a couple of comment. Thank you On Wed, Jan 16, 2013 at 09:48:23AM +, Martin Fuzzey wrote: Signed-off-by: Martin Fuzzey --- drivers/w1/masters/mxc_w1.c |9 - 1 files changed, 8 insertions

Re: [PATCH V2 0/5] W1: Support onewire master on i.MX53

2013-01-22 Thread Martin Fuzzey
On 22/01/13 15:09, Shawn Guo wrote: > On Tue, Jan 22, 2013 at 09:27:12AM +0100, Sascha Hauer wrote: >> On Wed, Jan 16, 2013 at 03:57:49PM +0100, Martin Fuzzey wrote: >>> W1: Support onewire master on i.MX53 >>> * Add device tree and pinctrl support to the MXC master

Re: [PATCH 6/6] usb: chipidea: usbmisc: add post handling and errata fix for mx25

2012-11-15 Thread Martin Fuzzey
> This is because that series is based on Peter Chen's work. I should have > mentioned this in the cover-letter mail. You can merge his master branch > before adding my series: Ok thanks for the very rapid reply. I've now built this together with patch 2 "ci13xxx_imx: add 2nd and 3rd clock to sup

Re: [PATCH 6/6] usb: chipidea: usbmisc: add post handling and errata fix for mx25

2012-11-15 Thread Martin Fuzzey
Hi, On Wed, Nov 14, 2012 at 12:55 PM, Michael Grzeschik wrote: > @@ -213,6 +216,15 @@ static int __devinit ci13xxx_imx_probe(struct > platform_device *pdev) > goto put_np; > } > > + if (usbmisc_ops && usbmisc_ops->post) { > + ret = usbmisc_ops->post(&p