Re: [PATCH v6] net: sh_eth: Add support of device tree probe

2013-04-17 Thread Nobuhiro Iwamatsu
Hi, (2013/04/16 3:52), Sergei Shtylyov wrote: Hello. On 15-04-2013 6:17, Nobuhiro Iwamatsu wrote: This adds support of device tree probe for Renesas sh-ether driver. Signed-off-by: Nobuhiro Iwamatsu V6: - Add renesas,sh-eth-gigabit, renesas,sh-eth-sh4 and renesas,sh-eth-sh3-sh2 to

Re: [PATCH v6] net: sh_eth: Add support of device tree probe

2013-04-14 Thread Nobuhiro Iwamatsu
Hi, (2013/04/15 5:06), Sergei Shtylyov wrote: Hello. On 21-03-2013 11:03, Nobuhiro Iwamatsu wrote: Sorry, I have noticed your reply only last Friday. I probably should do something with my mail filters, so that they leave the personal mail in my inbox and not toss it to the list folders

Re: [PATCH 1/1] iio: exynos-adc: Fix typo in DT documentation

2013-03-26 Thread Nobuhiro Iwamatsu
On Wed, Mar 27, 2013 at 8:55 AM, Naveen Krishna Ch wrote: > On 26 March 2013 04:52, Sachin Kamat wrote: >> Fixes some typos in the documentation of exynos-adc.txt. >> >> Signed-off-by: Sachin Kamat >> --- >> .../devicetree/bindings/arm/samsung/exynos-adc.txt |4 ++-- >> 1 files changed, 2 i

Re: [PATCH v6] net: sh_eth: Add support of device tree probe

2013-03-21 Thread Nobuhiro Iwamatsu
Hi, Thank you for your comment. (2013/03/19 22:22), Sergei Shtylyov wrote: On 19-03-2013 10:39, Nobuhiro Iwamatsu wrote: This adds support of device tree probe for Renesas sh-ether driver. Signed-off-by: Nobuhiro Iwamatsu V6: - Add renesas,sh-eth-gigabit, renesas,sh-eth-sh4 and

[PATCH v6] net: sh_eth: Add support of device tree probe

2013-03-18 Thread Nobuhiro Iwamatsu
This adds support of device tree probe for Renesas sh-ether driver. Signed-off-by: Nobuhiro Iwamatsu V6: - Add renesas,sh-eth-gigabit, renesas,sh-eth-sh4 and renesas,sh-eth-sh3-sh2 to compatible string. - Remove sh-eth,register-type. This is supplemented by the compatible

Re: [PATCHi v2] net: sh_eth: Add support of device tree probe

2013-03-17 Thread Nobuhiro Iwamatsu
Hi, On Sat, Feb 16, 2013 at 1:32 AM, Mark Rutland wrote: > Hello, > > I have a couple of comments on the binding and the way it's parsed. Thank you for your comment. > > On Thu, Feb 14, 2013 at 12:51:31AM +0000, Nobuhiro Iwamatsu wrote: >> This adds support of device

[PATCH v5] net: sh_eth: Add support of device tree probe

2013-03-04 Thread Nobuhiro Iwamatsu
This adds support of device tree probe for Renesas sh-ether driver. Signed-off-by: Nobuhiro Iwamatsu V5: - Rewrite sh_eth_parse_dt(). Remove of_device_is_available() and CONFIG_OF from support OF checking function and re-add empty sh_eth_parse_dt(). - Add CONFIG_PM to definition

Re: [PATCHi v2] net: sh_eth: Add support of device tree probe

2013-03-04 Thread Nobuhiro Iwamatsu
(2013/03/04 17:05), Grant Likely wrote: > On Thu, 14 Feb 2013 11:56:57 +0900, Nobuhiro > Iwamatsu wrote: >> (2013/02/14 10:24), Kuninori Morimoto wrote: >>>> +#ifdef CONFIG_OF >>>> + if (np&& of_device_is_available(np)) { >>&

Re: [PATCH v4] net: sh_eth: Add support of device tree probe

2013-02-26 Thread Nobuhiro Iwamatsu
Hi, Simon. Thanks for the supporting. I understood. Best regards, Nobuhiro (2013/02/16 11:26), Simon Horman wrote: On Fri, Feb 15, 2013 at 10:53:25AM +0900, Nobuhiro Iwamatsu wrote: From: Nobuhiro Iwamatsu This adds support of device tree probe for Renesas sh-ether driver. Hi Iwamatsu

Re: [PATCHi v2] net: sh_eth: Add support of device tree probe

2013-02-26 Thread Nobuhiro Iwamatsu
Hi, Simon. This does not apply yet to upstream. I will send a patch without of_device_is_available function. Best regards, Nobuhiro (2013/02/23 3:49), Simon Horman wrote: On Thu, Feb 14, 2013 at 11:56:57AM +0900, Nobuhiro Iwamatsu wrote: (2013/02/14 10:24), Kuninori Morimoto wrote: Hi

Re: [PATCH v4] net: sh_eth: Add support of device tree probe

2013-02-26 Thread Nobuhiro Iwamatsu
(2013/02/16 0:02), Denis Kirjanov wrote: On 2/15/13, Nobuhiro Iwamatsu wrote: From: Nobuhiro Iwamatsu This adds support of device tree probe for Renesas sh-ether driver. Signed-off-by: Nobuhiro Iwamatsu V4: - Remove empty sh_eth_parse_dt(). V3: - Removed sentnece of "needs-init&

[PATCH v4] net: sh_eth: Add support of device tree probe

2013-02-14 Thread Nobuhiro Iwamatsu
From: Nobuhiro Iwamatsu This adds support of device tree probe for Renesas sh-ether driver. Signed-off-by: Nobuhiro Iwamatsu V4: - Remove empty sh_eth_parse_dt(). V3: - Removed sentnece of "needs-init" from document. V2: - Removed ether_setup(). - Fixed typo from "sh-

Re: [PATCHi v2] net: sh_eth: Add support of device tree probe

2013-02-14 Thread Nobuhiro Iwamatsu
t = tmp->needs_init; >> + } >> + } else >> +#endif > > sh_eth_parse_dt() was defined for both CO NFIG_OF and !CONFIG_OF. > But it is called only from CONFIG_OF ? > Because of_device_is_available depennds CONFIG_OF. I a

Re: [PATCHi v2] net: sh_eth: Add support of device tree probe

2013-02-14 Thread Nobuhiro Iwamatsu
(2013/02/14 10:24), Kuninori Morimoto wrote: Hi Iwamatsu-san Thank you for this patch. Small comment from me +#ifdef CONFIG_OF (snip) +sh_eth_parse_dt(struct device *dev, struct net_device *ndev) +{ + int ret; + struct device_node *np = dev->of_node; + struct sh_eth_plat_

[PATCH v3] net: sh_eth: Add support of device tree probe

2013-02-14 Thread Nobuhiro Iwamatsu
From: Nobuhiro Iwamatsu This adds support of device tree probe for Renesas sh-ether driver. Signed-off-by: Nobuhiro Iwamatsu V3: - Remove empty sh_eth_parse_dt(). V3: - Removed sentnece of "needs-init" from document. V2: - Removed ether_setup(). - Fixed typo from "sh-

[PATCH v3] net: sh_eth: Add support of device tree probe

2013-02-13 Thread Nobuhiro Iwamatsu
This adds support of device tree probe for Renesas sh-ether driver. Signed-off-by: Nobuhiro Iwamatsu V3: - Removed sentnece of "needs-init" from document. V2: - Removed ether_setup(). - Fixed typo from "sh-etn" to "sh-eth". - Removed "needs-init&qu

Re: [PATCHi v2] net: sh_eth: Add support of device tree probe

2013-02-13 Thread Nobuhiro Iwamatsu
On Thu, Feb 14, 2013 at 10:47 AM, Magnus Damm wrote: > Hi Iwamatsu-san, > > On Thu, Feb 14, 2013 at 9:51 AM, Nobuhiro Iwamatsu > wrote: >> This adds support of device tree probe for Renesas sh-ether driver. >> >> Signed-off-by: Nobuhiro Iwamatsu >>

[PATCHi v2] net: sh_eth: Add support of device tree probe

2013-02-13 Thread Nobuhiro Iwamatsu
This adds support of device tree probe for Renesas sh-ether driver. Signed-off-by: Nobuhiro Iwamatsu --- V2: - Removed ether_setup(). - Fixed typo from "sh-etn" to "sh-eth". - Removed "needs-init" and sh-eth,endian from definition of DT.

[PATCH v2] of: Add empty of_device_is_available() function

2013-02-13 Thread Nobuhiro Iwamatsu
This commit adds an empty of_device_is_available() function for !CONFIG_OF builds. Signed-off-by: Nobuhiro Iwamatsu --- V1: Fix email address. include/linux/of.h |5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/of.h b/include/linux/of.h index 5ebcc5c..0be17ad 100644

[PATCH] of: Add empty of_device_is_available() function

2013-02-13 Thread Nobuhiro Iwamatsu
From: Nobuhiro Iwamatsu This commit adds an empty of_device_is_available() function for !CONFIG_OF builds. Signed-off-by: Nobuhiro Iwamatsu --- include/linux/of.h |5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/of.h b/include/linux/of.h index 5ebcc5c..0be17ad 100644

Re: [PATCH] net: sh_eth: Add support of device tree probe

2013-02-11 Thread Nobuhiro Iwamatsu
le-endian" > > then, it is nice. > Then, it can be "Option" properties. OK, I will update. > >> >> +- sh-eth,endian:String, endian of sh_eth dmac. >> > >> > Is this really used it in

Re: [PATCH] net: sh_eth: Add support of device tree probe

2013-02-11 Thread Nobuhiro Iwamatsu
of sh_eth dmac. > > Is this really used it in this driver ? > Yes. In many cases, this uses little-endian, but user may specify big-endian, I think. Best regards, Nobuhiro -- Nobuhiro Iwamatsu ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH] net: sh_eth: Add support of device tree probe

2013-02-11 Thread Nobuhiro Iwamatsu
Hi, On Wed, Feb 6, 2013 at 5:26 PM, Magnus Damm wrote: > Hey Simon, Iwamatsu-san, > > On Wed, Feb 6, 2013 at 11:00 AM, Simon Horman > wrote: >> From: Nobuhiro Iwamatsu >> >> This adds support of device tree probe for Renesas sh-ether driver. >> >> Si

Re: [PATCH] net: sh_eth: Add support of device tree probe

2013-02-11 Thread Nobuhiro Iwamatsu
HI, On Wed, Feb 6, 2013 at 4:30 PM, Denis Kirjanov wrote: > On 2/6/13, Simon Horman wrote: >> From: Nobuhiro Iwamatsu >> >> This adds support of device tree probe for Renesas sh-ether driver. >> >> Signed-off-by: Nobuhiro Iwamatsu >> >>

Re: [PATCH v2 1/3] arm: mvebu: Add support for USB host controllers in Armada 370/XP

2013-02-03 Thread Nobuhiro Iwamatsu
ort for this controller in Armada 370 >>> > and Armada XP SoC common device tree files. >>> > >>> > Cc: Lior Amsalem >>> > Cc: Thomas Petazzoni >>> > Tested-by: Nobuhiro Iwamatsu >>> > Tested-by: Florian Fainelli >

Re: [PATCH 5/6] arm: mvebu: Enable USB controllers on Armada XP OpenBlocks AX3-4 board

2013-02-03 Thread Nobuhiro Iwamatsu
Hi, On Sat, Jan 19, 2013 at 9:11 AM, Gregory CLEMENT wrote: > On 01/19/2013 01:07 AM, Nobuhiro Iwamatsu wrote: >> Hi, >> >> Thomas, Thank you for the detailed explanation. >> >> Ezequiel, I checked your patch on OpenBlocks AX3, work fine. >> >> But I

Re: [PATCH 5/6] arm: mvebu: Enable USB controllers on Armada XP OpenBlocks AX3-4 board

2013-02-03 Thread Nobuhiro Iwamatsu
of the two physical ports is a > combined USB / eSATA port, but I don't think this makes any difference > at the software level. > > I don't have the OpenBlocks AX3-4 with me right now, but I could > probably make a test on Friday. > > Best regards, > > Thomas >

Re: [PATCH 5/6] arm: mvebu: Enable USB controllers on Armada XP OpenBlocks AX3-4 board

2013-02-03 Thread Nobuhiro Iwamatsu
}; > + usb@d0051000 { > + status = "okay"; > + }; > + usb@d0052000 { > + status = "okay"; > + }; USB2 of openblocks-ax3-4 is used as Mini-PCIE. I think this is unnecessary. >