[PATCH v13 5/6] flexcan: Prefer device tree clock frequency if available.

2011-08-16 Thread Robin Holt
If our CAN device's device tree node has a clock-frequency property, then use that value for the can devices clock frequency. If not, fall back to asking the platform/mach code for the clock frequency associated with the flexcan device. Signed-off-by: Robin Holt Acked-by: Wolfgang Grand

[PATCH v13 4/6] flexcan: Add of_match to platform_device definition.

2011-08-16 Thread Robin Holt
On powerpc, the OpenFirmware devices are not matched without specifying an of_match array. Introduce that array as that is used for matching on the Freescale P1010 processor. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger Cc: U Bhaskar-B22300 Cc: Grant

[PATCH v13 3/6] flexcan: Fix up fsl-flexcan device tree binding.

2011-08-16 Thread Robin Holt
This patch cleans up the documentation of the device-tree binding for the Flexcan devices on Freescale's PowerPC and ARM cores. Extra properties are not used by the driver so we are removing them. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde , Acked-by: Wolfgang Grandegger ,

Re: [PATCH v12 3/6] flexcan: Fix up fsl-flexcan device tree binding.

2011-08-15 Thread Robin Holt
On Mon, Aug 15, 2011 at 09:13:50AM -0600, Grant Likely wrote: > On Mon, Aug 15, 2011 at 9:03 AM, Robin Holt wrote: > > Grant, > > > > Earlier, you had asked for a more specific name for the compatible > > property of the Freescale flexcan device.  I still have not

Re: [PATCH v12 3/6] flexcan: Fix up fsl-flexcan device tree binding.

2011-08-15 Thread Robin Holt
believe we have agreement on all the other code changes in these patches. Is this change acceptable as is and if we get a better resolution on the fsl,flexcan name later, we can update the documentation and driver then? Thanks, Robin On Fri, Aug 12, 2011 at 03:45:49AM -0500, Robin Holt wrote

[PATCH v12 5/6] flexcan: Prefer device tree clock frequency if available.

2011-08-12 Thread Robin Holt
If our CAN device's device tree node has a clock-frequency property, then use that value for the can devices clock frequency. If not, fall back to asking the platform/mach code for the clock frequency associated with the flexcan device. Signed-off-by: Robin Holt To: Kumar Gala To: Wol

[PATCH v12 4/6] flexcan: Add of_match to platform_device definition.

2011-08-12 Thread Robin Holt
On powerpc, the OpenFirmware devices are not matched without specifying an of_match array. Introduce that array as that is used for matching on the Freescale P1010 processor. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger Cc: U Bhaskar-B22300 Cc: Grant

[PATCH v12 3/6] flexcan: Fix up fsl-flexcan device tree binding.

2011-08-12 Thread Robin Holt
This patch cleans up the documentation of the device-tree binding for the Flexcan devices on Freescale's PowerPC and ARM cores. Extra properties are not used by the driver so we are removing them. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde , To: Wolfgang Grandegger , To: U Bh

Re: [PATCH v11 3/6] flexcan: Fix up fsl-flexcan device tree binding.

2011-08-12 Thread Robin Holt
On Thu, Aug 11, 2011 at 10:53:43AM -0600, Grant Likely wrote: > On Thu, Aug 11, 2011 at 10:07 AM, Robin Holt wrote: > > +- compatible : Should be "fsl,-flexcan" and "fsl,flexcan" > > Don't do this. "fsl,flexcan" is far too generic. B

[PATCH v11 5/6] flexcan: Prefer device tree clock frequency if available.

2011-08-11 Thread Robin Holt
If our CAN device's device tree node has a clock-frequency property, then use that value for the can devices clock frequency. If not, fall back to asking the platform/mach code for the clock frequency associated with the flexcan device. Signed-off-by: Robin Holt To: Kumar Gala To: Wol

[PATCH v11 4/6] flexcan: Add of_match to platform_device definition.

2011-08-11 Thread Robin Holt
On powerpc, the OpenFirmware devices are not matched without specifying an of_match array. Introduce that array as that is used for matching on the Freescale P1010 processor. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger Cc: U Bhaskar-B22300 Cc: Grant

[PATCH v11 3/6] flexcan: Fix up fsl-flexcan device tree binding.

2011-08-11 Thread Robin Holt
This patch cleans up the documentation of the device-tree binding for the Flexcan devices on Freescale's PowerPC and ARM cores. Extra properties are not used by the driver so we are removing them. Signed-off-by: Robin Holt To: Marc Kleine-Budde , To: Wolfgang Grandegger , To: U Bhaskar-B

Re: [PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 01:40:30PM -0500, Scott Wood wrote: > On 08/10/2011 01:30 PM, Robin Holt wrote: > > On Wed, Aug 10, 2011 at 12:36:22PM -0500, Scott Wood wrote: > >> On 08/10/2011 12:19 PM, Robin Holt wrote: > >>> On Wed, Aug 10, 2011 at 11:56:28AM -0500, Sco

Re: [PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 12:36:22PM -0500, Scott Wood wrote: > On 08/10/2011 12:19 PM, Robin Holt wrote: > > On Wed, Aug 10, 2011 at 11:56:28AM -0500, Scott Wood wrote: > >> On 08/10/2011 11:27 AM, Robin Holt wrote: > >>> -CPI Clock- Can Protocol Interface Clock &g

Re: [PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 11:56:28AM -0500, Scott Wood wrote: > On 08/10/2011 11:27 AM, Robin Holt wrote: > > -CPI Clock- Can Protocol Interface Clock > > - This CLK_SRC bit of CTRL(control register) selects the clock source to > > - the CAN Protocol Interface(CPI) to be

[PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
clock source can not be selected. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde , To: Wolfgang Grandegger , To: U Bhaskar-B22300 To: Scott Wood To: Grant Likely To: Kumar Gala Cc: socketcan-c...@lists.berlios.de, Cc: net...@vger.kernel.org, Cc: PPC list Cc: devicetree-discuss@lists.ozlab

[PATCH v11 3/5] flexcan: Add of_match to platform_device definition.

2011-08-10 Thread Robin Holt
On powerpc, the OpenFirmware devices are not matched without specifying an of_match array. Introduce that array as that is used for matching on the Freescale P1010 processor. Signed-off-by: Robin Holt Acked-by: Marc Kleine-Budde Acked-by: Wolfgang Grandegger Cc: U Bhaskar-B22300 Cc: Grant

Re: [PATCH 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
On Wed, Aug 10, 2011 at 09:52:07AM -0500, Kumar Gala wrote: > > On Aug 9, 2011, at 3:59 PM, Robin Holt wrote: > > > I guess my poor wording may have gotten me in trouble. I am getting > > ready to repost this patch, but I want to ensure I am getting it as > > right as

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Robin Holt
This leaves the most flexibility for segragating future specific revisions of the flexcan interface if needed. 6) I failed to Cc: you or the device tree list when I submitted version 10 of the patches. I have added both to the patch header so they will be included in the next pass.

Re: [PATCH 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-09 Thread Robin Holt
I guess my poor wording may have gotten me in trouble. I am getting ready to repost this patch, but I want to ensure I am getting it as right as possible. I think I should reword the commit message to indicate we are removing the Documentation/.../fsl-flexcan.txt file which has essentially become

Re: [RFC 5/5] [powerpc] Implement a p1010rdb clock source.

2011-08-09 Thread Robin Holt
On Tue, Aug 09, 2011 at 04:03:38PM +0200, Wolfgang Grandegger wrote: > On 08/09/2011 03:44 PM, U Bhaskar-B22300 wrote: > > > > > >> -Original Message----- > >> From: Robin Holt [mailto:h...@sgi.com] > >> Sent: Tuesday, August 09, 2011 7:06 PM > &

Re: [RFC 5/5] [powerpc] Implement a p1010rdb clock source.

2011-08-09 Thread Robin Holt
On Tue, Aug 09, 2011 at 01:44:16PM +, U Bhaskar-B22300 wrote: > > > > -Original Message- > > From: Robin Holt [mailto:h...@sgi.com] > > Sent: Tuesday, August 09, 2011 7:06 PM > > To: Wolfgang Grandegger > > Cc: Robin Holt; U Bhaskar-B22300; sock

Re: [RFC 5/5] [powerpc] Implement a p1010rdb clock source.

2011-08-09 Thread Robin Holt
On Tue, Aug 09, 2011 at 03:03:50PM +0200, Wolfgang Grandegger wrote: > On 08/09/2011 02:49 PM, Robin Holt wrote: > > On Tue, Aug 09, 2011 at 12:41:39PM +, U Bhaskar-B22300 wrote: > >> > >> > >>> -Original Message- > >>> From: Wolfgang

Re: [RFC 5/5] [powerpc] Implement a p1010rdb clock source.

2011-08-09 Thread Robin Holt
On Tue, Aug 09, 2011 at 03:03:50PM +0200, Wolfgang Grandegger wrote: > On 08/09/2011 02:49 PM, Robin Holt wrote: > > On Tue, Aug 09, 2011 at 12:41:39PM +, U Bhaskar-B22300 wrote: > >> > >> > >>> -Original Message- > >>> From: Wolfgang

Re: [RFC 5/5] [powerpc] Implement a p1010rdb clock source.

2011-08-09 Thread Robin Holt
On Tue, Aug 09, 2011 at 12:41:39PM +, U Bhaskar-B22300 wrote: > > > > -Original Message- > > From: Wolfgang Grandegger [mailto:w...@grandegger.com] > > Sent: Tuesday, August 09, 2011 4:19 PM > > To: U Bhaskar-B22300 > > Cc: Marc Kleine-Budde; socketcan-c...@lists.berlios.de; > > net..