Re: [PATCH] usb: phy: samsung: adding usbphy for Exynos4X12

2013-05-13 Thread Vivek Gautam
Hi Dongjin, On Mon, May 13, 2013 at 11:55 PM, Dongjin Kim wrote: > This patch adds usb host phy (USB 2.0 PHY) support for Samsung Exynos4X12 SoC. > New functions, samsung_exynos4x12_usb2phy_enable/_disable and selecting > reference clock, for Exynos4X12 are added. Since it has different register

Re: [PATCH v5 0/3] ARM: Exynos5250: Enabling dwc3-exynos driver

2013-04-03 Thread Vivek Gautam
Hi Kukjin, On Fri, Mar 15, 2013 at 1:32 PM, Vivek Gautam wrote: > This patch-set is in continuation with patch-series: > [PATCH v4 0/4] Enable ehci, ohci and dwc3 devices on exynos5250 > out of which follwowing patches have been picked up: > ARM: Exynos5250: Enabling ehci-s5p

Re: [PATCH v4 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-04-03 Thread Vivek Gautam
Hi Kukjin, On Fri, Mar 15, 2013 at 1:26 PM, Vivek Gautam wrote: > Based on 'for-next' of linux-samsung tree with following patches > from Doug on top: > usb: Document clocks in samsung, exynos4210-ehci/ohci bindings > ARM: dts: add usb 2.0 clock references to exynos525

[PATCH v5 3/3] ARM: exynos5: Enable XHCI support on exynos5

2013-03-15 Thread Vivek Gautam
This patch enables support for XHCI on exynos5 series of SOCs, to support host side USB 3.0 support. Signed-off-by: Vivek Gautam --- arch/arm/mach-exynos/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig

[PATCH v5 2/3] ARM: exynos5250: dts: Enabling dwc3-exynos driver

2013-03-15 Thread Vivek Gautam
Adding DWC3 device tree node for Exynos5250 needed to parse device tree data. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi | 20 ++-- 1 files changed, 18 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts

[PATCH v5 1/3] usb: Add device tree bindings for dwc3-exynos

2013-03-15 Thread Vivek Gautam
Document device tree binding information as required by the Samsung' USB 3.0 controller. Signed-off-by: Vivek Gautam --- .../devicetree/bindings/usb/exynos-usb.txt | 34 1 files changed, 34 insertions(+), 0 deletions(-) diff --git a/Documentation/devic

[PATCH v5 0/3] ARM: Exynos5250: Enabling dwc3-exynos driver

2013-03-15 Thread Vivek Gautam
anges. ;-) - Adding proper binding documentation as per latest bindings changes in dwc3 driver (dwc3/core.c as well as for dwc3-exynos.c change reflected by above patch-set. - Bifurcating the patch to separate our Documentation, arch and dts changes. Vivek Gautam (3): usb: Add device

[PATCH v4 2/2] ARM: Exynos5250: Enabling samsung-usb3phy driver

2013-03-15 Thread Vivek Gautam
Adding usb3.0 phy node for Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot

[PATCH v4 1/2] ARM: Exynos5250: Enabling samsung-usb2phy driver

2013-03-15 Thread Vivek Gautam
Adding usbphy node for Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts

[PATCH v4 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-03-15 Thread Vivek Gautam
TCH v7 0/2] Adding USB 3.0 DRD-phy support for exynos5250 Changes from v3: Added 'clocks' and 'clock-names' entry also in device nodes, aligning with common clock framework for Samsung's SoCs. Vivek Gautam (2): ARM: Exynos5250: Enabling samsung-usb2phy driver ARM: E

Re: [PATCH 2/2] usb: dwc3: exynos: use clk_prepare_enable and clk_disable_unprepare

2013-03-14 Thread Vivek Gautam
Hi, On Thu, Mar 14, 2013 at 4:23 PM, Felipe Balbi wrote: > Hi, > > On Thu, Mar 14, 2013 at 04:14:58PM +0530, Vivek Gautam wrote: >> Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare >> calls as required by common clock framework. >> >> S

[PATCH v2 1/2] usb: dwc3: exynos: Use of_platform API to create dwc3 core pdev

2013-03-14 Thread Vivek Gautam
Used of_platform_populate() to create dwc3 core platform_device from device tree data. Additionally some cleanup is also done. Signed-off-by: Vivek Gautam CC: Felipe Balbi CC: Kukjin Kim --- Changes from v1: - Added method to unregister dwc3 core from dwc3_exynos_remove() using

Re: [PATCH 1/2] usb: dwc3: exynos: Use of_platform API to create dwc3 core pdev

2013-03-14 Thread Vivek Gautam
On Thu, Mar 14, 2013 at 4:21 PM, Felipe Balbi wrote: > Hi, > > On Thu, Mar 14, 2013 at 04:14:57PM +0530, Vivek Gautam wrote: >> @@ -170,7 +155,6 @@ static int dwc3_exynos_remove(struct platform_device >> *pdev) >> { >> struct dwc3_exynos *e

[PATCH 2/2] usb: dwc3: exynos: use clk_prepare_enable and clk_disable_unprepare

2013-03-14 Thread Vivek Gautam
Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework. Signed-off-by: Vivek Gautam CC: Felipe Balbi CC: Kukjin Kim --- drivers/usb/dwc3/dwc3-exynos.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH 1/2] usb: dwc3: exynos: Use of_platform API to create dwc3 core pdev

2013-03-14 Thread Vivek Gautam
Used of_platform_populate() to create dwc3 core platform_device from device tree data. Additionally some cleanup is also done. Signed-off-by: Vivek Gautam CC: Felipe Balbi CC: Kukjin Kim --- drivers/usb/dwc3/dwc3-exynos.c | 46 +--- 1 files changed, 15

[PATCH 0/2] dwc3: exynos: Device tree fixes

2013-03-14 Thread Vivek Gautam
patches in fact ;-), on top of 3.9rc2 tag). Also based on: "usb: dwc3: set dma_mask for dwc3_omap device" by Kishon in which DMA mask for dwc3-core is being set from its parent. Vivek Gautam (2): usb: dwc3: exynos: Use of_platform API to create dwc3 core pdev usb: dwc3: exynos: use clk_

[PATCH v7 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-03-14 Thread Vivek Gautam
Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam Signed-off-by: Felipe Balbi Acked-by: Kukjin Kim --- .../devicetree/bindings/usb/samsung-usbphy.txt | 54 +++ drivers/usb/phy/Kconfig|7 + drivers/us

[PATCH v7 1/2] usb: phy: samsung: Common out the generic stuff

2013-03-14 Thread Vivek Gautam
: Vivek Gautam Signed-off-by: Felipe Balbi Acked-by: Kukjin Kim --- .../devicetree/bindings/usb/samsung-usbphy.txt | 22 +- drivers/usb/phy/Kconfig| 15 +- drivers/usb/phy/Makefile |1 + drivers/usb/phy/phy-samsung-usb.c

[PATCH v7 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-03-14 Thread Vivek Gautam
d on 'usb-next' plus Felipe's 'testing' branch patches; (some 194 patches in fact ;-), on top of 3.9rc2 tag). Tested after merging linux-samsung's 'for-next' into 'usb-next' to verify things with recently merged common clock framework for samsung&

Re: [PATCH v6 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-03-13 Thread Vivek Gautam
Hi Felipe, On Wed, Feb 27, 2013 at 8:13 PM, Vivek Gautam wrote: > Based on 'usb-next' > > Changes from v5: > - Squashed the following change from Felipe in this patch-set: >[PATCH] usb: phy: samsung: let it be built as a module > - Using EXPORT_SYMBOL_GPL() t

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-02-28 Thread Vivek Gautam
Hi, On Thu, Jan 31, 2013 at 9:08 PM, Felipe Balbi wrote: > On Thu, Jan 31, 2013 at 09:00:37PM +0530, Vivek Gautam wrote: >> Hi Felipe, >> >> >> On Thu, Jan 31, 2013 at 8:55 PM, Felipe Balbi wrote: >> > Hi, >> > >> > On Thu, Jan 31, 2013 at 0

[PATCH v6 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-02-27 Thread Vivek Gautam
Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam Signed-off-by: Felipe Balbi Acked-by: Kukjin Kim --- drivers/usb/phy/Kconfig |8 + drivers/usb/phy/Makefile |1 + drivers/usb/phy/samsung-usb3phy.c |

[PATCH v6 1/2] usb: phy: samsung: Common out the generic stuff

2013-02-27 Thread Vivek Gautam
: Vivek Gautam Signed-off-by: Felipe Balbi Acked-by: Kukjin Kim --- drivers/usb/phy/Kconfig | 17 +- drivers/usb/phy/Makefile |1 + drivers/usb/phy/samsung-usb2phy.c | 511 ++ drivers/usb/phy/samsung-usbphy.c | 722

[PATCH v6 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-02-27 Thread Vivek Gautam
Based on 'usb-next' Changes from v5: - Squashed the following change from Felipe in this patch-set: [PATCH] usb: phy: samsung: let it be built as a module - Using EXPORT_SYMBOL_GPL() to export symbols in "samsung-usbphy.c" to allow module builds of these samsung PHY dr

Re: [RESEND PATCH v9 0/2] usb: phy: samsung: Introducing usb phy driver for samsung SoCs

2013-02-27 Thread Vivek Gautam
Hi Balbi, On Wed, Feb 27, 2013 at 1:45 PM, Felipe Balbi wrote: > Hi, > > On Fri, Jan 18, 2013 at 02:30:21PM +0530, Praveen Paneri wrote: >> Changes from v8: >> Resending this patch series after rebasing to the latest usb-next branch. >> Rewording inline comments for better readability. >> Remove

Re: [PATCH v5 1/4] ARM: Exynos5250: Enabling ehci-s5p driver

2013-02-14 Thread Vivek Gautam
On Sat, Feb 9, 2013 at 4:05 AM, Kukjin Kim wrote: > Vivek Gautam wrote: >> >> Adding EHCI device tree node for Exynos5250 along with >> the device base adress and gpio line for vbus. >> >> Signed-off-by: Vivek Gautam >> Acked-by: Jingoo Han >> Acke

Re: [PATCH v5 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-02-13 Thread Vivek Gautam
On Wed, Feb 13, 2013 at 2:02 PM, Felipe Balbi wrote: > On Tue, Feb 12, 2013 at 10:31:00PM -0800, kg...@kernel.org wrote: >> Vivek Gautam wrote: >> > >> > Based on 'usb-next' >> > >> > Changes from v4: >> > - Modifying function nam

[PATCH v3 2/2] ARM: Exynos5250: Enabling samsung-usb3phy driver

2013-02-05 Thread Vivek Gautam
Adding device node for Samsung USB 3.0 PHY controller driver on Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH v3 1/2] ARM: Exynos5250: Enabling samsung-usb2phy driver

2013-02-05 Thread Vivek Gautam
Adding device node for Samsung USB 2.0 PHY controller driver on Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH v3 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-02-05 Thread Vivek Gautam
TCH v8 0/4] Adding usb2.0 host-phy support for exynos5250 - Aligning as per the patch: usb: phy: samsung: Add support to set pmu isolation - Replaced phy-handle approach for PHY CONTROL registers to child nodes. - Removing AUX data entry from exynos5250 dt file. Vivek Gautam (2): ARM:

[PATCH v5 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-02-05 Thread Vivek Gautam
Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam --- drivers/usb/phy/Kconfig |8 + drivers/usb/phy/Makefile |1 + drivers/usb/phy/samsung-usb3phy.c | 349 + drivers/usb/phy/sa

[PATCH v5 1/2] usb: phy: samsung: Common out the generic stuff

2013-02-05 Thread Vivek Gautam
Moving register and structure definitions to header file, and keeping the generic functions to be used across multiple PHYs in common phy helper driver under SAMSUNG_USBPHY, and moving USB 2.0 PHY driver under SAMSUNG_USB2PHY. Signed-off-by: Vivek Gautam --- drivers/usb/phy/Kconfig

[PATCH v5 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-02-05 Thread Vivek Gautam
quot;samsung-usb2phy.c" and, "samsung-usb3.c" to "samsung-usb3phy.c" - Removing dependencies for SAMSUNG_USB2PHY and SAMSUNG_USB3PHY. - Arranging SAMSUNG_USB2PHY and SAMSUNG_USB3PHY to select SAMSUNG_USBPHY, which is the usb-phy helper driver. Vivek Gautam (2): us

Re: [PATCH v4 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-02-04 Thread Vivek Gautam
Hi Kukjin, On Wed, Jan 30, 2013 at 11:31 AM, Kukjin Kim wrote: > Vivek Gautam wrote: >> >> Adding PHY driver support for USB 3.0 controller for Samsung's >> SoCs. >> >> Signed-off-by: Vivek Gautam >> --- >> >> Changes from v3:

Re: [PATCH v4 1/2] usb: phy: samsung: Common out the generic stuff

2013-02-04 Thread Vivek Gautam
Hi Kukjin, On Wed, Jan 30, 2013 at 11:26 AM, Kukjin Kim wrote: > Vivek Gautam wrote: >> >> Moving register and structure definitions to header file, >> and keeping the generic functions to be used across >> multiple PHYs in common file "samsung-usbphy.c". &g

Re: [PATCH v4 2/4] ARM: Exynos5250: Enabling ohci-exynos driver

2013-02-04 Thread Vivek Gautam
Hi Kukjin, On Fri, Feb 1, 2013 at 3:56 AM, Kukjin Kim wrote: > Tomasz Figa wrote: >> >> Hi Vivek, > > [...] > >> > + usb@1212 { >> > + compatible = "samsung,exynos4210-ohci"; >> > + reg = <0x1212 0x100>; >> > + interrupts = <0 71 0>; >> >> For Samsung plat

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-02-01 Thread Vivek Gautam
On Fri, Feb 1, 2013 at 2:20 PM, Felipe Balbi wrote: > On Fri, Feb 01, 2013 at 11:54:01AM +0530, Vivek Gautam wrote: >> Hi Balbi, >> >> >> On Fri, Feb 1, 2013 at 11:52 AM, Vivek Gautam >> wrote: >> > Hi Kishon, >> > >> > &

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-01-31 Thread Vivek Gautam
Hi Balbi, On Fri, Feb 1, 2013 at 11:52 AM, Vivek Gautam wrote: > Hi Kishon, > > > On Fri, Feb 1, 2013 at 10:51 AM, kishon wrote: >> Hi, >> >> >> On Thursday 31 January 2013 09:08 PM, Felipe Balbi wrote: >>> >>> On Thu, Jan 31, 2013 at 09:

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-01-31 Thread Vivek Gautam
Hi Kishon, On Fri, Feb 1, 2013 at 10:51 AM, kishon wrote: > Hi, > > > On Thursday 31 January 2013 09:08 PM, Felipe Balbi wrote: >> >> On Thu, Jan 31, 2013 at 09:00:37PM +0530, Vivek Gautam wrote: >>> >>> Hi Felipe, >>> >>> >>&g

Re: [PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver

2013-01-30 Thread Vivek Gautam
Hi Kukjin, On Wed, Jan 30, 2013 at 10:36 AM, Kukjin Kim wrote: > Vivek Gautam wrote: >> >> Adding usbphy node for Exynos5250 along with the >> necessary device data to be parsed. >> >> Signed-off-by: Vivek Gautam >> --- >> arch/arm/boot/dts/exyno

Re: [PATCH v2 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-01-29 Thread Vivek Gautam
On Tue, Jan 22, 2013 at 9:01 PM, Vivek Gautam wrote: > Changes from v1: > - Putting separate device nodes for usb 2.0 phy and usb 3.0 phy >based on separate driver for samsung usb 3.0 phy and >samsung usb 2.0 phy: >[PATCH v3 0/2] Adding USB 3.0 DRD-phy support

Re: [PATCH v4 3/4] ARM: Exynos5250: Add clock information for dwc3-exynos

2013-01-28 Thread Vivek Gautam
Hi Tomasz, On Wed, Jan 16, 2013 at 8:35 PM, Vivek Gautam wrote: > Hi Tomasz, > > > On Wed, Jan 16, 2013 at 1:19 PM, Tomasz Figa wrote: >> Hi Vivek, >> >> Don't you need also some clkdev lookup entry to make the clock available >> in the driver? >&g

Re: [PATCH v4 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-01-28 Thread Vivek Gautam
CC: Doug Anderson On Mon, Jan 28, 2013 at 3:56 PM, Vivek Gautam wrote: > Adding PHY driver support for USB 3.0 controller for Samsung's > SoCs. > > Signed-off-by: Vivek Gautam > --- > > Changes from v3: > - Making SAMSUNG_USB3PHY dependent on SAMSUNG_US

[PATCH v4 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-01-28 Thread Vivek Gautam
Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam --- Changes from v3: - Making SAMSUNG_USB3PHY dependent on SAMSUNG_USBPHY. - Adding USB_DWC3 to dependencies of SAMSUNG_USB2PHY since dwc3 controller also looks for USB2 type PHY. driver

[PATCH v4 1/2] usb: phy: samsung: Common out the generic stuff

2013-01-28 Thread Vivek Gautam
Moving register and structure definitions to header file, and keeping the generic functions to be used across multiple PHYs in common file "samsung-usbphy.c". Also renaming the usb 2.0 phy driver to "samsung-usb2.c" Signed-off-by: Vivek Gautam --- Changes from v3: - U

Re: [PATCH v2 0/2] usb: exynos: Fix compatible strings used for device

2013-01-24 Thread Vivek Gautam
On Thu, Jan 24, 2013 at 7:15 PM, Vivek Gautam wrote: > Using chip specific compatible string as it should be. > So fixing this for ehci-s5p, ohci-exynos and dwc3-exynos > which till now used a generic 'exynos' in their compatible strings. > > Changes from v1: >

[PATCH v2 2/2] usb: dwc3-exynos: Fix compatible strings for the device

2013-01-24 Thread Vivek Gautam
Using specific chip in compatible strings. Newer SOCs can claim device by using older string in the compatible list. Signed-off-by: Vivek Gautam Acked-by: Grant Likely Reviewed-by: Doug Anderson --- drivers/usb/dwc3/dwc3-exynos.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

[PATCH v2 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device

2013-01-24 Thread Vivek Gautam
Using specific chip in compatible strings. Newer SOCs can claim device by using older string in the compatible list. Signed-off-by: Vivek Gautam Acked-by: Grant Likely Reviewed-by: Doug Anderson --- drivers/usb/host/ehci-s5p.c|2 +- drivers/usb/host/ohci-exynos.c |2 +- 2 files

[PATCH v2 0/2] usb: exynos: Fix compatible strings used for device

2013-01-24 Thread Vivek Gautam
"samsung,exynos5250-dwusb3" as per discussion happened in thread: [PATCH 0/2] usb: exynos: Fix compatible strings used for device. Vivek Gautam (2): usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device usb: dwc3-exynos: Fix compatible strings for the device

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-23 Thread Vivek Gautam
Hi Sylwester, On Wed, Jan 23, 2013 at 6:10 PM, Sylwester Nawrocki wrote: > Hi, > > On 01/23/2013 01:20 PM, Vivek Gautam wrote: >>>>>> - { .compatible = "samsung,exynos-dwc3" }, >>>>>> + { .compatible = "samsung,synopsis-dwc3&q

Re: [PATCH v4 3/4] ARM: Exynos5250: Add clock information for dwc3-exynos

2013-01-23 Thread Vivek Gautam
Hi Tomasz, On Wed, Jan 16, 2013 at 8:35 PM, Vivek Gautam wrote: > Hi Tomasz, > > > On Wed, Jan 16, 2013 at 1:19 PM, Tomasz Figa wrote: >> Hi Vivek, >> >> Don't you need also some clkdev lookup entry to make the clock available >> in the driver? >&g

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-23 Thread Vivek Gautam
Hi all, On Wed, Jan 23, 2013 at 3:20 PM, Felipe Balbi wrote: > Hi, > > On Tue, Jan 22, 2013 at 02:04:56PM -0800, Kukjin Kim wrote: >> Felipe Balbi wrote: >> > Hi, >> > >> Hi Felipe, >> >> [...] >> >> > > Right, DWC has version number, but that being the kind of USB controller >> > > (USB 2.0 and

[PATCH v2 2/2] ARM: Exynos5250: Enabling samsung-usb3-phy driver

2013-01-22 Thread Vivek Gautam
Adding usb3.0 phy node for Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts

[PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver

2013-01-22 Thread Vivek Gautam
Adding usbphy node for Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts

[PATCH v2 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-01-22 Thread Vivek Gautam
- Aligning as per the patch: usb: phy: samsung: Add support to set pmu isolation - Replaced phy-handle approach for PHY CONTROL registers to child nodes. - Removing AUX data entry from exynos5250 dt file. Vivek Gautam (2): ARM: Exynos5250: Enabling samsung-usbphy driver ARM: Exynos5250

[PATCH v8 4/4] USB: ohci-exynos: Add phy driver support

2013-01-22 Thread Vivek Gautam
Adding the phy-driver to ohci-exynos. Keeping the platform data for continuing the smooth operation for boards which still uses it Signed-off-by: Vivek Gautam Acked-by: Jingoo Han Acked-by: Alan Stern Acked-by: Kukjin Kim --- drivers/usb/host/ohci-exynos.c | 84

[PATCH v8 3/4] USB: ehci-s5p: Add phy driver support

2013-01-22 Thread Vivek Gautam
Adding the phy driver to ehci-s5p. Keeping the platform data for continuing the smooth operation for boards which still uses it Signed-off-by: Vivek Gautam Acked-by: Jingoo Han Acked-by: Alan Stern Acked-by: Kukjin Kim --- drivers/usb/host/ehci-s5p.c | 80

[PATCH v8 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-22 Thread Vivek Gautam
This patch adds host phy support to samsung-usbphy driver and further adds support for samsung's exynos5250 usb-phy. Signed-off-by: Praveen Paneri Signed-off-by: Vivek Gautam Acked-by: Kukjin Kim --- .../devicetree/bindings/usb/samsung-usbphy.txt | 12 +- drivers/usb/phy/Kc

[PATCH v8 1/4] ARM: EXYNOS: Update & move usb-phy types to generic include layer

2013-01-22 Thread Vivek Gautam
Updating the names of usb-phy types to more generic names: USB_PHY_TYPE_DEIVCE & USB_PHY_TYPE_HOST; and further update its dependencies. Signed-off-by: Praveen Paneri Signed-off-by: Vivek Gautam Acked-by: Kukjin Kim --- drivers/usb/host/ehci-s5p.c |9 + drivers/usb/

[PATCH v8 0/4] Adding usb2.0 host-phy support for exynos5250

2013-01-22 Thread Vivek Gautam
phy_set_type() and samsung_usbphy_cfg_sel(). - Addressed few nits: -- added macro for 'KHZ' -- removing useless 'if' from samsung_usbphy_cfg_sel() -- keeping the place of clk_get intact and requesting driver data before that. Vivek Gautam (4)

Re: [PATCH v6 0/4] Adding usb2.0 host-phy support for exynos5250

2013-01-22 Thread Vivek Gautam
Hi Felipe, On Tue, Jan 22, 2013 at 3:02 PM, Felipe Balbi wrote: > HI, > > On Tue, Jan 22, 2013 at 11:29:47AM +0200, Felipe Balbi wrote: >> On Tue, Jan 22, 2013 at 02:45:26PM +0530, Vivek Gautam wrote: >> > Hi Felipe, >> > >> > >> > On Tue, Jan

Re: [PATCH v6 0/4] Adding usb2.0 host-phy support for exynos5250

2013-01-22 Thread Vivek Gautam
Hi Felipe, On Tue, Jan 22, 2013 at 2:20 PM, Felipe Balbi wrote: > HI, > > On Mon, Jan 21, 2013 at 09:23:28PM -0800, Kukjin Kim wrote: >> Vivek Gautam wrote: >> > >> > Changes from v5: >> > - Rebased on top of latest patches: >> > usb:

Re: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-01-21 Thread Vivek Gautam
Hi Kukjin, On Tue, Jan 22, 2013 at 10:36 AM, Kukjin Kim wrote: > Felipe Balbi wrote: >> >> On Fri, Jan 18, 2013 at 03:10:13PM +0200, Felipe Balbi wrote: >> > Hi, >> > >> > On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote: >> > &g

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-21 Thread Vivek Gautam
Hi Kukjin, On Tue, Jan 22, 2013 at 11:05 AM, Kukjin Kim wrote: > Sylwester Nawrocki wrote: >> >> On 12/24/2012 09:13 AM, Vivek Gautam wrote: >> >>>> These two changes look good to me. For both of them: >> >>>> >> >>>> Revie

Re: [PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-21 Thread Vivek Gautam
Hi Kukjin, On Fri, Jan 18, 2013 at 8:37 PM, Felipe Balbi wrote: > On Fri, Jan 18, 2013 at 07:59:52PM +0530, Vivek Gautam wrote: >> HI Balbi, >> >> >> On Fri, Jan 18, 2013 at 7:52 PM, Felipe Balbi wrote: >> > On Fri, Jan 18, 2013 at 07:51:08PM +0530,

Re: [PATCH v3 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-01-20 Thread Vivek Gautam
Hi Felipe, On Mon, Jan 14, 2013 at 6:29 PM, Vivek Gautam wrote: > Changes from v2: > - Renaming 'samsung-usbphy.c' driver to 'samsung-usb2.c' indicating >usb 2.0 phy controller's driver for Samsung's SoCs. > - Moving the register definitions and s

Re: [PATCH v6 3/4] USB: ehci-s5p: Add phy driver support

2013-01-18 Thread Vivek Gautam
Hi Alan, On Fri, Jan 18, 2013 at 6:46 PM, Felipe Balbi wrote: > On Fri, Jan 11, 2013 at 08:32:29PM +0530, Vivek Gautam wrote: >> Adding the phy driver to ehci-s5p. Keeping the platform data >> for continuing the smooth operation for boards which still uses it >> >>

Re: [PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-18 Thread Vivek Gautam
HI Balbi, On Fri, Jan 18, 2013 at 7:52 PM, Felipe Balbi wrote: > On Fri, Jan 18, 2013 at 07:51:08PM +0530, Vivek Gautam wrote: >> Hi Felipe, >> >> >> On Fri, Jan 18, 2013 at 6:46 PM, Felipe Balbi wrote: >> > Hi, >> > >> > On Mon, Jan 14, 20

Re: [PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-18 Thread Vivek Gautam
Hi Felipe, On Fri, Jan 18, 2013 at 6:46 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jan 14, 2013 at 05:52:15PM +0530, Vivek Gautam wrote: >> This patch adds host phy support to samsung-usbphy driver and >> further adds support for samsung's exynos5250 usb-phy. >>

Re: [PATCH v7] usb: phy: samsung: Add support to set pmu isolation

2013-01-17 Thread Vivek Gautam
HI Kukjin, On Fri, Jan 18, 2013 at 6:46 AM, Kukjin Kim wrote: > Vivek Gautam wrote: >> >> Adding support to parse device node data in order to get >> required properties to set pmu isolation for usb-phy. >> >> Signed-off-by: Vivek Gautam >> Reviewed-by: S

Re: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information

2013-01-17 Thread Vivek Gautam
Hi Kishon, Thanks for the explanation. On Thu, Jan 17, 2013 at 6:01 PM, kishon wrote: > Hi, > > > On Thursday 17 January 2013 05:41 PM, Vivek Gautam wrote: >> >> Hi Kishon, >> >> >> On Wed, Jan 16, 2013 at 8:30 PM, Kishon Vijay Abraham I >&g

Re: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information

2013-01-17 Thread Vivek Gautam
Hi Kishon, On Wed, Jan 16, 2013 at 8:30 PM, Kishon Vijay Abraham I wrote: > This is in preparation for the changes in PHY library to support adding > and getting multiple PHYs of the same type. In the new design, the > binding information between the PHY and the USB controller should be > specif

Re: [PATCH v4 2/4] ARM: Exynos5250: Enabling ohci-exynos driver

2013-01-16 Thread Vivek Gautam
Hi Tomasz, On Wed, Jan 16, 2013 at 1:14 PM, Tomasz Figa wrote: > Hi Vivek, > > On Tuesday 15 of January 2013 19:08:30 Vivek Gautam wrote: >> Adding OHCI device tree node for Exynos5250 along with >> the device base address. >> >> Signed-off-by: Vivek Gautam >

Re: [PATCH v4 3/4] ARM: Exynos5250: Add clock information for dwc3-exynos

2013-01-16 Thread Vivek Gautam
As far as i could see the lookup structure contains clocks for devices having multiple instances. Do you feel that i should be adding an entry in clk_lookup structure ? May be i am missing here something. Can you please elaborate on the use-case of clk_lookup entries. > > On Tuesday 15 of Jan

[PATCH v5 1/4] ARM: Exynos5250: Enabling ehci-s5p driver

2013-01-15 Thread Vivek Gautam
Adding EHCI device tree node for Exynos5250 along with the device base adress and gpio line for vbus. Signed-off-by: Vivek Gautam Acked-by: Jingoo Han Acked-by: Grant Likely --- Changes from v4: - Added gpio line for VBUS of USB2.0 on snow board. .../devicetree/bindings/usb/exynos-usb.txt

Re: [PATCH v4 1/4] ARM: Exynos5250: Enabling ehci-s5p driver

2013-01-15 Thread Vivek Gautam
On Tue, Jan 15, 2013 at 7:08 PM, Vivek Gautam wrote: > Adding EHCI device tree node for Exynos5250 along with > the device base adress and gpio line for vbus. > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han > Acked-by: Grant Likely > --- > .../devicetree/bin

[PATCH v4 4/4] ARM: Exynos5250: Enabling dwc3-exynos driver

2013-01-15 Thread Vivek Gautam
Adding DWC3 device tree node for Exynos5250 needed to parse device tree data. Also enabling XHCI support on exynos5250. Signed-off-by: Vivek Gautam --- .../devicetree/bindings/usb/exynos-usb.txt | 14 ++ arch/arm/boot/dts/exynos5250.dtsi |6

[PATCH v4 3/4] ARM: Exynos5250: Add clock information for dwc3-exynos

2013-01-15 Thread Vivek Gautam
Adding necessary device clock to exynos5 needed for the DWC3 controller. Signed-off-by: Vivek Gautam --- arch/arm/mach-exynos/clock-exynos5.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/clock-exynos5.c b/arch/arm/mach

[PATCH v4 2/4] ARM: Exynos5250: Enabling ohci-exynos driver

2013-01-15 Thread Vivek Gautam
Adding OHCI device tree node for Exynos5250 along with the device base address. Signed-off-by: Vivek Gautam Acked-by: Jingoo Han Acked-by: Grant Likely --- .../devicetree/bindings/usb/exynos-usb.txt | 15 +++ arch/arm/boot/dts/exynos5250.dtsi |6

[PATCH v4 1/4] ARM: Exynos5250: Enabling ehci-s5p driver

2013-01-15 Thread Vivek Gautam
Adding EHCI device tree node for Exynos5250 along with the device base adress and gpio line for vbus. Signed-off-by: Vivek Gautam Acked-by: Jingoo Han Acked-by: Grant Likely --- .../devicetree/bindings/usb/exynos-usb.txt | 25 arch/arm/boot/dts/exynos5250

[PATCH v4 0/4] Enable ehci, ohci and dwc3 devices on exynos5250

2013-01-15 Thread Vivek Gautam
itted the patch "ARM: Exynos5250: Enabling dwc3-exynos drive" into clock patch and device enabling patch. - Rebased on top of 'for-next' of linux-samsung tree. Vivek Gautam (4): ARM: Exynos5250: Enabling ehci-s5p driver ARM: Exynos5250: Enabling ohci-exynos driver A

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-15 Thread Vivek Gautam
On Thu, Dec 27, 2012 at 4:28 AM, Sylwester Nawrocki wrote: > On 12/24/2012 09:13 AM, Vivek Gautam wrote: >>>>> >>>>> These two changes look good to me. For both of them: >>>>> >>>>> Reviewed-by: Doug Anderson >>>> >

[PATCH v7] usb: phy: samsung: Add support to set pmu isolation

2013-01-14 Thread Vivek Gautam
Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam Reviewed-by: Sylwester Nawrocki Reviewed-by: Doug Anderson --- Changes from v6: - Returning error code in samsung_usbphy_parse_dt() when 'usbph

Re: [PATCH] usb: phy: samsung: Add support to set pmu isolation

2013-01-14 Thread Vivek Gautam
terested bystander in USB land. > ;) > > In general things look pretty good here. :) One last comment below... > > On Fri, Jan 11, 2013 at 12:08 AM, Vivek Gautam > wrote:> +static int > samsung_usbphy_parse_dt(struct samsung_usbphy *sphy) >> +{ >> + struct d

[PATCH v3 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-01-14 Thread Vivek Gautam
Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam --- drivers/usb/phy/Kconfig |8 + drivers/usb/phy/Makefile |1 + drivers/usb/phy/samsung-usb3.c | 349 ++ drivers/usb/phy/sa

[PATCH v3 1/2] usb: phy: samsung: Common out the generic stuff

2013-01-14 Thread Vivek Gautam
Moving register and structure definitions to header file, and keeping the generic functions to be used across multiple PHYs in common file "samsung-usbphy.c". Also renaming the usb 2.0 phy driver to "samsung-usb2.c" Signed-off-by: Vivek Gautam --- drivers/usb/phy/Mak

[PATCH v3 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-01-14 Thread Vivek Gautam
#x27; structure to check if device has usb 3.0 type phy or not. - Restructuring probe sequence for USB 3.0 phy, such that we are initializing only when device has usb3.0 type phy. Vivek Gautam (2): usb: phy: samsung: Common out the generic stuff usb: phy: samsung: Add PHY support

[PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-14 Thread Vivek Gautam
This patch adds host phy support to samsung-usbphy driver and further adds support for samsung's exynos5250 usb-phy. Signed-off-by: Praveen Paneri Signed-off-by: Vivek Gautam --- Changes from v6: - Changing macro names from 'HOST_CTRL0_FSEL_CLKSEL_XX' to 'FSEL_CLKSEL_XX&

Re: [PATCH v5 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-14 Thread Vivek Gautam
Hi Doug, On Mon, Jan 14, 2013 at 11:15 AM, Vivek Gautam wrote: > Hi Doug, > > > On Sat, Jan 12, 2013 at 6:20 AM, Doug Anderson wrote: >> Vivek, >> >> On Fri, Jan 11, 2013 at 4:40 AM, Vivek Gautam >> wrote: >>>>> +#define HOST_CTR

Re: [PATCH v5 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-13 Thread Vivek Gautam
Hi Doug, On Sat, Jan 12, 2013 at 6:20 AM, Doug Anderson wrote: > Vivek, > > On Fri, Jan 11, 2013 at 4:40 AM, Vivek Gautam > wrote: >>>> +#define HOST_CTRL0_REFCLKSEL_MASK (0x3) >>>> +#define HOST_CTRL0_REFCLKSEL_XTAL

[PATCH v6 4/4] USB: ohci-exynos: Add phy driver support

2013-01-11 Thread Vivek Gautam
Adding the phy-driver to ohci-exynos. Keeping the platform data for continuing the smooth operation for boards which still uses it Signed-off-by: Vivek Gautam Acked-by: Jingoo Han --- drivers/usb/host/ohci-exynos.c | 84 ++-- 1 files changed, 63 insertions

[PATCH v6 3/4] USB: ehci-s5p: Add phy driver support

2013-01-11 Thread Vivek Gautam
Adding the phy driver to ehci-s5p. Keeping the platform data for continuing the smooth operation for boards which still uses it Signed-off-by: Vivek Gautam Acked-by: Jingoo Han --- drivers/usb/host/ehci-s5p.c | 80 +++--- 1 files changed, 59 insertions

[PATCH v6 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-11 Thread Vivek Gautam
This patch adds host phy support to samsung-usbphy driver and further adds support for samsung's exynos5250 usb-phy. Signed-off-by: Praveen Paneri Signed-off-by: Vivek Gautam --- .../devicetree/bindings/usb/samsung-usbphy.txt | 12 +- drivers/usb/phy/Kc

[PATCH v6 1/4] ARM: EXYNOS: Update & move usb-phy types to generic include layer

2013-01-11 Thread Vivek Gautam
Updating the names of usb-phy types to more generic names: USB_PHY_TYPE_DEIVCE & USB_PHY_TYPE_HOST; and further update its dependencies. Signed-off-by: Praveen Paneri Signed-off-by: Vivek Gautam --- Changes from v5: - None drivers/usb/host/ehci-s5p.c |9 + dri

[PATCH v6 0/4] Adding usb2.0 host-phy support for exynos5250

2013-01-11 Thread Vivek Gautam
from samsung_usbphy_cfg_sel() -- keeping the place of clk_get intact and requesting driver data before that. Vivek Gautam (4): ARM: EXYNOS: Update & move usb-phy types to generic include layer usb: phy: samsung: Add host phy support to samsung-phy driver USB: ehci-s5p: Add phy driv

Re: [PATCH v5 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-11 Thread Vivek Gautam
Hi Felipe, On Fri, Jan 11, 2013 at 6:28 PM, Felipe Balbi wrote: > Hi, > > On Fri, Jan 11, 2013 at 06:10:48PM +0530, Vivek Gautam wrote: >> Hi Doug, >> >> Sorry!! for the delayed response. >> >> >> On Thu, Dec 20, 2012 at 4:31 AM, Doug Anderson wro

Re: [PATCH v5 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-11 Thread Vivek Gautam
Hi Doug, Sorry!! for the delayed response. On Thu, Dec 20, 2012 at 4:31 AM, Doug Anderson wrote: > Vivek, > > I don't really have a good 1 foot view about how all of the USB > bits fit together, but a few detail-oriented comments below. > > > On Tue, Dec 18, 201

Re: [PATCH] usb: phy: samsung: Add support to set pmu isolation

2013-01-11 Thread Vivek Gautam
Hi Sylwester, On Fri, Jan 11, 2013 at 2:51 PM, Sylwester Nawrocki wrote: > On 01/11/2013 09:08 AM, Vivek Gautam wrote: >> Adding support to parse device node data in order to get >> required properties to set pmu isolation for usb-phy. >> >> Signed-off-by: V

[PATCH] usb: phy: samsung: Add support to set pmu isolation

2013-01-11 Thread Vivek Gautam
Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam --- Changes from v5: - Using a global spin_lock member in 'samsung_usbphy' structure to be used in samsung_usbphy_init() and samsung_usbph

Re: [PATCH v5] usb: phy: samsung: Add support to set pmu isolation

2013-01-10 Thread Vivek Gautam
Hi Sylwester, On Thu, Jan 10, 2013 at 3:12 AM, Sylwester Nawrocki wrote: > Hi, > > > On 12/28/2012 10:13 AM, Vivek Gautam wrote: >> >> Adding support to parse device node data in order to get >> required properties to set pmu isolation for usb-phy. >

  1   2   3   >