Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Kishon Vijay Abraham I
is going to cause big problems. Use pointers, this is C, we are supposed to be doing that :) Kishon, I think what Greg means is this: The name you are using must be stored somewhere in a data structure constructed by the board file, right? Or at least, associated with some data structure someh

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-19 Thread Kishon Vijay Abraham I
Hi, On Saturday 20 July 2013 05:20 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 12:06:01PM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:59 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:25:44AM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:13 AM

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-19 Thread Kishon Vijay Abraham I
Hi, On Friday 19 July 2013 09:24 PM, Stephen Warren wrote: On 07/19/2013 12:36 AM, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:59 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:25:44AM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:13 AM, Greg KH wrote

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Kishon Vijay Abraham I
Hi, On Friday 19 July 2013 11:59 AM, Greg KH wrote: > On Fri, Jul 19, 2013 at 11:25:44AM +0530, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Friday 19 July 2013 11:13 AM, Greg KH wrote: >>> On Fri, Jul 19, 2013 at 11:07:10AM +0530, Kishon Vijay Abraham I wrote: >

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Kishon Vijay Abraham I
Hi, On Friday 19 July 2013 11:13 AM, Greg KH wrote: > On Fri, Jul 19, 2013 at 11:07:10AM +0530, Kishon Vijay Abraham I wrote: >>>>>> +ret = dev_set_name(&phy->dev, "%s.%d", dev_name(dev), id); >>>>> >>>>> Your naming is

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Kishon Vijay Abraham I
Hi, On Thursday 18 July 2013 09:19 PM, Greg KH wrote: > On Thu, Jul 18, 2013 at 02:29:52PM +0530, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Thursday 18 July 2013 12:50 PM, Greg KH wrote: >>> On Thu, Jul 18, 2013 at 12:16:10PM +0530, Kishon Vijay Abraham I wr

Re: [PATCH 02/15] usb: phy: omap-usb2: use the new generic PHY framework

2013-07-18 Thread Kishon Vijay Abraham I
On Thursday 18 July 2013 12:51 PM, Greg KH wrote: > On Thu, Jul 18, 2013 at 12:16:11PM +0530, Kishon Vijay Abraham I wrote: >> Used the generic PHY framework API to create the PHY. Now the power off and >> power on are done in omap_usb_power_off and omap_usb_power_on respectively

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Kishon Vijay Abraham I
Hi, On Thursday 18 July 2013 12:50 PM, Greg KH wrote: > On Thu, Jul 18, 2013 at 12:16:10PM +0530, Kishon Vijay Abraham I wrote: >> +struct phy_provider *__of_phy_provider_register(struct device *dev, >> +struct module *owner, struct phy * (*of_xlate)(struct device *dev,

[PATCH 11/15] exynos4-is: Use the generic MIPI CSIS PHY driver

2013-07-17 Thread Kishon Vijay Abraham I
Acked-by: Felipe Balbi Acked-by: Mauro Carvalho Chehab Signed-off-by: Kishon Vijay Abraham I --- drivers/media/platform/exynos4-is/mipi-csis.c | 16 +--- include/linux/platform_data/mipi-csis.h | 11 ++- 2 files changed, 15 insertions(+), 12 deletions(-) diff --git

[PATCH 14/15] video: exynos_dp: remove non-DT support for Exynos Display Port

2013-07-17 Thread Kishon Vijay Abraham I
nt of file include/video/exynos_dp.h is moved to drivers/video/exynos/exynos_dp_core.h. Thus, the 'exynos_dp.h' file is removed. Also, 'struct exynos_dp_platdata' is removed, because it is not used any more. Signed-off-by: Jingoo Han Reviewed-by: Tomasz Figa Signed-

[PATCH 13/15] phy: Add driver for Exynos DP PHY

2013-07-17 Thread Kishon Vijay Abraham I
From: Jingoo Han Add a PHY provider driver for the Samsung Exynos SoC Display Port PHY. Signed-off-by: Jingoo Han Reviewed-by: Tomasz Figa Cc: Sylwester Nawrocki Acked-by: Felipe Balbi Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/phy/samsung-phy.txt|8

[PATCH 15/15] video: exynos_dp: Use the generic PHY driver

2013-07-17 Thread Kishon Vijay Abraham I
From: Jingoo Han Use the generic PHY API to control the DP PHY. Signed-off-by: Jingoo Han Reviewed-by: Tomasz Figa Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/video/exynos_dp.txt | 18 +- drivers/video/exynos/exynos_dp_core.c

[PATCH 12/15] ARM: Samsung: Remove the MIPI PHY setup code

2013-07-17 Thread Kishon Vijay Abraham I
to bind the PHYs to respective PHY consumer drivers and a platform device for the PHY provider should be defined. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park Acked-by: Felipe Balbi Acked-by: Kukjin Kim Signed-off-by: Kishon Vijay Abraham I --- arch/arm/mach-exynos/include

[PATCH 07/15] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2

2013-07-17 Thread Kishon Vijay Abraham I
Now that omap-usb2 is adapted to the new generic PHY framework, *set_suspend* ops can be removed from omap-usb2 driver. Signed-off-by: Kishon Vijay Abraham I Acked-by: Felipe Balbi Reviewed-by: Sylwester Nawrocki --- drivers/usb/phy/phy-omap-usb2.c | 25 - 1 file

[PATCH 10/15] video: exynos_mipi_dsim: Use the generic PHY driver

2013-07-17 Thread Kishon Vijay Abraham I
Acked-by: Felipe Balbi Acked-by: Donghwa Lee Signed-off-by: Kishon Vijay Abraham I --- drivers/video/exynos/exynos_mipi_dsi.c | 19 ++- include/video/exynos_mipi_dsim.h |6 -- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/vi

[PATCH 08/15] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops

2013-07-17 Thread Kishon Vijay Abraham I
Now that twl4030-usb is adapted to the new generic PHY framework, *set_suspend* and *phy_init* ops can be removed from twl4030-usb driver. Signed-off-by: Kishon Vijay Abraham I Acked-by: Felipe Balbi Reviewed-by: Sylwester Nawrocki --- drivers/usb/phy/phy-twl4030-usb.c | 57

[PATCH 09/15] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-07-17 Thread Kishon Vijay Abraham I
From: Sylwester Nawrocki Add a PHY provider driver for the Samsung S5P/Exynos SoC MIPI CSI-2 receiver and MIPI DSI transmitter DPHYs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park Acked-by: Felipe Balbi Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/phy

[PATCH 06/15] usb: musb: omap2430: use the new generic PHY framework

2013-07-17 Thread Kishon Vijay Abraham I
te state machine to handle otg, these can be moved out of xceiv and then we can start using the generic PHY framework. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Sylwester Nawrocki Acked-by: Felipe Balbi --- drivers/usb/musb/Kconfig |1 + drivers/usb/musb/musb_core.c |1 + dri

[PATCH 04/15] ARM: OMAP: USB: Add phy binding information

2013-07-17 Thread Kishon Vijay Abraham I
In order for controllers to get PHY in case of non dt boot, the phy binding information (phy device name) should be added in the platform data of the controller. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Sylwester Nawrocki Acked-by: Felipe Balbi --- arch/arm/mach-omap2/usb-musb.c

[PATCH 05/15] ARM: dts: omap: update usb_otg_hs data

2013-07-17 Thread Kishon Vijay Abraham I
-bindings.txt Signed-off-by: Kishon Vijay Abraham I Acked-by: Felipe Balbi Reviewed-by: Sylwester Nawrocki --- Documentation/devicetree/bindings/usb/omap-usb.txt |5 + Documentation/devicetree/bindings/usb/usb-phy.txt |6 ++ arch/arm/boot/dts/omap3-beagle-xm.dts |2

[PATCH 00/15] PHY framework

2013-07-17 Thread Kishon Vijay Abraham I
os DP PHY video: exynos_dp: remove non-DT support for Exynos Display Port video: exynos_dp: Use the generic PHY driver Kishon Vijay Abraham I (8): drivers: phy: add generic PHY framework usb: phy: omap-usb2: use the new generic PHY framework usb: phy: twl4030: use the new generic PHY fram

[PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-17 Thread Kishon Vijay Abraham I
Signed-off-by: Kishon Vijay Abraham I Acked-by: Felipe Balbi Tested-by: Sylwester Nawrocki --- .../devicetree/bindings/phy/phy-bindings.txt | 66 +++ Documentation/phy.txt | 129 + MAINTAINERS|7 + drivers/Kconfig

[PATCH 02/15] usb: phy: omap-usb2: use the new generic PHY framework

2013-07-17 Thread Kishon Vijay Abraham I
OTG. Once we have a separate OTG state machine, we can get rid of the USB PHY library. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Sylwester Nawrocki Acked-by: Felipe Balbi --- drivers/usb/phy/Kconfig |1 + drivers/usb/phy/phy-omap-usb2.c | 45

[PATCH 03/15] usb: phy: twl4030: use the new generic PHY framework

2013-07-17 Thread Kishon Vijay Abraham I
be completely removed because otg is intertwined with phy and moving to the new framework completely will break otg. Once we have a separate otg state machine, we can get rid of the usb phy library. Signed-off-by: Kishon Vijay Abraham I Acked-by: Felipe Balbi Reviewed-by: Sylwester Nawrocki

Re: [PATCH v9 1/8] drivers: phy: add generic PHY framework

2013-07-17 Thread Kishon Vijay Abraham I
On Thursday 18 July 2013 11:54 AM, Greg KH wrote: > On Thu, Jul 18, 2013 at 11:33:17AM +0530, Kishon Vijay Abraham I wrote: >>>> Wanted to group all the PHY drivers to be used by different subsystems >>>> (SATA/USB/PCIE/HDMI/VIDEO) into a single entity. There wer

Re: [PATCH v9 1/8] drivers: phy: add generic PHY framework

2013-07-17 Thread Kishon Vijay Abraham I
Hi, On Wednesday 17 July 2013 10:55 PM, Greg KH wrote: > On Wed, Jul 17, 2013 at 03:02:59PM +0530, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Wednesday 17 July 2013 11:59 AM, Greg KH wrote: >>> On Wed, Jun 26, 2013 at 05:17:29PM +0530, Kishon Vijay Abraham I wrote

Re: [PATCH v9 1/8] drivers: phy: add generic PHY framework

2013-07-17 Thread Kishon Vijay Abraham I
Hi, On Wednesday 17 July 2013 11:59 AM, Greg KH wrote: > On Wed, Jun 26, 2013 at 05:17:29PM +0530, Kishon Vijay Abraham I wrote: >> +menuconfig GENERIC_PHY >> +tristate "PHY Subsystem" >> +help >> + Generic PHY support. >> + >> +

[PATCH v6] usb: dwc3: use extcon fwrk to receive connect/disconnect

2013-07-15 Thread Kishon Vijay Abraham I
Modified dwc3-omap to receive connect and disconnect notification using extcon framework. Also did the necessary cleanups required after adapting to extcon framework. Signed-off-by: Kishon Vijay Abraham I Acked-by: Felipe Balbi Acked-by: Chanwoo Choi --- This patch should be applied after all

Re: [PATCH v9 0/8] Generic PHY Framework

2013-07-08 Thread Kishon Vijay Abraham I
Hi, On Monday 08 July 2013 04:54 PM, Patel, Satish wrote: Hi, -Original Message- From: Balbi, Felipe Sent: Thursday, July 04, 2013 3:42 PM To: ABRAHAM, KISHON VIJAY Cc: Patel, Satish; Balbi, Felipe; grant.lik...@linaro.org; t...@atomide.com; a...@arndb.de; swar...@nvidia.com

Re: [PATCH v9 0/8] Generic PHY Framework

2013-07-04 Thread Kishon Vijay Abraham I
On Thursday 04 July 2013 02:51 PM, Patel, Satish wrote: Hi, -Original Message- From: Balbi, Felipe Sent: Wednesday, July 03, 2013 6:51 PM To: ABRAHAM, KISHON VIJAY Cc: Patel, Satish; grant.lik...@linaro.org; t...@atomide.com; Balbi, Felipe; a...@arndb.de; swar...@nvidia.com

Re: [PATCH v9 0/8] Generic PHY Framework

2013-07-03 Thread Kishon Vijay Abraham I
Hi, On Wednesday 03 July 2013 06:50 PM, Felipe Balbi wrote: Hi, On Wed, Jul 03, 2013 at 03:35:39PM +0530, Kishon Vijay Abraham I wrote: On Wednesday 03 July 2013 03:02 PM, Patel, Satish wrote: Hi Kishon, -Original Message- From: ABRAHAM, KISHON VIJAY Sent: Wednesday, June 26, 2013

Re: [PATCH v9 0/8] Generic PHY Framework

2013-07-03 Thread Kishon Vijay Abraham I
Hi, On Wednesday 03 July 2013 03:02 PM, Patel, Satish wrote: Hi Kishon, -Original Message- From: ABRAHAM, KISHON VIJAY Sent: Wednesday, June 26, 2013 5:17 PM To: grant.lik...@linaro.org; t...@atomide.com; Balbi, Felipe; ABRAHAM, KISHON VIJAY; a...@arndb.de; swar...@nvidia.com

Re: [PATCH V3 3/3] video: exynos_dp: Use the generic PHY driver

2013-06-30 Thread Kishon Vijay Abraham I
rn ret; -} - -static void exynos_dp_phy_init(struct exynos_dp_device *dp) -{ - u32 reg; - - reg = __raw_readl(dp->phy_addr); - reg |= dp->enable_mask; - __raw_writel(reg, dp->phy_addr); -} - -static void exynos_dp_phy_exit(struct exynos_dp_device *dp) -{ - u32

Re: [PATCH v3 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-30 Thread Kishon Vijay Abraham I
Hi, On Sunday 30 June 2013 01:04 AM, Sylwester Nawrocki wrote: Hi, On 06/29/2013 10:57 AM, Kishon Vijay Abraham I wrote: On Friday 28 June 2013 03:41 PM, Sylwester Nawrocki wrote: On 06/28/2013 10:17 AM, Hui Wang wrote: On 06/26/2013 11:02 PM, Sylwester Nawrocki wrote: Add a PHY provider

Re: [PATCH V2 1/3] phy: Add driver for Exynos DP PHY

2013-06-29 Thread Kishon Vijay Abraham I
ready protected by a mutex. + struct phy *phys; _phys_ no longer need to part of this structure. + void __iomem *regs; +}; Thanks Kishon ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v3 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-29 Thread Kishon Vijay Abraham I
ation helpers. So I'll replace it with plain spin_lock/unlock. Thank you for the review. Now that PHY ops is already protected, do you really need a spin_lock here? Thanks Kishon ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.o

Re: [PATCH 1/3] phy: Add driver for Exynos DP PHY

2013-06-28 Thread Kishon Vijay Abraham I
,exynos5250-dp-video-phy.txt How about creating a single Documentation file for all samsung video phys? Sylwester? Thanks Kishon ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree

Re: [PATCH 3/3] video: exynos_dp: Use the generic PHY driver

2013-06-28 Thread Kishon Vijay Abraham I
Hi, On Friday 28 June 2013 11:34 AM, Jingoo Han wrote: On Friday, June 28, 2013 2:58 PM, Kishon Vijay Abraham I wrote: Hi, On Friday 28 June 2013 10:54 AM, Jingoo Han wrote: Use the generic PHY API instead of the platform callback to control the DP PHY. The 'phy_label' field is ad

Re: [PATCH 1/3] phy: Add driver for Exynos DP PHY

2013-06-27 Thread Kishon Vijay Abraham I
Hi, On Friday 28 June 2013 11:24 AM, Jingoo Han wrote: On Friday, June 28, 2013 2:31 PM, Kishon Vijay Abraham I wrote: Hi, On Friday 28 June 2013 10:52 AM, Jingoo Han wrote: Add a PHY provider driver for the Samsung Exynos SoC DP PHY. Signed-off-by: Jingoo Han --- .../phy/samsung

Re: [PATCH 3/3] video: exynos_dp: Use the generic PHY driver

2013-06-27 Thread Kishon Vijay Abraham I
- -static void exynos_dp_phy_init(struct exynos_dp_device *dp) -{ - u32 reg; - - reg = __raw_readl(dp->phy_addr); - reg |= dp->enable_mask; - __raw_writel(reg, dp->phy_addr); -} - -static void exynos_dp_phy_exit(struct exynos_dp_

Re: [PATCH 2/3] ARM: dts: Add DP PHY node to exynos5250.dtsi

2013-06-27 Thread Kishon Vijay Abraham I
50-dp-video-phy"; + reg = <0x10040720 4>; + #phy-cells = <1>; phy-cells can be '0' here since this phy_provider implements only one PHY. Thanks Kishon ___ devicetree-discuss mailing list dev

Re: [PATCH 1/3] phy: Add driver for Exynos DP PHY

2013-06-27 Thread Kishon Vijay Abraham I
{ + .of_match_table = exynos_dp_video_phy_of_match, + .name = "exynos-dp-video-phy", + .owner = THIS_MODULE, + } +}; +module_platform_driver(exynos_dp_video_phy_driver); + +MODULE_DESCRIPTION("Samsung EXYNOS SoC DP PHY driver"); +MODULE_

Re: [PATCH v9 1/8] drivers: phy: add generic PHY framework

2013-06-27 Thread Kishon Vijay Abraham I
On Friday 28 June 2013 08:57 AM, Jingoo Han wrote: On Wed, 26 Jun 2013 17:17:29 +0530, Kishon Vijay Abraham Iwrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. For

Re: [PATCH v2 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-26 Thread Kishon Vijay Abraham I
On Wednesday 26 June 2013 05:52 PM, Felipe Balbi wrote: On Wed, Jun 26, 2013 at 02:03:42PM +0200, Sylwester Nawrocki wrote: On 06/26/2013 01:21 PM, Kishon Vijay Abraham I wrote: +static int exynos_video_phy_probe(struct platform_device *pdev) +{ + struct exynos_video_phy *state

Re: [PATCH v2 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-26 Thread Kishon Vijay Abraham I
On Wednesday 26 June 2013 05:33 PM, Sylwester Nawrocki wrote: On 06/26/2013 01:21 PM, Kishon Vijay Abraham I wrote: +static int exynos_video_phy_probe(struct platform_device *pdev) +{ + struct exynos_video_phy *state; + struct device *dev = &pdev->dev; + struct resour

[PATCH v9 7/8] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2

2013-06-26 Thread Kishon Vijay Abraham I
Now that omap-usb2 is adapted to the new generic PHY framework, *set_suspend* ops can be removed from omap-usb2 driver. Signed-off-by: Kishon Vijay Abraham I Acked-by: Felipe Balbi Reviewed-by: Sylwester Nawrocki --- drivers/usb/phy/phy-omap-usb2.c | 25 - 1 file

[PATCH v9 4/8] ARM: OMAP: USB: Add phy binding information

2013-06-26 Thread Kishon Vijay Abraham I
In order for controllers to get PHY in case of non dt boot, the phy binding information (phy device name) should be added in the platform data of the controller. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Sylwester Nawrocki Acked-by: Felipe Balbi --- arch/arm/mach-omap2/usb-musb.c

[PATCH v9 5/8] ARM: dts: omap: update usb_otg_hs data

2013-06-26 Thread Kishon Vijay Abraham I
-bindings.txt Signed-off-by: Kishon Vijay Abraham I Acked-by: Felipe Balbi Reviewed-by: Sylwester Nawrocki --- Documentation/devicetree/bindings/usb/omap-usb.txt |5 + Documentation/devicetree/bindings/usb/usb-phy.txt |6 ++ arch/arm/boot/dts/omap3-beagle-xm.dts |2

[PATCH v9 8/8] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops

2013-06-26 Thread Kishon Vijay Abraham I
Now that twl4030-usb is adapted to the new generic PHY framework, *set_suspend* and *phy_init* ops can be removed from twl4030-usb driver. Signed-off-by: Kishon Vijay Abraham I Acked-by: Felipe Balbi Reviewed-by: Sylwester Nawrocki --- drivers/usb/phy/phy-twl4030-usb.c | 57

[PATCH v9 6/8] usb: musb: omap2430: use the new generic PHY framework

2013-06-26 Thread Kishon Vijay Abraham I
te state machine to handle otg, these can be moved out of xceiv and then we can start using the generic PHY framework. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Sylwester Nawrocki Acked-by: Felipe Balbi --- drivers/usb/musb/Kconfig |1 + drivers/usb/musb/musb_core.c |1 + dri

[PATCH v9 2/8] usb: phy: omap-usb2: use the new generic PHY framework

2013-06-26 Thread Kishon Vijay Abraham I
OTG. Once we have a separate OTG state machine, we can get rid of the USB PHY library. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Sylwester Nawrocki Acked-by: Felipe Balbi --- drivers/usb/phy/Kconfig |1 + drivers/usb/phy/phy-omap-usb2.c | 45

[PATCH v9 3/8] usb: phy: twl4030: use the new generic PHY framework

2013-06-26 Thread Kishon Vijay Abraham I
be completely removed because otg is intertwined with phy and moving to the new framework completely will break otg. Once we have a separate otg state machine, we can get rid of the usb phy library. Signed-off-by: Kishon Vijay Abraham I Acked-by: Felipe Balbi Reviewed-by: Sylwester Nawrocki

[PATCH v9 0/8] Generic PHY Framework

2013-06-26 Thread Kishon Vijay Abraham I
* Modified omap-usb2 and twl4030 to make use of the new framework Did USB enumeration testing in panda and beagle. Kishon Vijay Abraham I (8): drivers: phy: add generic PHY framework usb: phy: omap-usb2: use the new generic PHY framework usb: phy: twl4030: use the new generic PHY framework

[PATCH v9 1/8] drivers: phy: add generic PHY framework

2013-06-26 Thread Kishon Vijay Abraham I
Signed-off-by: Kishon Vijay Abraham I Tested-by: Sylwester Nawrocki --- .../devicetree/bindings/phy/phy-bindings.txt | 66 +++ Documentation/phy.txt | 129 + MAINTAINERS|7 + drivers/Kconfig

Re: [PATCH v2 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-26 Thread Kishon Vijay Abraham I
be used by phy provider drivers. So after creating the PHY, the phy provider should use phy_set_drvdata and in phy_ops, it can use phy_get_drvdata. (I'll remove the dev_set_drvdata in phy_create). This also means _void *priv_ in phy_create is useless. So I'll be removing _priv_ from phy

[PATCH v8 8/8] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops

2013-06-24 Thread Kishon Vijay Abraham I
Now that twl4030-usb is adapted to the new generic PHY framework, *set_suspend* and *phy_init* ops can be removed from twl4030-usb driver. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Felipe Balbi Reviewed-by: Sylwester Nawrocki --- drivers/usb/phy/phy-twl4030-usb.c | 57

[PATCH v8 7/8] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2

2013-06-24 Thread Kishon Vijay Abraham I
Now that omap-usb2 is adapted to the new generic PHY framework, *set_suspend* ops can be removed from omap-usb2 driver. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Felipe Balbi Reviewed-by: Sylwester Nawrocki --- drivers/usb/phy/phy-omap-usb2.c | 25 - 1 file

[PATCH v8 5/8] ARM: dts: omap: update usb_otg_hs data

2013-06-24 Thread Kishon Vijay Abraham I
-bindings.txt Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Felipe Balbi Reviewed-by: Sylwester Nawrocki --- Documentation/devicetree/bindings/usb/omap-usb.txt |5 + Documentation/devicetree/bindings/usb/usb-phy.txt |6 ++ arch/arm/boot/dts/omap3-beagle-xm.dts |2

[PATCH v8 3/8] usb: phy: twl4030: use the new generic PHY framework

2013-06-24 Thread Kishon Vijay Abraham I
be completely removed because otg is intertwined with phy and moving to the new framework completely will break otg. Once we have a separate otg state machine, we can get rid of the usb phy library. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Felipe Balbi Reviewed-by: Sylwester Nawrocki

[PATCH v8 4/8] ARM: OMAP: USB: Add phy binding information

2013-06-24 Thread Kishon Vijay Abraham I
In order for controllers to get PHY in case of non dt boot, the phy binding information (phy device name) should be added in the platform data of the controller. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Sylwester Nawrocki --- arch/arm/mach-omap2/usb-musb.c |6 +- include

[PATCH v8 6/8] usb: musb: omap2430: use the new generic PHY framework

2013-06-24 Thread Kishon Vijay Abraham I
te state machine to handle otg, these can be moved out of xceiv and then we can start using the generic PHY framework. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Sylwester Nawrocki --- drivers/usb/musb/Kconfig |1 + drivers/usb/musb/musb_core.c |1 + drivers/usb/musb/musb_core.

[PATCH v8 2/8] usb: phy: omap-usb2: use the new generic PHY framework

2013-06-24 Thread Kishon Vijay Abraham I
OTG. Once we have a separate OTG state machine, we can get rid of the USB PHY library. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Sylwester Nawrocki --- drivers/usb/phy/Kconfig |1 + drivers/usb/phy/phy-omap-usb2.c | 43 +++ 2 files

[PATCH v8 0/8] Generic PHY Framework

2013-06-24 Thread Kishon Vijay Abraham I
d* to *phy_bind*. Changes from v1: * Added Documentation for the PHY framework * Added few more APIs mostly w.r.t devres * Modified omap-usb2 and twl4030 to make use of the new framework Did USB enumeration testing in panda and beagle. Kishon Vijay Abraham I (8): drivers: phy: add generic PHY frame

[PATCH v8 1/8] drivers: phy: add generic PHY framework

2013-06-24 Thread Kishon Vijay Abraham I
Signed-off-by: Kishon Vijay Abraham I Tested-by: Sylwester Nawrocki --- .../devicetree/bindings/phy/phy-bindings.txt | 66 +++ Documentation/phy.txt | 125 + MAINTAINERS|7 + drivers/Kconfig

Re: [PATCH v7 1/9] drivers: phy: add generic PHY framework

2013-06-23 Thread Kishon Vijay Abraham I
On Wednesday 19 June 2013 02:52 AM, Sylwester Nawrocki wrote: Hi Kishon, I've noticed there is a little inconsistency between the code and documentation. On 06/13/2013 10:43 AM, Kishon Vijay Abraham I wrote: +3. Creating the PHY + +The PHY driver should create the PHY in order for

Re: [PATCH v7 7/9] usb: musb: omap2430: use the new generic PHY framework

2013-06-23 Thread Kishon Vijay Abraham I
Hi, On Tuesday 18 June 2013 03:17 PM, Felipe Balbi wrote: Hi, On Thu, Jun 13, 2013 at 02:13:57PM +0530, Kishon Vijay Abraham I wrote: Use the generic PHY framework API to get the PHY. The usb_phy_set_resume and usb_phy_set_suspend is replaced with power_on/get_sync and power_off/put_sync to

Re: [PATCH 2/2] regulator: palmas: model SMPS10 as two regulators

2013-06-23 Thread Kishon Vijay Abraham I
Hi, On Saturday 22 June 2013 06:42 PM, Laxman Dewangan wrote: On Friday 21 June 2013 07:30 PM, Kishon Vijay Abraham I wrote: On Friday 21 June 2013 06:55 PM, Laxman Dewangan wrote: On Thursday 20 June 2013 08:56 PM, Kishon Vijay Abraham I wrote: Hi, On Thursday 20 June 2013 08:14 PM, Laxman

Re: [PATCH 2/2] regulator: palmas: model SMPS10 as two regulators

2013-06-21 Thread Kishon Vijay Abraham I
On Friday 21 June 2013 06:55 PM, Laxman Dewangan wrote: On Thursday 20 June 2013 08:56 PM, Kishon Vijay Abraham I wrote: Hi, On Thursday 20 June 2013 08:14 PM, Laxman Dewangan wrote: Have you added the regulator supply entries? Are you testing on mainline linux-next? Not in linux-next

[PATCH v5] usb: dwc3: use extcon fwrk to receive connect/disconnect

2013-06-21 Thread Kishon Vijay Abraham I
Modified dwc3-omap to receive connect and disconnect notification using extcon framework. Also did the necessary cleanups required after adapting to extcon framework. Signed-off-by: Kishon Vijay Abraham I Acked-by: Felipe Balbi Acked-by: Chanwoo Choi --- This patch should be applied after all

Re: [PATCH 2/2] regulator: palmas: model SMPS10 as two regulators

2013-06-20 Thread Kishon Vijay Abraham I
Hi, On Thursday 20 June 2013 08:14 PM, Laxman Dewangan wrote: On Thursday 20 June 2013 07:49 PM, Kishon Vijay Abraham I wrote: Hi, On Thursday 20 June 2013 07:33 PM, Laxman Dewangan wrote: On Thursday 20 June 2013 07:20 PM, Kishon Vijay Abraham I wrote: Hi, On Thursday 20 June 2013 04:22

Re: [PATCH 2/2] regulator: palmas: model SMPS10 as two regulators

2013-06-20 Thread Kishon Vijay Abraham I
Hi, On Thursday 20 June 2013 07:33 PM, Laxman Dewangan wrote: On Thursday 20 June 2013 07:20 PM, Kishon Vijay Abraham I wrote: Hi, On Thursday 20 June 2013 04:22 PM, Laxman Dewangan wrote: On Thursday 20 June 2013 02:07 PM, Kishon Vijay Abraham I wrote: SMPS10 has two outputs OUT1 and OUT2

Re: [PATCH 2/2] regulator: palmas: model SMPS10 as two regulators

2013-06-20 Thread Kishon Vijay Abraham I
Hi, On Thursday 20 June 2013 04:22 PM, Laxman Dewangan wrote: On Thursday 20 June 2013 02:07 PM, Kishon Vijay Abraham I wrote: SMPS10 has two outputs OUT1 and OUT2 and have one input IN1. SMPS10-OUT2 is connected to SMPS10-IN1 and can be configured either in BOOST mode or BYPASS mode

Re: [PATCH v4] usb: dwc3: use extcon fwrk to receive connect/disconnect

2013-06-20 Thread Kishon Vijay Abraham I
Hi, On Monday 17 June 2013 09:39 AM, Chanwoo Choi wrote: On 06/14/2013 10:10 PM, Kishon Vijay Abraham I wrote: Modified dwc3-omap to receive connect and disconnect notification using extcon framework. Also did the necessary cleanups required after adapting to extcon framework. Signed-off-by

[PATCH 2/2] regulator: palmas: model SMPS10 as two regulators

2013-06-20 Thread Kishon Vijay Abraham I
connected to SMPS10-OUT2 and can be enabled using regulator_enable(). Cc: Laxman Dewangan Signed-off-by: Kishon Vijay Abraham I --- drivers/regulator/palmas-regulator.c | 39 ++ include/linux/mfd/palmas.h |9 2 files changed, 40 insertions

[PATCH 1/2] regulator: of: Added a property to indicate bypass mode support

2013-06-20 Thread Kishon Vijay Abraham I
Added a property to indicate if the regulator supports bypass mode. Also modified of_get_regulation_constraints() to check for that property and set appropriate constraints. Cc: Laxman Dewangan Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/regulator/regulator.txt

[PATCH 0/2] Model SMPS10 regulator

2013-06-20 Thread Kishon Vijay Abraham I
le of SMPS10-OUT1. Dint test bypass mode. Kishon Vijay Abraham I (2): regulator: of: Added a property to indicate bypass mode support regulator: palmas: model SMPS10 as two regulators .../devicetree/bindings/regulator/regulator.txt|1 + drivers/regulator/of_regulator.c |

Re: [PATCH v7 1/9] drivers: phy: add generic PHY framework

2013-06-19 Thread Kishon Vijay Abraham I
Hi, On Wednesday 19 June 2013 09:19 PM, Sylwester Nawrocki wrote: Hi, On 06/13/2013 10:43 AM, Kishon Vijay Abraham I wrote: +/** + * phy_create() - create a new phy + * @dev: device that is creating the new phy + * @id: id of the phy + * @ops: function pointers for performing phy operations

Re: [PATCH v7 5/9] ARM: OMAP: USB: Add phy binding information

2013-06-18 Thread Kishon Vijay Abraham I
Hi, On Tuesday 18 June 2013 06:05 PM, Felipe Balbi wrote: Hi, On Tue, Jun 18, 2013 at 04:43:44PM +0530, Kishon Vijay Abraham I wrote: On Tue, Jun 18, 2013 at 03:34:36PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 18 June 2013 03:14 PM, Felipe Balbi wrote: On Thu, Jun 13, 2013 at 02:13

Re: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

2013-06-18 Thread Kishon Vijay Abraham I
Hi, On Tuesday 18 June 2013 03:33 PM, Rahul Sharma wrote: > Thanks all, > > On Fri, Jun 14, 2013 at 11:39 AM, 김승우 wrote: >> Hello Kishon, >> >> On 2013년 06월 13일 21:54, Kishon Vijay Abraham I wrote: >>> Hi, >>> >>> On Thursday 13 June 2013 0

Re: [PATCH v7 5/9] ARM: OMAP: USB: Add phy binding information

2013-06-18 Thread Kishon Vijay Abraham I
Hi, On Tuesday 18 June 2013 03:57 PM, Felipe Balbi wrote: Hi, On Tue, Jun 18, 2013 at 03:34:36PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 18 June 2013 03:14 PM, Felipe Balbi wrote: On Thu, Jun 13, 2013 at 02:13:55PM +0530, Kishon Vijay Abraham I wrote: In order for controllers to get

Re: [PATCH v7 5/9] ARM: OMAP: USB: Add phy binding information

2013-06-18 Thread Kishon Vijay Abraham I
Hi, On Tuesday 18 June 2013 03:14 PM, Felipe Balbi wrote: On Thu, Jun 13, 2013 at 02:13:55PM +0530, Kishon Vijay Abraham I wrote: In order for controllers to get PHY in case of non dt boot, the phy binding information (phy device name) should be added in the platform data of the controller

Re: [PATCH v7 2/9] usb: phy: omap-usb2: use the new generic PHY framework

2013-06-18 Thread Kishon Vijay Abraham I
Hi, On Tuesday 18 June 2013 03:20 PM, Felipe Balbi wrote: Hi, On Tue, Jun 18, 2013 at 03:19:03PM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 18 June 2013 03:10 PM, Felipe Balbi wrote: Hi, On Thu, Jun 13, 2013 at 02:13:52PM +0530, Kishon Vijay Abraham I wrote: @@ -159,6 +191,12

Re: [PATCH v7 2/9] usb: phy: omap-usb2: use the new generic PHY framework

2013-06-18 Thread Kishon Vijay Abraham I
Hi, On Tuesday 18 June 2013 03:10 PM, Felipe Balbi wrote: Hi, On Thu, Jun 13, 2013 at 02:13:52PM +0530, Kishon Vijay Abraham I wrote: @@ -159,6 +191,12 @@ static int omap_usb2_probe(struct platform_device *pdev) otg->start_srp = omap_usb_start_srp; otg-&

[PATCH v4] usb: dwc3: use extcon fwrk to receive connect/disconnect

2013-06-14 Thread Kishon Vijay Abraham I
Modified dwc3-omap to receive connect and disconnect notification using extcon framework. Also did the necessary cleanups required after adapting to extcon framework. Signed-off-by: Kishon Vijay Abraham I Acked-by: Felipe Balbi --- This patch depends on git://git.kernel.org/pub/scm/linux/kernel

Re: [PATCH v2] extcon: Add an API to get extcon device from dt node

2013-06-14 Thread Kishon Vijay Abraham I
Hi, On Friday 14 June 2013 12:45 PM, Chanwoo Choi wrote: From: Kishon Vijay Abraham I Added an API of_extcon_get_extcon_dev() to be used by drivers to get extcon device in the case of dt boot (this can be used instead of extcon_get_extcon_dev()). Signed-off-by: Kishon Vijay Abraham I Signed

Re: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

2013-06-13 Thread Kishon Vijay Abraham I
...@lists.ozlabs.org; DRI mailing list; Kukjin Kim; Seung-Woo Kim; Sean Paul; sunil joshi; Kishon Vijay Abraham I; Stephen Warren; grant.lik...@linaro.org Subject: Re: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control Hi, On 06/13/2013 06:26 AM, Rahul Sharma wrote: Mr. Dae, Thanks for

[PATCH v7 7/9] usb: musb: omap2430: use the new generic PHY framework

2013-06-13 Thread Kishon Vijay Abraham I
ere is a separate state machine to handle otg, these can be moved out of xceiv and then we can start using the generic PHY framework. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/musb/musb_core.c |1 + drivers/usb/musb/musb_core.h |3 +++ drivers/usb/musb/omap2430.c

[PATCH v7 0/9] Generic PHY Framework

2013-06-13 Thread Kishon Vijay Abraham I
eagle. Kishon Vijay Abraham I (9): drivers: phy: add generic PHY framework usb: phy: omap-usb2: use the new generic PHY framework usb: phy: twl4030: use the new generic PHY framework usb: phy: twl4030: twl4030 shouldn't be subsys_initcall ARM: OMAP: USB: Add phy binding information

[PATCH v7 1/9] drivers: phy: add generic PHY framework

2013-06-13 Thread Kishon Vijay Abraham I
Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/phy/phy-bindings.txt | 66 +++ Documentation/phy.txt | 124 + MAINTAINERS|7 + drivers/Kconfig|2 + drivers

[PATCH v7 9/9] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops

2013-06-13 Thread Kishon Vijay Abraham I
Now that twl4030-usb is adapted to the new generic PHY framework, *set_suspend* and *phy_init* ops can be removed from twl4030-usb driver. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/phy/phy-twl4030-usb.c | 55 - 1 file changed, 12 insertions

[PATCH v7 2/9] usb: phy: omap-usb2: use the new generic PHY framework

2013-06-13 Thread Kishon Vijay Abraham I
OTG. Once we have a separate OTG state machine, we can get rid of the USB PHY library. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/phy/phy-omap-usb2.c | 40 +-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/drivers/usb/phy/phy-omap

[PATCH v7 5/9] ARM: OMAP: USB: Add phy binding information

2013-06-13 Thread Kishon Vijay Abraham I
In order for controllers to get PHY in case of non dt boot, the phy binding information (phy device name) should be added in the platform data of the controller. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/mach-omap2/usb-musb.c |6 +- include/linux/usb/musb.h |3 +++ 2

[PATCH v7 8/9] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2

2013-06-13 Thread Kishon Vijay Abraham I
Now that omap-usb2 is adapted to the new generic PHY framework, *set_suspend* ops can be removed from omap-usb2 driver. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/phy/phy-omap-usb2.c | 24 1 file changed, 24 deletions(-) diff --git a/drivers/usb/phy/phy

[PATCH v7 4/9] usb: phy: twl4030: twl4030 shouldn't be subsys_initcall

2013-06-13 Thread Kishon Vijay Abraham I
Changed the inticall from subsys_initcall to module_init for twl4030-usb. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/phy/phy-twl4030-usb.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/usb/phy/phy-twl4030-usb.c b/drivers/usb/phy/phy

[PATCH v7 3/9] usb: phy: twl4030: use the new generic PHY framework

2013-06-13 Thread Kishon Vijay Abraham I
be completely removed because otg is intertwined with phy and moving to the new framework completely will break otg. Once we have a separate otg state machine, we can get rid of the usb phy library. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/phy/phy-twl4030-usb.c | 48

[PATCH v7 6/9] ARM: dts: omap: update usb_otg_hs data

2013-06-13 Thread Kishon Vijay Abraham I
-bindings.txt Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/usb/omap-usb.txt |5 + Documentation/devicetree/bindings/usb/usb-phy.txt |6 ++ arch/arm/boot/dts/omap3-beagle-xm.dts |2 ++ arch/arm/boot/dts/omap3-evm.dts

Re: [PATCH] extcon: Add an API to get extcon device from dt node

2013-06-11 Thread Kishon Vijay Abraham I
Hi Chanwoo Choi, On Wednesday 12 June 2013 07:09 AM, Chanwoo Choi wrote: From: Kishon Vijay Abraham I Added an API of_extcon_get_extcon_dev() to be used by drivers to get extcon device in the case of dt boot (this can be used instead of extcon_get_extcon_dev()). Signed-off-by: Kishon Vijay

Re: [PATCH v6 1/9] drivers: phy: add generic PHY framework

2013-06-04 Thread Kishon Vijay Abraham I
Hi, On Tuesday 04 June 2013 07:13 PM, Sylwester Nawrocki wrote: Hi, On 06/04/2013 02:26 PM, Kishon Vijay Abraham I wrote: +static inline int phy_init(struct phy *phy) +{ + pm_runtime_get_sync(&phy->dev); Hmm, no need to check return value here ? Also it looks a bit unexpected

Re: [PATCH 0/5] dwc3: omap: adapt dwc3 to use extcon framework

2013-06-04 Thread Kishon Vijay Abraham I
Hi Ruchika, On Tuesday 04 June 2013 07:53 PM, Ruchika Kharwar wrote: Kishon, What is the expectation when there is no palmas tied to dwc3/dwc3-omap ? In the probe of dwc3-omap I have this check "if (of_property_read_bool(node, "extcon"))" So If dwc3 node does not have extc

Re: [PATCH v6 1/9] drivers: phy: add generic PHY framework

2013-06-04 Thread Kishon Vijay Abraham I
Hi, On Tuesday 04 June 2013 03:51 PM, Sylwester Nawrocki wrote: On 04/29/2013 12:03 PM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle

  1   2   3   4   5   6   7   >