On 08/21/2012 12:49 PM, Guenter Roeck wrote:
On Fri, May 11, 2012 at 08:34:46PM -, David Daney wrote:
From: David Daney
Add the driver, link it into the kbuild system and provide device tree
binding documentation.
Signed-off-by: David Daney
Acked-by: Grant Likely
[ ... ]
+
+static i
On 05/19/2012 10:46 PM, Grant Likely wrote:
On Fri, 11 May 2012 14:34:46 -0700, David Daney wrote:
From: David Daney
Add the driver, link it into the kbuild system and provide device tree
binding documentation.
Signed-off-by: David Daney
Some comments below, but you can add my a-b:
Acked
On Fri, 11 May 2012 14:34:46 -0700, David Daney wrote:
> From: David Daney
>
> Add the driver, link it into the kbuild system and provide device tree
> binding documentation.
>
> Signed-off-by: David Daney
Some comments below, but you can add my a-b:
Acked-by: Grant Likely
> +#include
> +
On Mon, 14 May 2012 11:13:41 -0700, David Daney wrote:
> On 05/13/2012 10:46 PM, Shubhrajyoti Datta wrote:
> > Hi David,
> > A few comments.
> >
> > On Sat, May 12, 2012 at 3:04 AM, David Daney wrote:
> [...]
>
> >> +
> >> +#define DRV_VERSION "2.0" /* Version 1 was the out-of-tree driver */
> >
On Fri, May 11, 2012 at 11:34 PM, David Daney wrote:
> + mpi_cfg.u64 = 0;
> + mpi_cfg.u64 |= p->cs_enax;
> + if (mpi_cfg.u64 != p->last_cfg) {
But now I see why this 64bit is so clever. Forget the comment on 1/2!
This has a certain elegance to it that I just learned to apprecia
On 05/13/2012 10:46 PM, Shubhrajyoti Datta wrote:
Hi David,
A few comments.
On Sat, May 12, 2012 at 3:04 AM, David Daney wrote:
[...]
+
+#define DRV_VERSION "2.0" /* Version 1 was the out-of-tree driver */
This could be given a miss. As it is less meaningful once accepted.
Well, this lea
Hi David,
A few comments.
On Sat, May 12, 2012 at 3:04 AM, David Daney wrote:
> From: David Daney
>
> Add the driver, link it into the kbuild system and provide device tree
> binding documentation.
>
> Signed-off-by: David Daney
> ---
> .../devicetree/bindings/spi/spi-octeon.txt | 33
From: David Daney
Add the driver, link it into the kbuild system and provide device tree
binding documentation.
Signed-off-by: David Daney
---
.../devicetree/bindings/spi/spi-octeon.txt | 33 ++
drivers/spi/Kconfig|7 +
drivers/spi/Makefile
