Re: [PATCH] RFC: input: Extend matrix-keypad device tree binding

2012-12-21 Thread Rob Herring
On 12/20/2012 03:41 PM, Simon Glass wrote: Hi Dmitry, On Thu, Dec 20, 2012 at 1:13 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Simon, On Thu, Dec 20, 2012 at 12:23:58PM -0800, Simon Glass wrote: For the key repeat feature, we need to set this after the input device is

[PATCH] RFC: input: Extend matrix-keypad device tree binding

2012-12-20 Thread Simon Glass
Some matrix keypad drivers can support different numbers of rows and columns. Add a generic binding for these. Also define properties for the repeat rate, to allow a sane baseline to be set up for the driver. Implementation note: In order to implement this binding in the kernel, we will need to

Re: [PATCH] RFC: input: Extend matrix-keypad device tree binding

2012-12-20 Thread Stephen Warren
On 12/20/2012 01:23 PM, Simon Glass wrote: Some matrix keypad drivers can support different numbers of rows and columns. Add a generic binding for these. Oh, I thought num-rows/columns were already there! Anyway, looks fine to me, so, Reviewed-by: Stephen Warren swar...@nvidia.com

Re: [PATCH] RFC: input: Extend matrix-keypad device tree binding

2012-12-20 Thread Dmitry Torokhov
Hi Simon, On Thu, Dec 20, 2012 at 12:23:58PM -0800, Simon Glass wrote: For the key repeat feature, we need to set this after the input device is registered. So we would need to add a matrix_keypad_setup_input() or similar to be called by the driver after input_register_device(). I am less

Re: [PATCH] RFC: input: Extend matrix-keypad device tree binding

2012-12-20 Thread Simon Glass
Hi Dmitry, On Thu, Dec 20, 2012 at 1:13 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Simon, On Thu, Dec 20, 2012 at 12:23:58PM -0800, Simon Glass wrote: For the key repeat feature, we need to set this after the input device is registered. So we would need to add a