[PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Ezequiel Garcia
This patch adds an SPI master device node for Armada XP-GP board. This master node is an SPI flash controller 'n25q128a13'. Since there is no 'partitions' node declared, one full sized partition named as the device will be created. Cc: Gregory Clement Cc: Thomas Petazzoni Cc: Lior Amsalem Sign

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Jason Cooper
On Tue, Feb 05, 2013 at 08:24:33AM -0300, Ezequiel Garcia wrote: > This patch adds an SPI master device node for Armada XP-GP board. > This master node is an SPI flash controller 'n25q128a13'. > > Since there is no 'partitions' node declared, one full sized > partition named as the device will be

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Andrew Lunn
> And don't forget to compile the SPI flash driver, CONFIG_MTD_M25P80=y Hi Ezequiel Maybe it makes sense to provide a patch to mvebu_defconfig to add CONFIG_MTD_M25P80=y ? Andrew ___ devicetree-discuss mailing list devicetree-discuss@lists.ozl

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Jason Cooper
Morning-ish Andrew, On Tue, Feb 05, 2013 at 01:38:27PM +0100, Andrew Lunn wrote: > > And don't forget to compile the SPI flash driver, CONFIG_MTD_M25P80=y > > Maybe it makes sense to provide a patch to mvebu_defconfig to add > CONFIG_MTD_M25P80=y ? I thought this as well, then reconsidered when

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Ezequiel Garcia
On Tue, Feb 05, 2013 at 07:48:33AM -0500, Jason Cooper wrote: > Morning-ish Andrew, > > On Tue, Feb 05, 2013 at 01:38:27PM +0100, Andrew Lunn wrote: > > > And don't forget to compile the SPI flash driver, CONFIG_MTD_M25P80=y > > > > Maybe it makes sense to provide a patch to mvebu_defconfig to ad

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Jason Cooper
On Tue, Feb 05, 2013 at 11:27:21AM -0300, Ezequiel Garcia wrote: > On Tue, Feb 05, 2013 at 07:48:33AM -0500, Jason Cooper wrote: > > Morning-ish Andrew, > > > > On Tue, Feb 05, 2013 at 01:38:27PM +0100, Andrew Lunn wrote: > > > > And don't forget to compile the SPI flash driver, CONFIG_MTD_M25P80=

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Thomas Petazzoni
Dear Jason Cooper, On Tue, 5 Feb 2013 10:31:35 -0500, Jason Cooper wrote: > One thing we've been doing a lot of with mvebu is using it for > build-testing. For that use case, since the bootloader is there, I'd > recommend setting it. This will reduce the likelyhood of nasty build > breakages fu

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Gregory CLEMENT
On 02/05/2013 05:17 PM, Thomas Petazzoni wrote: > Dear Jason Cooper, > > On Tue, 5 Feb 2013 10:31:35 -0500, Jason Cooper wrote: > >> One thing we've been doing a lot of with mvebu is using it for >> build-testing. For that use case, since the bootloader is there, I'd >> recommend setting it. Th

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Jason Cooper
On Tue, Feb 05, 2013 at 05:17:01PM +0100, Thomas Petazzoni wrote: > Dear Jason Cooper, > > On Tue, 5 Feb 2013 10:31:35 -0500, Jason Cooper wrote: > > > One thing we've been doing a lot of with mvebu is using it for > > build-testing. For that use case, since the bootloader is there, I'd > > reco

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Gregory CLEMENT
Hi Ezequiel, On 02/05/2013 12:24 PM, Ezequiel Garcia wrote: > This patch adds an SPI master device node for Armada XP-GP board. > This master node is an SPI flash controller 'n25q128a13'. > > Since there is no 'partitions' node declared, one full sized > partition named as the device will be crea

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Thomas Petazzoni
Dear Gregory CLEMENT, On Tue, 05 Feb 2013 17:20:02 +0100, Gregory CLEMENT wrote: > So that means we should enable the drivers for all the devices present > on all the boards? Yes. For example my mvsdio patch set enables some Wifi driver that corresponds to a particular SDIO Wifi device that is p

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Jason Cooper
On Tue, Feb 05, 2013 at 06:07:05PM +0100, Thomas Petazzoni wrote: > Of course, it doesn't make sense to have drivers for pluggable devices > like PCIe devices that are not soldered, USB devices and things like > that. But for all the rest, I would say it should be in the defconfig. hmmm, so for th

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Ezequiel Garcia
On Tue, Feb 05, 2013 at 06:07:05PM +0100, Thomas Petazzoni wrote: > Dear Gregory CLEMENT, > > On Tue, 05 Feb 2013 17:20:02 +0100, Gregory CLEMENT wrote: > > > So that means we should enable the drivers for all the devices present > > on all the boards? > > Yes. For example my mvsdio patch set en

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Gregory CLEMENT
On 02/05/2013 05:28 PM, Gregory CLEMENT wrote: > Hi Ezequiel, > > On 02/05/2013 12:24 PM, Ezequiel Garcia wrote: >> This patch adds an SPI master device node for Armada XP-GP board. >> This master node is an SPI flash controller 'n25q128a13'. >> >> Since there is no 'partitions' node declared, one

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-06 Thread Ezequiel Garcia
Hi Gregory, On Tue, Feb 05, 2013 at 09:17:02PM +0100, Gregory CLEMENT wrote: > On 02/05/2013 05:28 PM, Gregory CLEMENT wrote: > > Hi Ezequiel, > > > > On 02/05/2013 12:24 PM, Ezequiel Garcia wrote: > >> This patch adds an SPI master device node for Armada XP-GP board. > >> This master node is an

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-06 Thread Gregory CLEMENT
On 02/06/2013 11:54 AM, Ezequiel Garcia wrote: > Hi Gregory, > > On Tue, Feb 05, 2013 at 09:17:02PM +0100, Gregory CLEMENT wrote: >> On 02/05/2013 05:28 PM, Gregory CLEMENT wrote: >>> Hi Ezequiel, >>> >>> On 02/05/2013 12:24 PM, Ezequiel Garcia wrote: This patch adds an SPI master device node

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-06 Thread Ezequiel Garcia
(Adding mtd in Cc) On Wed, Feb 06, 2013 at 07:54:31AM -0300, Ezequiel Garcia wrote: > Hi Gregory, > > On Tue, Feb 05, 2013 at 09:17:02PM +0100, Gregory CLEMENT wrote: > > On 02/05/2013 05:28 PM, Gregory CLEMENT wrote: > > > Hi Ezequiel, > > > > > > On 02/05/2013 12:24 PM, Ezequiel Garcia wrote:

RE: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-11 Thread Lior Amsalem
> From: Jason Cooper [mailto:ja...@lakedaemon.net] > Sent: Tuesday, February 05, 2013 8:09 PM > > On Tue, Feb 05, 2013 at 06:07:05PM +0100, Thomas Petazzoni wrote: > > Of course, it doesn't make sense to have drivers for pluggable devices > > like PCIe devices that are not soldered, USB devices an