Re: [PATCH] cpufreq: SPEAr: Add CPUFreq driver

2012-11-29 Thread Deepak Sikri
On 11/27/2012 9:28 AM, Viresh Kumar wrote: [snip..] It's a little bit unusual that cpu runs such a freq range (166 ~ 600 MHz) at a fixed voltage. You really have no way to scale voltage? AFAIK, there is no voltage scaling. @Shiraz/Deepak: Can you confirm? We do not have any provision for vol

Re: [PATCH] cpufreq: SPEAr: Add CPUFreq driver

2012-11-27 Thread Rafael J. Wysocki
On Tuesday, November 27, 2012 05:05:47 PM Viresh Kumar wrote: > On 27 November 2012 17:08, Rafael J. Wysocki wrote: > > On Tuesday, November 27, 2012 09:28:01 AM Viresh Kumar wrote: > >> On 27 November 2012 09:31, Shawn Guo wrote: > >> > On Sun, Nov 25, 2012 at 01:09:28AM +0530, Viresh Kumar wrot

Re: [PATCH] cpufreq: SPEAr: Add CPUFreq driver

2012-11-27 Thread Rafael J. Wysocki
On Tuesday, November 27, 2012 09:28:01 AM Viresh Kumar wrote: > Hi Shawn, > > Thanks for feedback. > > On 27 November 2012 09:31, Shawn Guo wrote: > > On Sun, Nov 25, 2012 at 01:09:28AM +0530, Viresh Kumar wrote: > >> +cpufreq { > >> + compatible = "st,cpufreq-spear"; > > > > I do not think

Re: [PATCH] cpufreq: SPEAr: Add CPUFreq driver

2012-11-27 Thread Viresh Kumar
On 27 November 2012 17:08, Rafael J. Wysocki wrote: > On Tuesday, November 27, 2012 09:28:01 AM Viresh Kumar wrote: >> On 27 November 2012 09:31, Shawn Guo wrote: >> > On Sun, Nov 25, 2012 at 01:09:28AM +0530, Viresh Kumar wrote: >> >> +cpufreq { >> >> + compatible = "st,cpufreq-spear"; >> >

Re: [PATCH] cpufreq: SPEAr: Add CPUFreq driver

2012-11-27 Thread Sudeep K N
On Tue, Nov 27, 2012 at 9:33 AM, Viresh Kumar wrote: > On 27 November 2012 14:54, Sudeep K N wrote: >> On Sat, Nov 24, 2012 at 7:39 PM, Viresh Kumar >> wrote: >> [...] >>> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-spear.txt >>> b/Documentation/devicetree/bindings/cpufreq/c

Re: [PATCH] cpufreq: SPEAr: Add CPUFreq driver

2012-11-27 Thread Viresh Kumar
On 27 November 2012 14:54, Sudeep K N wrote: > On Sat, Nov 24, 2012 at 7:39 PM, Viresh Kumar wrote: > [...] >> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-spear.txt >> b/Documentation/devicetree/bindings/cpufreq/cpufreq-spear.txt >> new file mode 100644 >> index 000..4cf28

Re: [PATCH] cpufreq: SPEAr: Add CPUFreq driver

2012-11-27 Thread Sudeep K N
On Sat, Nov 24, 2012 at 7:39 PM, Viresh Kumar wrote: [...] > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-spear.txt > b/Documentation/devicetree/bindings/cpufreq/cpufreq-spear.txt > new file mode 100644 > index 000..4cf2819 > --- /dev/null > +++ b/Documentation/devicetree/bi

Re: [PATCH] cpufreq: SPEAr: Add CPUFreq driver

2012-11-26 Thread Viresh Kumar
On 27 November 2012 10:46, Shawn Guo wrote: > Shouldn't it also be handled by cpu clock provider? Not really sure. -- viresh ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH] cpufreq: SPEAr: Add CPUFreq driver

2012-11-26 Thread Shawn Guo
On Tue, Nov 27, 2012 at 09:28:01AM +0530, Viresh Kumar wrote: > >> + if (of_machine_is_compatible("st,spear1340")) { > >> + /* > >> + * SPEAr1340 is special in the sense that due to the > >> possibility > >> + * of multiple clock sources for cpu clk's pare

Re: [PATCH] cpufreq: SPEAr: Add CPUFreq driver

2012-11-26 Thread Viresh Kumar
Hi Shawn, Thanks for feedback. On 27 November 2012 09:31, Shawn Guo wrote: > On Sun, Nov 25, 2012 at 01:09:28AM +0530, Viresh Kumar wrote: >> +cpufreq { >> + compatible = "st,cpufreq-spear"; > > I do not think we need a "cpufreq" node, as we already have node for > cpu to contain these. Hmm

Re: [PATCH] cpufreq: SPEAr: Add CPUFreq driver

2012-11-26 Thread Shawn Guo
On Sun, Nov 25, 2012 at 01:09:28AM +0530, Viresh Kumar wrote: > From: Deepak Sikri > > SPEAr is an ARM based family of SoCs. This patch adds in support of cpufreq > driver for SPEAr SoCs. It is supported via DT only and so bindings are present > in binding document. > > Signed-off-by: Deepak Sik

Re: [PATCH] cpufreq: SPEAr: Add CPUFreq driver

2012-11-24 Thread Rafael J. Wysocki
On Sunday, November 25, 2012 01:09:28 AM Viresh Kumar wrote: > From: Deepak Sikri > > SPEAr is an ARM based family of SoCs. This patch adds in support of cpufreq > driver for SPEAr SoCs. It is supported via DT only and so bindings are present > in binding document. I'm not going to take this for

[PATCH] cpufreq: SPEAr: Add CPUFreq driver

2012-11-24 Thread Viresh Kumar
From: Deepak Sikri SPEAr is an ARM based family of SoCs. This patch adds in support of cpufreq driver for SPEAr SoCs. It is supported via DT only and so bindings are present in binding document. Signed-off-by: Deepak Sikri Signed-off-by: Viresh Kumar --- .../devicetree/bindings/cpufreq/cpufre