Re: [PATCH] dmaengine: Add hisilicon k3 DMA engine driver

2013-06-24 Thread Arnd Bergmann
On Monday 24 June 2013 16:49:08 zhangfei gao wrote: Dear Arnd Vinod The suggestion of using dma_get_slave_channel instead of filter works here. Dma driver should modify accordingly. The changes all look good to me, thanks a lot for following up! However, you should really follow the

Re: [PATCH] dmaengine: Add hisilicon k3 DMA engine driver

2013-06-21 Thread Vinod Koul
On Mon, Jun 17, 2013 at 12:54:32PM +0800, Zhangfei Gao wrote: Add dmaengine driver for hisilicon k3 platform based on virt_dma Signed-off-by: Zhangfei Gao zhangfei@linaro.org Tested-by: Kai Yang jean.yang...@huawei.com --- [snip] +#define to_k3_dma(dmadev) container_of(dmadev, struct

Re: [PATCH] dmaengine: Add hisilicon k3 DMA engine driver

2013-06-21 Thread Vinod Koul
On Mon, Jun 17, 2013 at 10:58:07PM +0200, Arnd Bergmann wrote: On Monday 17 June 2013, Zhangfei Gao wrote: Add dmaengine driver for hisilicon k3 platform based on virt_dma Signed-off-by: Zhangfei Gao zhangfei@linaro.org Tested-by: Kai Yang jean.yang...@huawei.com Acked-by: Arnd

Re: [PATCH] dmaengine: Add hisilicon k3 DMA engine driver

2013-06-21 Thread Vinod Koul
On Tue, Jun 18, 2013 at 04:09:14PM +0200, Arnd Bergmann wrote: On Tuesday 18 June 2013, zhangfei gao wrote: On Tue, Jun 18, 2013 at 4:58 AM, Arnd Bergmann a...@arndb.de wrote: +static struct of_dma_filter_info k3_dma_filter; +static bool k3_dma_filter_fn(struct dma_chan *chan, void

Re: [PATCH] dmaengine: Add hisilicon k3 DMA engine driver

2013-06-21 Thread Vinod Koul
On Tue, Jun 18, 2013 at 05:08:01PM +0200, Arnd Bergmann wrote: On Tuesday 18 June 2013 22:22:17 zhangfei wrote: With no need to have a filter function. Cool, then I would like to wait for the patch. Maybe you can try to add the dma_get_slave_channel() function I proposed here as a

Re: [PATCH] dmaengine: Add hisilicon k3 DMA engine driver

2013-06-21 Thread Arnd Bergmann
On Friday 21 June 2013, Vinod Koul wrote: On Mon, Jun 17, 2013 at 10:58:07PM +0200, Arnd Bergmann wrote: On Monday 17 June 2013, Zhangfei Gao wrote: int dma_get_slave_channel(struct dma_chan *chan) { /* lock against __dma_request_channel */ mutex_lock(dma_list_mutex);

Re: [PATCH] dmaengine: Add hisilicon k3 DMA engine driver

2013-06-18 Thread Arnd Bergmann
On Tuesday 18 June 2013, zhangfei gao wrote: On Tue, Jun 18, 2013 at 4:58 AM, Arnd Bergmann a...@arndb.de wrote: +static struct of_dma_filter_info k3_dma_filter; +static bool k3_dma_filter_fn(struct dma_chan *chan, void *param) +{ + return (*(int *)param == chan-chan_id); +}

Re: [PATCH] dmaengine: Add hisilicon k3 DMA engine driver

2013-06-18 Thread Arnd Bergmann
On Tuesday 18 June 2013 22:22:17 zhangfei wrote: With no need to have a filter function. Cool, then I would like to wait for the patch. Maybe you can try to add the dma_get_slave_channel() function I proposed here as a first patch and add your driver on top. There may be issues I missed, and

Re: [PATCH] dmaengine: Add hisilicon k3 DMA engine driver

2013-06-17 Thread Arnd Bergmann
On Monday 17 June 2013, Zhangfei Gao wrote: Add dmaengine driver for hisilicon k3 platform based on virt_dma Signed-off-by: Zhangfei Gao zhangfei@linaro.org Tested-by: Kai Yang jean.yang...@huawei.com Acked-by: Arnd Bergmann a...@arndb.de diff --git