Re: [PATCH] dt: add helper function to read u8 & u16 variables & arrays

2012-11-20 Thread Rob Herring
On 11/19/2012 10:45 PM, Viresh Kumar wrote: > This adds following helper routines: > - of_property_read_u8_array() > - of_property_read_u16_array() > - of_property_read_u8() > - of_property_read_u16() > > This expects arrays from DT to be passed as: > - u8 array: > property = /bits/ 8 <0x50

Re: [PATCH] dt: add helper function to read u8 & u16 variables & arrays

2012-11-20 Thread Stephen Warren
On 11/19/2012 09:45 PM, Viresh Kumar wrote: > This adds following helper routines: > - of_property_read_u8_array() > - of_property_read_u16_array() > - of_property_read_u8() > - of_property_read_u16() > > This expects arrays from DT to be passed as: > - u8 array: > property = /bits/ 8 <0x50

Re: [PATCH] dt: add helper function to read u8 & u16 variables & arrays

2012-11-20 Thread Shevchenko, Andriy
On Tue, 2012-11-20 at 10:15 +0530, Viresh Kumar wrote: > This adds following helper routines: > - of_property_read_u8_array() > - of_property_read_u16_array() > - of_property_read_u8() > - of_property_read_u16() > > This expects arrays from DT to be passed as: > - u8 array: > property = /bi

Re: [PATCH] dt: add helper function to read u8 & u16 variables & arrays

2012-11-20 Thread Viresh Kumar
On 20 November 2012 13:51, Shevchenko, Andriy wrote: > You could at least create macro to do a precheck if you want to. > > Like > #define CHECK_PROP(prop, sz, out) > > { > if (!prop) > return -EINVAL; > if (!prop->value) > return -ENODATA; > if ((sz

[PATCH] dt: add helper function to read u8 & u16 variables & arrays

2012-11-19 Thread Viresh Kumar
This adds following helper routines: - of_property_read_u8_array() - of_property_read_u16_array() - of_property_read_u8() - of_property_read_u16() This expects arrays from DT to be passed as: - u8 array: property = /bits/ 8 <0x50 0x60 0x70>; - u16 array: property = /bits/ 16 <0x500

Re: [PATCH] dt: add helper function to read u8 & u16 variables & arrays

2012-10-25 Thread Rob Herring
On 10/25/2012 02:03 AM, Viresh Kumar wrote: > On 12 October 2012 23:31, Viresh Kumar wrote: >> This adds following helper routines: >> - of_property_read_u8_array() >> - of_property_read_u16_array() >> - of_property_read_u8() >> - of_property_read_u16() >> >> First two actually share most of the c