Re: [PATCH] of/pdt: allow DT device matching by fixing 'name' brokenness

2011-02-25 Thread Daniel Drake
On 23 February 2011 19:54, Andres Salomon dilin...@queued.net wrote: Wait; why are you binding to a device based on name?  Binding by name and/or device_type is strongly discouraged for new code.  Use compatible instead. Daniel posted a separate patch showing his code, would you mind

Re: [PATCH] of/pdt: allow DT device matching by fixing 'name' brokenness

2011-02-23 Thread Grant Likely
On Fri, Feb 18, 2011 at 07:06:59PM -0800, Andres Salomon wrote: On Fri, 18 Feb 2011 23:42:57 + Daniel Drake d...@laptop.org wrote: On 16 February 2011 22:44, David Woodhouse dw...@infradead.org wrote: On Wed, 2011-02-16 at 22:28 +, Daniel Drake wrote: +static int __init

Re: [PATCH] of/pdt: allow DT device matching by fixing 'name' brokenness

2011-02-23 Thread Andres Salomon
On Wed, 23 Feb 2011 12:43:52 -0700 Grant Likely grant.lik...@secretlab.ca wrote: On Fri, Feb 18, 2011 at 07:06:59PM -0800, Andres Salomon wrote: On Fri, 18 Feb 2011 23:42:57 + Daniel Drake d...@laptop.org wrote: On 16 February 2011 22:44, David Woodhouse dw...@infradead.org

[PATCH] of/pdt: allow DT device matching by fixing 'name' brokenness (v2)

2011-02-23 Thread Andres Salomon
Commit e2f2a93b changed dp-name from using the 'name' property to using package-to-path. This fixed /proc/device-tree creation by eliminating conflicts between names (the 'name' property provides names like 'battery', whereas package-to-path provides names like '/foo/bar/battery@0', which we

Re: [PATCH] of/pdt: allow DT device matching by fixing 'name' brokenness (v2)

2011-02-23 Thread Grant Likely
On Wed, Feb 23, 2011 at 03:03:57PM -0800, Andres Salomon wrote: Commit e2f2a93b changed dp-name from using the 'name' property to using package-to-path. This fixed /proc/device-tree creation by eliminating conflicts between names (the 'name' property provides names like 'battery', whereas

Re: [PATCH] of/pdt: allow DT device matching by fixing 'name' brokenness (v2)

2011-02-23 Thread Andres Salomon
On Wed, 23 Feb 2011 16:28:15 -0700 Grant Likely grant.lik...@secretlab.ca wrote: On Wed, Feb 23, 2011 at 03:03:57PM -0800, Andres Salomon wrote: Commit e2f2a93b changed dp-name from using the 'name' property to using package-to-path. This fixed /proc/device-tree creation by eliminating

Re: [PATCH] of/pdt: allow DT device matching by fixing 'name' brokenness (v3)

2011-02-23 Thread Andres Salomon
On Wed, 23 Feb 2011 19:47:08 -0700 Grant Likely grant.lik...@secretlab.ca wrote: On Wed, Feb 23, 2011 at 04:34:42PM -0800, Andres Salomon wrote: Commit e2f2a93b changed dp-name from using the 'name' property to using package-to-path. This fixed /proc/device-tree creation by eliminating

Re: [PATCH] of/pdt: allow DT device matching by fixing 'name' brokenness (v3)

2011-02-23 Thread Grant Likely
On Wed, Feb 23, 2011 at 06:51:52PM -0800, Andres Salomon wrote: On Wed, 23 Feb 2011 19:47:08 -0700 Grant Likely grant.lik...@secretlab.ca wrote: This addresses one of my comments on v2; but it doesn't address the comment that the broken implementation of of_pdt_node_name for non-sparc

Re: [PATCH] of/pdt: allow DT device matching by fixing 'name' brokenness (v2)

2011-02-23 Thread Grant Likely
On Wed, Feb 23, 2011 at 04:16:30PM -0800, Andres Salomon wrote: On Wed, 23 Feb 2011 16:28:15 -0700 Grant Likely grant.lik...@secretlab.ca wrote: On Wed, Feb 23, 2011 at 03:03:57PM -0800, Andres Salomon wrote: Commit e2f2a93b changed dp-name from using the 'name' property to using

Re: [PATCH] of/pdt: allow DT device matching by fixing 'name' brokenness (v2)

2011-02-23 Thread Grant Likely
On Wed, Feb 23, 2011 at 08:36:49PM -0800, Andres Salomon wrote: On Wed, 23 Feb 2011 21:06:38 -0700 Grant Likely grant.lik...@secretlab.ca wrote: If the pkg2path hook isn't set and we're not sparc, we fall back to dp-name. That sucks, but I don't know of a better way to do things.

[PATCH] of/pdt: allow DT device matching by fixing 'name' brokenness (v4)

2011-02-23 Thread Andres Salomon
Commit e2f2a93b changed dp-name from using the 'name' property to using package-to-path. This fixed /proc/device-tree creation by eliminating conflicts between names (the 'name' property provides names like 'battery', whereas package-to-path provides names like '/foo/bar/battery@0', which we

[PATCH] of/pdt: allow DT device matching by fixing 'name' brokenness

2011-02-18 Thread Andres Salomon
On Fri, 18 Feb 2011 23:42:57 + Daniel Drake d...@laptop.org wrote: On 16 February 2011 22:44, David Woodhouse dw...@infradead.org wrote: On Wed, 2011-02-16 at 22:28 +, Daniel Drake wrote: +static int __init add_common_platform_devices(void) +{ +       struct platform_device