Re: [PATCH] pci: Provide support for parsing PCI DT ranges property

2013-01-14 Thread Andrew Murray
On Thu, Dec 20, 2012 at 08:25:00AM +, Thierry Reding wrote: On Wed, Dec 12, 2012 at 04:37:50PM +, Andrew Murray wrote: [...] diff --git a/drivers/of/address.c b/drivers/of/address.c [...] + start = of_get_property(node, ranges, rlen); + if (start == NULL) + return

Re: [PATCH] pci: Provide support for parsing PCI DT ranges property

2013-01-14 Thread Andrew Murray
On Sat, Dec 15, 2012 at 01:06:41AM +, Grant Likely wrote: On Wed, Dec 12, 2012 at 4:37 PM, Andrew Murray andrew.mur...@arm.com wrote: DT bindings for PCI host bridges often use the ranges property to describe memory and IO ranges - this binding tends to be the same across architectures

Re: [PATCH] pci: Provide support for parsing PCI DT ranges property

2012-12-20 Thread Thierry Reding
On Wed, Dec 12, 2012 at 04:37:50PM +, Andrew Murray wrote: [...] diff --git a/drivers/of/address.c b/drivers/of/address.c [...] + start = of_get_property(node, ranges, rlen); + if (start == NULL) + return NULL; + + end = start + rlen; I'm currently rewriting

[PATCH] pci: Provide support for parsing PCI DT ranges property

2012-12-19 Thread Andrew Murray
DT bindings for PCI host bridges often use the ranges property to describe memory and IO ranges - this binding tends to be the same across architectures yet several parsing implementations exist, e.g. arch/mips/pci/pci.c, arch/powerpc/kernel/pci-common.c, arch/sparc/kernel/pci.c and

Re: [PATCH] pci: Provide support for parsing PCI DT ranges property

2012-12-19 Thread Andrew Murray
On Thu, Dec 13, 2012 at 09:13:33AM +, Thierry Reding wrote: Hi Andrew, I don't like iterator interfaces too much, but I can live with that. Other than that the patch looks good to me and I'll try to work it into my Tegra PCIe patch series. Just two minor comments below. diff --git

Re: [PATCH] pci: Provide support for parsing PCI DT ranges property

2012-12-19 Thread Andrew Murray
On Thu, Dec 13, 2012 at 10:03:18AM +, Thierry Reding wrote: On Thu, Dec 13, 2012 at 09:45:43AM +, Andrew Murray wrote: On Thu, Dec 13, 2012 at 09:13:33AM +, Thierry Reding wrote: Hi Andrew, I don't like iterator interfaces too much, but I can live with that. Other than

Re: [PATCH] pci: Provide support for parsing PCI DT ranges property

2012-12-14 Thread Grant Likely
On Wed, Dec 12, 2012 at 4:37 PM, Andrew Murray andrew.mur...@arm.com wrote: DT bindings for PCI host bridges often use the ranges property to describe memory and IO ranges - this binding tends to be the same across architectures yet several parsing implementations exist, e.g.

Re: [PATCH] pci: Provide support for parsing PCI DT ranges property

2012-12-13 Thread Thierry Reding
On Wed, Dec 12, 2012 at 04:37:50PM +, Andrew Murray wrote: DT bindings for PCI host bridges often use the ranges property to describe memory and IO ranges - this binding tends to be the same across architectures yet several parsing implementations exist, e.g. arch/mips/pci/pci.c,

Re: [PATCH] pci: Provide support for parsing PCI DT ranges property

2012-12-13 Thread Thierry Reding
On Thu, Dec 13, 2012 at 09:45:43AM +, Andrew Murray wrote: On Thu, Dec 13, 2012 at 09:13:33AM +, Thierry Reding wrote: Hi Andrew, I don't like iterator interfaces too much, but I can live with that. Other than that the patch looks good to me and I'll try to work it into my