Re: [PATCH 1/1] Fix segfault in DTC

2012-10-03 Thread David Gibson
On Wed, Oct 03, 2012 at 03:33:30PM -0600, Stephen Warren wrote: > On 10/01/2012 06:08 PM, David Gibson wrote: > > On Mon, Oct 01, 2012 at 10:41:09AM -0600, Stephen Warren wrote: > >> On 10/01/2012 12:46 AM, David Gibson wrote: > >>> On Sun, Sep 30, 2012 at 11:34:50PM -0600, Stephen Warren wrote: >

Re: [PATCH 1/1] Fix segfault in DTC

2012-10-03 Thread Stephen Warren
On 10/01/2012 06:08 PM, David Gibson wrote: > On Mon, Oct 01, 2012 at 10:41:09AM -0600, Stephen Warren wrote: >> On 10/01/2012 12:46 AM, David Gibson wrote: >>> On Sun, Sep 30, 2012 at 11:34:50PM -0600, Stephen Warren wrote: On 09/29/2012 05:53 PM, David Gibson wrote: > On Fri, Sep 28, 201

Re: [PATCH 1/1] Fix segfault in DTC

2012-10-01 Thread David Gibson
On Mon, Oct 01, 2012 at 10:41:09AM -0600, Stephen Warren wrote: > On 10/01/2012 12:46 AM, David Gibson wrote: > > On Sun, Sep 30, 2012 at 11:34:50PM -0600, Stephen Warren wrote: > >> On 09/29/2012 05:53 PM, David Gibson wrote: > >>> On Fri, Sep 28, 2012 at 01:05:33PM -0600, Stephen Warren wrote: >

Re: [PATCH 1/1] Fix segfault in DTC

2012-10-01 Thread Stephen Warren
On 10/01/2012 12:46 AM, David Gibson wrote: > On Sun, Sep 30, 2012 at 11:34:50PM -0600, Stephen Warren wrote: >> On 09/29/2012 05:53 PM, David Gibson wrote: >>> On Fri, Sep 28, 2012 at 01:05:33PM -0600, Stephen Warren wrote: On 09/28/2012 12:53 PM, Jon Loeliger wrote: >>> >>> Yeah, see

Re: [PATCH 1/1] Fix segfault in DTC

2012-10-01 Thread David Gibson
On Sun, Sep 30, 2012 at 11:34:50PM -0600, Stephen Warren wrote: > On 09/29/2012 05:53 PM, David Gibson wrote: > > On Fri, Sep 28, 2012 at 01:05:33PM -0600, Stephen Warren wrote: > >> On 09/28/2012 12:53 PM, Jon Loeliger wrote: > > > > Yeah, seems like the kernel DTC is quite old. > > >

Re: [PATCH 1/1] Fix segfault in DTC

2012-09-30 Thread Stephen Warren
On 09/29/2012 05:53 PM, David Gibson wrote: > On Fri, Sep 28, 2012 at 01:05:33PM -0600, Stephen Warren wrote: >> On 09/28/2012 12:53 PM, Jon Loeliger wrote: > > Yeah, seems like the kernel DTC is quite old. FYI, I'm working on a patch to the kernel to bring in the latest dtc. >>>

Re: [PATCH 1/1] Fix segfault in DTC

2012-09-29 Thread David Gibson
On Fri, Sep 28, 2012 at 01:05:33PM -0600, Stephen Warren wrote: > On 09/28/2012 12:53 PM, Jon Loeliger wrote: > >>> > >>> Yeah, seems like the kernel DTC is quite old. > >> > >> FYI, I'm working on a patch to the kernel to bring in the latest dtc. > > > > Awesome. Thank you. > > > >> I've run a

Re: [PATCH 1/1] Fix segfault in DTC

2012-09-28 Thread Jon Loeliger
> > > > I think you should just smack the PowerPC guys. :-) > > For the record in this thread, it was a regression I introduced into dtc > - the patch I just sent was for this. Ah, ok. I'll apply the DTC patch, but I think you should still smack the PowerPC guys on general principle. :-) jdl _

Re: [PATCH 1/1] Fix segfault in DTC

2012-09-28 Thread Stephen Warren
On 09/28/2012 12:53 PM, Jon Loeliger wrote: >>> >>> Yeah, seems like the kernel DTC is quite old. >> >> FYI, I'm working on a patch to the kernel to bring in the latest dtc. > > Awesome. Thank you. > >> I've run a regression test vs. the old dtc in the kernel ... > > Which is the icky step. Ag

Re: [PATCH 1/1] Fix segfault in DTC

2012-09-28 Thread Jon Loeliger
> > > > Yeah, seems like the kernel DTC is quite old. > > FYI, I'm working on a patch to the kernel to bring in the latest dtc. Awesome. Thank you. > I've run a regression test vs. the old dtc in the kernel ... Which is the icky step. Again, thank you. > ... and found that > some of the Pow

Re: [PATCH 1/1] Fix segfault in DTC

2012-09-28 Thread Stephen Warren
On 09/26/2012 10:38 AM, Markus Mayer wrote: > On 25/09/2012 17:35, David Gibson wrote: >> On Tue, Sep 25, 2012 at 04:51:47PM -0700, Markus Mayer wrote: >>> On 25/09/2012 16:30, David Gibson wrote: Which dtc version did you observe this with? I'm unable to reproduce the SEGV with cur

Re: [PATCH 1/1] Fix segfault in DTC

2012-09-26 Thread Markus Mayer
On 25/09/2012 17:35, David Gibson wrote: On Tue, Sep 25, 2012 at 04:51:47PM -0700, Markus Mayer wrote: On 25/09/2012 16:30, David Gibson wrote: Which dtc version did you observe this with? I'm unable to reproduce the SEGV with current git. That was $ cat version_gen.h #define DTC_VERSION "

Re: [PATCH 1/1] Fix segfault in DTC

2012-09-25 Thread David Gibson
On Tue, Sep 25, 2012 at 04:51:47PM -0700, Markus Mayer wrote: > On 25/09/2012 16:30, David Gibson wrote: > >On Tue, Sep 25, 2012 at 10:58:09AM -0700, Markus Mayer wrote: > >>Prior to this change, an empty input file would cause a segfault, because > >>yylloc had never been initialized. There was ne

Re: [PATCH 1/1] Fix segfault in DTC

2012-09-25 Thread Markus Mayer
On 25/09/2012 16:30, David Gibson wrote: On Tue, Sep 25, 2012 at 10:58:09AM -0700, Markus Mayer wrote: Prior to this change, an empty input file would cause a segfault, because yylloc had never been initialized. There was never any characters for the lexer to match, so YY_USER_ACTION was never e

Re: [PATCH 1/1] Fix segfault in DTC

2012-09-25 Thread David Gibson
On Tue, Sep 25, 2012 at 10:58:09AM -0700, Markus Mayer wrote: > Prior to this change, an empty input file would cause a segfault, because > yylloc had never been initialized. There was never any characters for the > lexer to match, so YY_USER_ACTION was never executed before the parse error > was d

[PATCH 1/1] Fix segfault in DTC

2012-09-25 Thread Markus Mayer
Prior to this change, an empty input file would cause a segfault, because yylloc had never been initialized. There was never any characters for the lexer to match, so YY_USER_ACTION was never executed before the parse error was detected. When the parser printed the error message, it tried to inclu