Re: [PATCH 1/2] clk: nomadik: implement the Nomadik clocks properly

2013-06-20 Thread Linus Walleij
On Thu, Jun 20, 2013 at 8:38 AM, Mike Turquette wrote: > Quoting Linus Walleij (2013-06-09 03:55:47) >> +static void pll_clk_disable(struct clk_hw *hw) >> +{ >> + struct clk_pll *pll = to_pll(hw); >> + u32 val; >> + >> + return; > > Is the early return intentional? Everything els

Re: [PATCH 1/2] clk: nomadik: implement the Nomadik clocks properly

2013-06-19 Thread Mike Turquette
Quoting Linus Walleij (2013-06-09 03:55:47) > +static void pll_clk_disable(struct clk_hw *hw) > +{ > + struct clk_pll *pll = to_pll(hw); > + u32 val; > + > + return; Is the early return intentional? Everything else looks good. Acked-by: Mike Turquette > + > + spin_lock(&

Re: [PATCH 1/2] clk: nomadik: implement the Nomadik clocks properly

2013-06-16 Thread Linus Walleij
On Sun, Jun 9, 2013 at 12:55 PM, Linus Walleij wrote: > The Nomadik clock implementation was a stub just using > fixed clocks. > > This implements the clocks properly instead of relying > on them all being on at boot and leaving them all on. Mike, ping on this. There was some debate on whether

[PATCH 1/2] clk: nomadik: implement the Nomadik clocks properly

2013-06-09 Thread Linus Walleij
The Nomadik clock implementation was a stub just using fixed clocks. This implements the clocks properly instead of relying on them all being on at boot and leaving them all on. The PLLs are on the top locking to the main chrystal oscillator, then the HCLK for the peripherals are below PLL2. The