Re: [PATCH 1/2] sdhci/tegra: Add Device Tree probing support

2011-08-30 Thread Shawn Guo
On Tue, Aug 30, 2011 at 09:01:37AM -0700, Stephen Warren wrote: > Shawn Guo wrote at Monday, August 29, 2011 9:41 PM: > > On Tue, Aug 23, 2011 at 12:15:33PM -0600, Stephen Warren wrote: > > > From: Grant Likely > > > > > > Add hooks to read gpio configuration out of the device tree node. > ... > >

RE: [PATCH 1/2] sdhci/tegra: Add Device Tree probing support

2011-08-30 Thread Stephen Warren
Marc Dietich wrote at Tuesday, August 30, 2011 1:52 AM: ... > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c ... > > @@ -95,12 +94,10 @@ static irqreturn_t carddetect_irq(int irq, void *data) > > > > static int tegra_sdhci_8bit(struct sdhci_host *host, int bus_width

RE: [PATCH 1/2] sdhci/tegra: Add Device Tree probing support

2011-08-30 Thread Stephen Warren
Shawn Guo wrote at Monday, August 29, 2011 9:41 PM: > On Tue, Aug 23, 2011 at 12:15:33PM -0600, Stephen Warren wrote: > > From: Grant Likely > > > > Add hooks to read gpio configuration out of the device tree node. ... > > diff --git a/Documentation/devicetree/bindings/mmc/nvidia-sdhci.txt > > b/

Re: [PATCH 1/2] sdhci/tegra: Add Device Tree probing support

2011-08-30 Thread Marc Dietich
Hi, just a small question, > From: Grant Likely [...] > diff --git a/Documentation/devicetree/bindings/mmc/nvidia-sdhci.txt > b/Documentation/devicetree/bindings/mmc/nvidia-sdhci.txt new file mode > 100644 > index 000..c87f667 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/n

Re: [PATCH 1/2] sdhci/tegra: Add Device Tree probing support

2011-08-29 Thread Shawn Guo
On Tue, Aug 23, 2011 at 12:15:33PM -0600, Stephen Warren wrote: > From: Grant Likely > > Add hooks to read gpio configuration out of the device tree node. > > [grant.likely: Rewrite of original patch from John Bonesio] > Signed-off-by: Grant Likely > [swarren: Fixed tegra_sdhci_get_ro() to retr

Re: [PATCH 1/2] sdhci/tegra: Add Device Tree probing support

2011-08-25 Thread Olof Johansson
On Tue, Aug 23, 2011 at 11:15 AM, Stephen Warren wrote: > From: Grant Likely > > Add hooks to read gpio configuration out of the device tree node. > > [grant.likely: Rewrite of original patch from John Bonesio] > Signed-off-by: Grant Likely > [swarren: Fixed tegra_sdhci_get_ro() to retrieve pdat

Re: [PATCH 1/2] sdhci/tegra: Add Device Tree probing support

2011-08-23 Thread Chris Ball
Hi Stephen, On Tue, Aug 23 2011, Stephen Warren wrote: > From: Grant Likely > > Add hooks to read gpio configuration out of the device tree node. > > [grant.likely: Rewrite of original patch from John Bonesio] > Signed-off-by: Grant Likely > [swarren: Fixed tegra_sdhci_get_ro() to retrieve pdata

[PATCH 1/2] sdhci/tegra: Add Device Tree probing support

2011-08-23 Thread Stephen Warren
From: Grant Likely Add hooks to read gpio configuration out of the device tree node. [grant.likely: Rewrite of original patch from John Bonesio] Signed-off-by: Grant Likely [swarren: Fixed tegra_sdhci_get_ro() to retrieve pdata correctly] [swarren: Reworked to avoid #ifdef CONFIG_OF] [swarren: