[PATCH 1/5 v2] mv643xx_eth: add Device Tree bindings

2013-04-04 Thread Florian Fainelli
This patch adds Device Tree bindings following the already defined bindings at Documentation/devicetree/bindings/marvell.txt. The binding documentation is also enhanced with new optionnal properties required for supporting certain devices (RX/TX queue and SRAM). Since we now have proper support for

Re: [PATCH 1/5 v2] mv643xx_eth: add Device Tree bindings

2013-04-04 Thread Simon Baatz
Hi Florian On Thu, Apr 04, 2013 at 12:27:11PM +0200, Florian Fainelli wrote: > This patch adds Device Tree bindings following the already defined > bindings at Documentation/devicetree/bindings/marvell.txt. The binding > documentation is also enhanced with new optionnal properties required > for s

Re: [PATCH 1/5 v2] mv643xx_eth: add Device Tree bindings

2013-04-05 Thread Florian Fainelli
Hello Simon, First of all, thanks for getting these patches a try! Le 04/04/13 23:29, Simon Baatz a écrit : Hi Florian [snip] if (!mv643xx_eth_version_printed++) pr_notice("MV-643xx 10/100/1000 ethernet driver version %s\n", This is not related to your change, but

Re: [PATCH 1/5 v2] mv643xx_eth: add Device Tree bindings

2013-04-05 Thread Sebastian Hesselbarth
On Fri, Apr 5, 2013 at 11:56 AM, Florian Fainelli wrote: > [snip] Florian, took me a while to try you patches out on Dove but now I fixed all issues. I will comment on all related patches but first I want to comment here. One general note for Dove related patches: You didn't remove the registra

Re: [PATCH 1/5 v2] mv643xx_eth: add Device Tree bindings

2013-04-05 Thread Florian Fainelli
Hello Sebastian, Le 04/05/13 15:58, Sebastian Hesselbarth a écrit : On Fri, Apr 5, 2013 at 11:56 AM, Florian Fainelli wrote: [snip] Florian, took me a while to try you patches out on Dove but now I fixed all issues. I will comment on all related patches but first I want to comment here. On

Re: [PATCH 1/5 v2] mv643xx_eth: add Device Tree bindings

2013-04-05 Thread Jason Gunthorpe
On Fri, Apr 05, 2013 at 03:58:03PM +0200, Sebastian Hesselbarth wrote: > I don't think that the ethernet controller should probe the PHY's on mdio-bus > at all. At least not for DT enabled platforms. I had a look at DT and non-DT > mdio-bus sources, and realized that there is a bus scan for non-DT

Re: [PATCH 1/5 v2] mv643xx_eth: add Device Tree bindings

2013-04-05 Thread Sebastian Hesselbarth
On 04/05/2013 08:04 PM, Jason Gunthorpe wrote: On Fri, Apr 05, 2013 at 03:58:03PM +0200, Sebastian Hesselbarth wrote: I don't think that the ethernet controller should probe the PHY's on mdio-bus at all. At least not for DT enabled platforms. I had a look at DT and non-DT mdio-bus sources, and r