Re: [PATCH 3/7] ARM i.MX6q: Add GPU, VPU, IPU, and OpenVG resets to System Reset Controller (SRC)

2013-01-21 Thread Shawn Guo
On Mon, Jan 21, 2013 at 11:47:12AM -0600, Matt Sealey wrote: > > Yes, maybe the module reset part of the SRC should be implemented as a > > proper device driver in drivers/reset. Then we could use the interrupt > > functionality and WARN_ON(timeout), as you suggest. > > That would be ideal. Maybe

Re: [PATCH 3/7] ARM i.MX6q: Add GPU, VPU, IPU, and OpenVG resets to System Reset Controller (SRC)

2013-01-21 Thread Matt Sealey
On Mon, Jan 21, 2013 at 3:52 AM, Philipp Zabel wrote: > Hi Matt, > > thank you for your comments. > > Am Freitag, den 18.01.2013, 13:57 -0600 schrieb Matt Sealey: >> On Wed, Jan 16, 2013 at 10:13 AM, Philipp Zabel >> wrote: >> >> + >> +static int imx_src_reset(unsigned long sw_reset_idx) >> +{ >

Re: [PATCH 3/7] ARM i.MX6q: Add GPU, VPU, IPU, and OpenVG resets to System Reset Controller (SRC)

2013-01-21 Thread Philipp Zabel
Hi Matt, thank you for your comments. Am Freitag, den 18.01.2013, 13:57 -0600 schrieb Matt Sealey: > On Wed, Jan 16, 2013 at 10:13 AM, Philipp Zabel > wrote: > > The SRC has auto-deasserting reset bits that control reset lines to > > the GPU, VPU, IPU, and OpenVG IP modules. This patch adds a r

Re: [PATCH 3/7] ARM i.MX6q: Add GPU, VPU, IPU, and OpenVG resets to System Reset Controller (SRC)

2013-01-18 Thread Matt Sealey
On Wed, Jan 16, 2013 at 10:13 AM, Philipp Zabel wrote: > The SRC has auto-deasserting reset bits that control reset lines to > the GPU, VPU, IPU, and OpenVG IP modules. This patch adds a reset > controller that can be controlled by those devices using the > reset controller API. > > Signed-off-by:

Re: [PATCH 3/7] ARM i.MX6q: Add GPU, VPU, IPU, and OpenVG resets to System Reset Controller (SRC)

2013-01-16 Thread Shawn Guo
On Wed, Jan 16, 2013 at 05:13:03PM +0100, Philipp Zabel wrote: > #include > #include > #include > +#include Move it one line above to have it sorted. > #include ... > --- /dev/null > +++ b/include/linux/imx-src.h > @@ -0,0 +1,6 @@ > +#ifndef __IMX_SRC_H__ > +#define __IMX_SRC_H__ > + >

[PATCH 3/7] ARM i.MX6q: Add GPU, VPU, IPU, and OpenVG resets to System Reset Controller (SRC)

2013-01-16 Thread Philipp Zabel
The SRC has auto-deasserting reset bits that control reset lines to the GPU, VPU, IPU, and OpenVG IP modules. This patch adds a reset controller that can be controlled by those devices using the reset controller API. Signed-off-by: Philipp Zabel --- .../devicetree/bindings/reset/fsl,imx-src.txt