Re: [PATCH 4/4] ARM: kirkwood: convert orion-wdt to fdt.

2012-03-06 Thread Simon Guinot
Hi Jason, On Thu, Mar 01, 2012 at 06:20:55PM +, Jason Cooper wrote: > Converted register address to a variable so that it could be set from > fdt. Also, pull clock frequency from fdt and clean up failure logic a > bit. > > Same as rtc-mv, this device is used in all kirkwood boards. So, it i

Re: [PATCH 4/4] ARM: kirkwood: convert orion-wdt to fdt.

2012-03-03 Thread Jason
On Fri, Mar 02, 2012 at 11:36:29PM +0100, Andrew Lunn wrote: > > > Andrew Lunn said that he has a patch for plat-orion to use the generic > > > clock framework. I think we should look at that before introducing > > > a hack that will have to be removed again very soon. > > > > I asked him for it e

Re: [PATCH 4/4] ARM: kirkwood: convert orion-wdt to fdt.

2012-03-02 Thread Andrew Lunn
> > Andrew Lunn said that he has a patch for plat-orion to use the generic > > clock framework. I think we should look at that before introducing > > a hack that will have to be removed again very soon. > > I asked him for it earlier [1], apparently it's a very invasive patch > series which breaks

Re: [PATCH 4/4] ARM: kirkwood: convert orion-wdt to fdt.

2012-03-02 Thread Jason
On Fri, Mar 02, 2012 at 04:48:51PM +, Arnd Bergmann wrote: > On Friday 02 March 2012, Jason wrote: > > > > > > That would make wdt@fed20300/clock-frequency a phandle pointing to the > > > root property, which is not what we want here. > > > > The 2 value is not the actual value used i

Re: [PATCH 4/4] ARM: kirkwood: convert orion-wdt to fdt.

2012-03-02 Thread Arnd Bergmann
On Friday 02 March 2012, Jason wrote: > > > > That would make wdt@fed20300/clock-frequency a phandle pointing to the > > root property, which is not what we want here. > > The 2 value is not the actual value used in most drivers [1], > but rather the speed of the system clock [2] (hence,

Re: [PATCH 4/4] ARM: kirkwood: convert orion-wdt to fdt.

2012-03-02 Thread Jason
On Fri, Mar 02, 2012 at 02:56:47PM +, Arnd Bergmann wrote: > On Friday 02 March 2012, Jason wrote: > > Grr... good catch. I originally had this in kirkwood-dreamplug.dts, > > which is always 2. That's not the case in kirkwood.dtsi. What > > I would like to do, and I haven't had time

Re: [PATCH 4/4] ARM: kirkwood: convert orion-wdt to fdt.

2012-03-02 Thread Arnd Bergmann
On Friday 02 March 2012, Jason wrote: > Grr... good catch. I originally had this in kirkwood-dreamplug.dts, > which is always 2. That's not the case in kirkwood.dtsi. What > I would like to do, and I haven't had time to look into it (I thought I > would tackle it later as a refinement :-

Re: [PATCH 4/4] ARM: kirkwood: convert orion-wdt to fdt.

2012-03-02 Thread Jason
On Fri, Mar 02, 2012 at 10:15:11AM +0100, Simon Guinot wrote: > Hi Jason, > > On Thu, Mar 01, 2012 at 06:20:55PM +, Jason Cooper wrote: > > Converted register address to a variable so that it could be set from > > fdt. Also, pull clock frequency from fdt and clean up failure logic a > > bit.

Re: [PATCH 4/4] ARM: kirkwood: convert orion-wdt to fdt.

2012-03-02 Thread Grant Likely
On Thu, 1 Mar 2012 18:20:55 +, Jason Cooper wrote: > Converted register address to a variable so that it could be set from > fdt. Also, pull clock frequency from fdt and clean up failure logic a > bit. > > Same as rtc-mv, this device is used in all kirkwood boards. So, it is > placed in ki

Re: [PATCH 4/4] ARM: kirkwood: convert orion-wdt to fdt.

2012-03-01 Thread Arnd Bergmann
On Thursday 01 March 2012, Jason Cooper wrote: > static int heartbeat = -1; /* module parameter (seconds) */ > static unsigned int wdt_max_duration; /* (seconds) */ > static unsigned int wdt_tclk; > +static unsigned int wdt_reg; > static unsigned long wdt_status; > static DEFINE_SP

[PATCH 4/4] ARM: kirkwood: convert orion-wdt to fdt.

2012-03-01 Thread Jason Cooper
Converted register address to a variable so that it could be set from fdt. Also, pull clock frequency from fdt and clean up failure logic a bit. Same as rtc-mv, this device is used in all kirkwood boards. So, it is placed in kirkwood.dtsi. Signed-off-by: Jason Cooper --- arch/arm/boot/dts/kir