Re: [PATCH 5/5 v2] ARM: kirkwood: convert orion-wdt to fdt.

2012-03-03 Thread Jason
On Sat, Mar 03, 2012 at 10:08:53AM +, Russell King - ARM Linux wrote: > On Fri, Mar 02, 2012 at 06:32:33PM +, Arnd Bergmann wrote: > > On Friday 02 March 2012, Jason Cooper wrote: > > > + wdt_reg = (void __iomem *)TIMER_VIRT_BASE; > > > + > > > + ret = of_address_to_resource(np,

Re: [PATCH 5/5 v2] ARM: kirkwood: convert orion-wdt to fdt.

2012-03-03 Thread Russell King - ARM Linux
On Fri, Mar 02, 2012 at 06:32:33PM +, Arnd Bergmann wrote: > On Friday 02 March 2012, Jason Cooper wrote: > > + wdt_reg = (void __iomem *)TIMER_VIRT_BASE; > > + > > + ret = of_address_to_resource(np, 0, &res); > > + if (ret) { > > + printk(KERN_ERR "invalid addre

Re: [PATCH 5/5 v2] ARM: kirkwood: convert orion-wdt to fdt.

2012-03-02 Thread Arnd Bergmann
On Friday 02 March 2012, Jason wrote: > On Fri, Mar 02, 2012 at 06:32:33PM +, Arnd Bergmann wrote: > > > As I commented before, I think the best approach would be to > > provide a hardcoded resource for the device in the legacy case > > and just use platform_get_resource() to get the resource >

Re: [PATCH 5/5 v2] ARM: kirkwood: convert orion-wdt to fdt.

2012-03-02 Thread Jason
On Fri, Mar 02, 2012 at 06:32:33PM +, Arnd Bergmann wrote: > On Friday 02 March 2012, Jason Cooper wrote: > > + wdt_reg = (void __iomem *)TIMER_VIRT_BASE; > > + > > + ret = of_address_to_resource(np, 0, &res); > > + if (ret) { > > + printk(KERN_ERR "invalid addre

Re: [PATCH 5/5 v2] ARM: kirkwood: convert orion-wdt to fdt.

2012-03-02 Thread Arnd Bergmann
On Friday 02 March 2012, Jason Cooper wrote: > + wdt_reg = (void __iomem *)TIMER_VIRT_BASE; > + > + ret = of_address_to_resource(np, 0, &res); > + if (ret) { > + printk(KERN_ERR "invalid address\n"); > + return ret; > + } > + > + wdt_reg = i

[PATCH 5/5 v2] ARM: kirkwood: convert orion-wdt to fdt.

2012-03-02 Thread Jason Cooper
Converted register address to a variable so that it could be set from fdt. Also, pull clock frequency from fdt and clean up failure logic a bit. Same as rtc-mv, this device is used in all kirkwood boards. So, it is placed in kirkwood.dtsi. Signed-off-by: Jason Cooper --- Changes since v1: