Re: [PATCH 6/7] usb: phy: tegra: Add error handling & clean up.

2013-04-03 Thread Stephen Warren
On 03/19/2013 02:10 PM, Stephen Warren wrote: > On 03/18/2013 06:29 AM, Venu Byravarasu wrote: >> Check return values from all GPIO APIs and handle errors accordingly. > >> Remove clk_disable_unprepare which is no more needed. > > The call to clk_disable_unprepare is incorrect in the current code

Re: [PATCH 6/7] usb: phy: tegra: Add error handling & clean up.

2013-03-19 Thread Stephen Warren
On 03/18/2013 06:29 AM, Venu Byravarasu wrote: > Check return values from all GPIO APIs and handle errors accordingly. > Remove clk_disable_unprepare which is no more needed. The call to clk_disable_unprepare is incorrect in the current code. The way you worded that, it sounds like it's no longer

Re: [PATCH 6/7] usb: phy: tegra: Add error handling & clean up.

2013-03-19 Thread Stephen Warren
On 03/18/2013 06:29 AM, Venu Byravarasu wrote: > Check return values from all GPIO APIs and handle errors accordingly. > Remove clk_disable_unprepare which is no more needed. Patches 6 and 7 each fail checkpatch with "WARNING: line over 80 characters". _

[PATCH 6/7] usb: phy: tegra: Add error handling & clean up.

2013-03-18 Thread Venu Byravarasu
Check return values from all GPIO APIs and handle errors accordingly. Remove clk_disable_unprepare which is no more needed. Signed-off-by: Venu Byravarasu --- drivers/usb/phy/tegra_usb_phy.c | 50 ++ 1 files changed, 39 insertions(+), 11 deletions(-) diff -