Re: [PATCH RESEND] of: add const to struct of_device_id.data

2012-06-24 Thread Uwe Kleine-König
Hello Arnd, On Fri, Jun 22, 2012 at 05:26:22PM +, Arnd Bergmann wrote: > On Friday 22 June 2012, Uwe Kleine-König wrote: > > On Thu, Jun 07, 2012 at 12:20:14PM +0200, Uwe Kleine-König wrote: > > > Drivers should never need to modify the data of a device id. So it can > > > be const which in tu

Re: [PATCH RESEND] of: add const to struct of_device_id.data

2012-06-22 Thread Arnd Bergmann
On Friday 22 June 2012, Uwe Kleine-König wrote: > On Thu, Jun 07, 2012 at 12:20:14PM +0200, Uwe Kleine-König wrote: > > Drivers should never need to modify the data of a device id. So it can > > be const which in turn allows more consts in the driver. > > > > Signed-off-by: Uwe Kleine-König > > -

Re: [PATCH RESEND] of: add const to struct of_device_id.data

2012-06-21 Thread Uwe Kleine-König
On Thu, Jun 07, 2012 at 12:20:14PM +0200, Uwe Kleine-König wrote: > Drivers should never need to modify the data of a device id. So it can > be const which in turn allows more consts in the driver. > > Signed-off-by: Uwe Kleine-König > --- > (Cc += lkml + Grant) > > Hello, > > this might introd

[PATCH RESEND] of: add const to struct of_device_id.data

2012-06-07 Thread Uwe Kleine-König
Drivers should never need to modify the data of a device id. So it can be const which in turn allows more consts in the driver. Signed-off-by: Uwe Kleine-König --- (Cc += lkml + Grant) Hello, this might introduce warnings in drivers that access the data member without using const, so this is de