On Thu, Nov 22, 2012 at 10:31:48PM +0530, Viresh Kumar wrote:
> On 22 November 2012 21:16, Lee Jones wrote:
> > The STMPE GPIO controller can't be used by Device Tree yet in
> > any case, because it doesn't have an IRQ domain. This is
> > compulsory, or it won't work. Have you tried to test this
>
On 23 November 2012 21:13, Lee Jones wrote:
> No, in DT devices named as part of the hiearchy, so you'd have:
>
> soc-u9500/i2c@80004000/stmpe1601@40/stmpe_keypad
> soc-u9500/i2c@80004000/stmpe1601@41/stmpe_keypad
> ... etc
Obviously. How could i miss this naming :(
Okay, so i need to pass -1 an
On Fri, 23 Nov 2012, Viresh Kumar wrote:
> On 23 November 2012 15:06, Lee Jones wrote:
> > On Fri, 23 Nov 2012, Viresh Kumar wrote:
> >> pdev = platform_device_alloc(cell->name, id + cell->id);
> >>
> >> This is required when we have multiple instances of MFD device present
> >> on board. H
On 23 November 2012 15:06, Lee Jones wrote:
> On Fri, 23 Nov 2012, Viresh Kumar wrote:
>> pdev = platform_device_alloc(cell->name, id + cell->id);
>>
>> This is required when we have multiple instances of MFD device present
>> on board. How do you want me to handle this ?
>
> There are lots
On Fri, 23 Nov 2012, Viresh Kumar wrote:
> On 22 November 2012 16:54, Lee Jones wrote:
> >> diff --git a/Documentation/devicetree/bindings/mfd/stmpe.txt
> >> b/Documentation/devicetree/bindings/mfd/stmpe.txt
> >> +Optional properties:
> >> +- irq-trigger: IRQ trigger to use for the interrupt to
On Fri, 23 Nov 2012, Viresh Kumar wrote:
> On 22 November 2012 16:54, Lee Jones wrote:
> >> diff --git a/Documentation/devicetree/bindings/mfd/stmpe.txt
> >> b/Documentation/devicetree/bindings/mfd/stmpe.txt
> >> stmpe1601: stmpe1601@40 {
>
> >> + id = <0>;
> >
> > Don't do th
On Fri, 23 Nov 2012, Shiraz Hashim wrote:
> On Thu, Nov 22, 2012 at 10:31:48PM +0530, Viresh Kumar wrote:
> > On 22 November 2012 21:16, Lee Jones wrote:
> > > The STMPE GPIO controller can't be used by Device Tree yet in
> > > any case, because it doesn't have an IRQ domain. This is
> > > compul
On Thu, 22 Nov 2012, Viresh Kumar wrote:
> On 22 November 2012 21:16, Lee Jones wrote:
> >> >> diff --git a/Documentation/devicetree/bindings/mfd/stmpe.txt
> >> >> b/Documentation/devicetree/bindings/mfd/stmpe.txt
> >> >> +- irq-over-gpio: bool, true if gpio is used to get irq
> >> >> +- irq-gpi
On 22 November 2012 16:54, Lee Jones wrote:
>> diff --git a/Documentation/devicetree/bindings/mfd/stmpe.txt
>> b/Documentation/devicetree/bindings/mfd/stmpe.txt
>> stmpe1601: stmpe1601@40 {
>> + id = <0>;
>
> Don't do this. Device IDs are Linux specific.
Hi Lee,
This is id of
On 22 November 2012 16:54, Lee Jones wrote:
>> diff --git a/Documentation/devicetree/bindings/mfd/stmpe.txt
>> b/Documentation/devicetree/bindings/mfd/stmpe.txt
>> +Optional properties:
>> +- irq-trigger: IRQ trigger to use for the interrupt to the host
>> +- irq-invert-polarity: bool, IRQ line i
On 22 November 2012 21:16, Lee Jones wrote:
>> >> diff --git a/Documentation/devicetree/bindings/mfd/stmpe.txt
>> >> b/Documentation/devicetree/bindings/mfd/stmpe.txt
>> >> +- irq-over-gpio: bool, true if gpio is used to get irq
>> >> +- irq-gpios: gpio number over which irq will be requested (si
> > Big fat NACK.
> >
> > You've just overwritten the current implementation with your own.
> > Please take time to understand the mechanisms in place before
> > you submit any changes or additions to it.
>
> :)
>
> My fault. Comments on all overwritten stuff accepted
Okay, great.
> >> diff --g
On 22 November 2012 16:54, Lee Jones wrote:
> Big fat NACK.
>
> You've just overwritten the current implementation with your own.
> Please take time to understand the mechanisms in place before
> you submit any changes or additions to it.
:)
My fault. Comments on all overwritten stuff accepted
> From: Vipul Kumar Samar
>
> This patch extends existing DT support for stmpe devices. Bindings are
> mentioned
> in binding document.
>
> Signed-off-by: Vipul Kumar Samar
> Signed-off-by: Viresh Kumar
> ---
> V1->V2:
> --
> - Partial DT support was already there, which i missed earlier.
From: Vipul Kumar Samar
This patch extends existing DT support for stmpe devices. Bindings are mentioned
in binding document.
Signed-off-by: Vipul Kumar Samar
Signed-off-by: Viresh Kumar
---
V1->V2:
--
- Partial DT support was already there, which i missed earlier.
- Now, this patch is an
15 matches
Mail list logo
