Re: [PATCH V3] of: Set the DMA mask to 64 bits when dma_addr_t is 64-bits

2013-07-08 Thread Russell King - ARM Linux
On Fri, Jul 05, 2013 at 12:33:21PM -0700, Laura Abbott wrote: On 7/3/2013 7:15 AM, Ming Lei wrote: On Sat, Apr 27, 2013 at 5:32 AM, Rob Herring robherri...@gmail.com wrote: On 04/26/2013 03:31 PM, Laura Abbott wrote: Currently, of_platform_device_create_pdata always sets the coherent DMA mask

Re: [PATCH V3] of: Set the DMA mask to 64 bits when dma_addr_t is 64-bits

2013-07-08 Thread Russell King - ARM Linux
On Mon, Jul 08, 2013 at 06:03:57PM +0800, Ming Lei wrote: On Sat, Jul 6, 2013 at 5:15 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Sat, Jul 06, 2013 at 10:21:05AM +0800, Ming Lei wrote: But please see below words in Documentation/DMA-API.txt: Further, the

Re: [PATCH V3] of: Set the DMA mask to 64 bits when dma_addr_t is 64-bits

2013-07-08 Thread Laura Abbott
On 7/8/2013 3:42 AM, Russell King - ARM Linux wrote: The problem is the way the arm_dma_limit is set up, all dma allocations are currently broken regardless of if the actual device supports 64-bit addresses or not. Please explain this statement. The statement was a bit shortsighted given

Re: [PATCH V3] of: Set the DMA mask to 64 bits when dma_addr_t is 64-bits

2013-07-05 Thread Laura Abbott
On 7/3/2013 7:15 AM, Ming Lei wrote: On Sat, Apr 27, 2013 at 5:32 AM, Rob Herring robherri...@gmail.com wrote: On 04/26/2013 03:31 PM, Laura Abbott wrote: Currently, of_platform_device_create_pdata always sets the coherent DMA mask to 32 bits. On ARM systems without CONFIG_ZONE_DMA,

Re: [PATCH V3] of: Set the DMA mask to 64 bits when dma_addr_t is 64-bits

2013-07-05 Thread Russell King - ARM Linux
On Wed, Jul 03, 2013 at 10:15:50PM +0800, Ming Lei wrote: Without the patch, LPAE enabled board may not boot at all, but looks it still isn't in -next tree. But I am wondering if it is a correct approach, because enabling LPAE doesn't mean the I/O devices can support DMA to/from 64bit

[PATCH V3] of: Set the DMA mask to 64 bits when dma_addr_t is 64-bits

2013-04-26 Thread Laura Abbott
Currently, of_platform_device_create_pdata always sets the coherent DMA mask to 32 bits. On ARM systems without CONFIG_ZONE_DMA, arm_dma_limit gets set to ~0 or 0x on LPAE based systems. Since arm_dma_limit represents the smallest dma_mask on the system, the default of 32 bits

Re: [PATCH V3] of: Set the DMA mask to 64 bits when dma_addr_t is 64-bits

2013-04-26 Thread Catalin Marinas
On Fri, Apr 26, 2013 at 09:31:06PM +0100, Laura Abbott wrote: Currently, of_platform_device_create_pdata always sets the coherent DMA mask to 32 bits. On ARM systems without CONFIG_ZONE_DMA, arm_dma_limit gets set to ~0 or 0x on LPAE based systems. Since arm_dma_limit

Re: [PATCH V3] of: Set the DMA mask to 64 bits when dma_addr_t is 64-bits

2013-04-26 Thread Rob Herring
On 04/26/2013 03:31 PM, Laura Abbott wrote: Currently, of_platform_device_create_pdata always sets the coherent DMA mask to 32 bits. On ARM systems without CONFIG_ZONE_DMA, arm_dma_limit gets set to ~0 or 0x on LPAE based systems. Since arm_dma_limit represents the smallest