Re: [PATCH V3 2/4] pinctrl: Add SPEAr pinctrl drivers

2012-04-15 Thread Viresh Kumar
On 4/13/2012 9:38 PM, Stephen Warren wrote: > of_iomap isn't a devm function, so youo need to unmap in remove(), and > in probe()'s error paths. > > Or of course, you could just implement devm_of_iomap(); it's probably > very simple to do. Implemented devm_of_iomap(). -- viresh

Re: [PATCH V3 2/4] pinctrl: Add SPEAr pinctrl drivers

2012-04-13 Thread Stephen Warren
On 04/11/2012 11:24 PM, Viresh Kumar wrote: > This adds pinctrl driver for SPEAr platform. It also updates MAINTAINERS file > for SPEAr pinctrl drivers. > +int __devinit spear_pinctrl_probe(struct platform_device *pdev, > + struct spear_pinctrl_machdata *machdata) ... > + pmx->vbas

Re: [PATCH V3 2/4] pinctrl: Add SPEAr pinctrl drivers

2012-04-13 Thread Linus Walleij
On Thu, Apr 12, 2012 at 7:24 AM, Viresh Kumar wrote: > This adds pinctrl driver for SPEAr platform. It also updates MAINTAINERS file > for SPEAr pinctrl drivers. > > Signed-off-by: Viresh Kumar Looks good to me. Acked-by: Linus Walleij Yours, Linus Walleij

[PATCH V3 2/4] pinctrl: Add SPEAr pinctrl drivers

2012-04-11 Thread Viresh Kumar
This adds pinctrl driver for SPEAr platform. It also updates MAINTAINERS file for SPEAr pinctrl drivers. Signed-off-by: Viresh Kumar --- MAINTAINERS | 23 +-- drivers/pinctrl/Kconfig |2 + drivers/pinctrl/Makefile |2 + drivers/pinct