Re: [PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver

2012-11-28 Thread Lee Jones
On Wed, 28 Nov 2012, Viresh Kumar wrote: > On 28 November 2012 01:25, Rabin Vincent wrote: > > 2012/11/27 Viresh Kumar : > >> On 27 November 2012 14:10, Lee Jones wrote: > >> I haven't seen this in any of SPEAr boards i have worked on. Maybe Rabin > >> would have, that's why he added that part o

Re: [PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver

2012-11-27 Thread Viresh Kumar
On 28 November 2012 01:25, Rabin Vincent wrote: > 2012/11/27 Viresh Kumar : >> On 27 November 2012 14:10, Lee Jones wrote: >> I haven't seen this in any of SPEAr boards i have worked on. Maybe Rabin >> would have, that's why he added that part of code :) >> >> @Rabin/Linus: Do you remember why ha

Re: [PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver

2012-11-27 Thread Rabin Vincent
2012/11/27 Viresh Kumar : > On 27 November 2012 14:10, Lee Jones wrote: > I haven't seen this in any of SPEAr boards i have worked on. Maybe Rabin > would have, that's why he added that part of code :) > > @Rabin/Linus: Do you remember why have you added this in stmpe driver: > > + if (stmpe

Re: [PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver

2012-11-27 Thread Viresh Kumar
On 27 November 2012 14:10, Lee Jones wrote: > On Tue, 27 Nov 2012, Viresh Kumar wrote: >> Problem is with invert polarity, which the interrupt controller is not aware >> of. >> For example, suppose interrupt controller needs Rising edge interrupt, but >> the board has inverted the line between st

Re: [PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver

2012-11-27 Thread Lee Jones
On Tue, 27 Nov 2012, Viresh Kumar wrote: > On 27 November 2012 08:10, Viresh Kumar wrote: > > On 27 November 2012 00:10, Grant Likely wrote: > >> It would actually be good to ask the interrupt controller driver what > >> kind of interrupt signal it expects for a given interrupt line. That > >> s

Re: [PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver

2012-11-26 Thread Viresh Kumar
On 27 November 2012 08:10, Viresh Kumar wrote: > On 27 November 2012 00:10, Grant Likely wrote: >> It would actually be good to ask the interrupt controller driver what >> kind of interrupt signal it expects for a given interrupt line. That >> should also solve the problem and I think it would be

Re: [PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver

2012-11-26 Thread Viresh Kumar
On 27 November 2012 00:10, Grant Likely wrote: > Ah, so it is configuring the way the device emits interrupts; not how > the interrupt controller processes them. Fair enough. Finally i am able to convince somebody that stmpe is different :) > It would actually be good to ask the interrupt contro

Re: [PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver

2012-11-26 Thread Grant Likely
On Fri, 23 Nov 2012 23:03:47 +0530, Viresh Kumar wrote: > On 23 November 2012 15:11, Grant Likely wrote: > > On Fri, 23 Nov 2012 00:26:20 +0530, Viresh Kumar > > wrote: > > >> + - irq-trigger : IRQ trigger to use for the > >> interrupt to the host > >> + - irq-invert-po

Re: [PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver

2012-11-26 Thread Lee Jones
On Fri, 23 Nov 2012, Viresh Kumar wrote: > On 23 November 2012 15:11, Grant Likely wrote: > > On Fri, 23 Nov 2012 00:26:20 +0530, Viresh Kumar > > wrote: > > >> + - irq-trigger : IRQ trigger to use for the > >> interrupt to the host > >> + - irq-invert-polarity

Re: [PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver

2012-11-23 Thread Viresh Kumar
On 23 November 2012 15:11, Grant Likely wrote: > On Fri, 23 Nov 2012 00:26:20 +0530, Viresh Kumar > wrote: >> + - irq-trigger : IRQ trigger to use for the interrupt >> to the host >> + - irq-invert-polarity : bool, IRQ line is connected with >> reversed pol

Re: [PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver

2012-11-23 Thread Lee Jones
On Fri, 23 Nov 2012, Viresh Kumar wrote: > From: Vipul Kumar Samar > > This patch extends existing DT support for stmpe devices. This updates: > - DT support from stmpe SPI and I2C drivers > - missing header files in stmpe.c > - stmpe_of_probe() with pwm, rotator and new bindings. > - Bindings a

Re: [PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver

2012-11-23 Thread Grant Likely
On Fri, 23 Nov 2012 00:26:20 +0530, Viresh Kumar wrote: > From: Vipul Kumar Samar > > This patch extends existing DT support for stmpe devices. This updates: > - DT support from stmpe SPI and I2C drivers > - missing header files in stmpe.c > - stmpe_of_probe() with pwm, rotator and new bindings

[PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver

2012-11-22 Thread Viresh Kumar
From: Vipul Kumar Samar This patch extends existing DT support for stmpe devices. This updates: - DT support from stmpe SPI and I2C drivers - missing header files in stmpe.c - stmpe_of_probe() with pwm, rotator and new bindings. - Bindings are updated in binding document. Signed-off-by: Vipul Ku