Re: [PATCH V6] mfd: stmpe: Update DT support for stmpe driver

2012-12-06 Thread Linus Walleij
On Thu, Dec 6, 2012 at 4:43 PM, Viresh Kumar wrote: > From: Vipul Kumar Samar > > This patch extends existing DT support for stmpe devices. This updates: > - missing header files in stmpe.c > - stmpe_of_probe() with pwm, rotator and new bindings. > - Bindings are updated in binding document. > >

Re: [PATCH V6] mfd: stmpe: Update DT support for stmpe driver

2012-12-06 Thread Viresh Kumar
On 6 December 2012 22:10, Lee Jones wrote: > On Thu, 06 Dec 2012, Viresh Kumar wrote: >> + pdata->id = -1; > > Perhaps PLATFORM_DEVID_AUTO would be better? Why do we want to allocate device id's for it? Multiple devices are already distinguished and so -1 would be better. >> + pdata->irq

Re: [PATCH V6] mfd: stmpe: Update DT support for stmpe driver

2012-12-06 Thread Lee Jones
On Thu, 06 Dec 2012, Viresh Kumar wrote: > From: Vipul Kumar Samar > > This patch extends existing DT support for stmpe devices. This updates: > - missing header files in stmpe.c > - stmpe_of_probe() with pwm, rotator and new bindings. > - Bindings are updated in binding document. > > Acked-by:

[PATCH V6] mfd: stmpe: Update DT support for stmpe driver

2012-12-06 Thread Viresh Kumar
From: Vipul Kumar Samar This patch extends existing DT support for stmpe devices. This updates: - missing header files in stmpe.c - stmpe_of_probe() with pwm, rotator and new bindings. - Bindings are updated in binding document. Acked-by: Lee Jones Signed-off-by: Vipul Kumar Samar Signed-off-b