Re: [PATCH v1 02/12] input: matrix-keymap: func call coding style nit

2013-06-22 Thread Marek Vasut
Dear Gerhard Sittig, > On Sat, Jun 22, 2013 at 04:18 +0200, Marek Vasut wrote: > > ret = matrix_keypad_map_key(input_dev, rows, cols, row_shift, key); > > if (ret) > > > > return ret; > > > > Now that you return correct error codes from above, you should propagate > > them through. > > Will

Re: [PATCH v1 02/12] input: matrix-keymap: func call coding style nit

2013-06-22 Thread Gerhard Sittig
On Sat, Jun 22, 2013 at 04:18 +0200, Marek Vasut wrote: > > ret = matrix_keypad_map_key(input_dev, rows, cols, row_shift, key); > if (ret) > return ret; > > Now that you return correct error codes from above, you should propagate them > through. Will do, queued for v2. Thank you for revi

Re: [PATCH v1 02/12] input: matrix-keymap: func call coding style nit

2013-06-21 Thread Marek Vasut
Dear Gerhard Sittig, > make the matrix_keypad_map_key() routine return an error code > instead of boolean, as its name suggests an action and not a query > > Signed-off-by: Gerhard Sittig > --- > drivers/input/matrix-keymap.c | 19 ++- > 1 file changed, 10 insertions(+), 9 del

[PATCH v1 02/12] input: matrix-keymap: func call coding style nit

2013-06-21 Thread Gerhard Sittig
make the matrix_keypad_map_key() routine return an error code instead of boolean, as its name suggests an action and not a query Signed-off-by: Gerhard Sittig --- drivers/input/matrix-keymap.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/inpu