Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-27 Thread Zach Sadecki
On 03/13/2012 09:35 AM, Rob Herring wrote: + ahb@8008 { + fec@800f { Use generic names: ethernet@800f Generic is good, but consistency is better, IMHO. grepping existing dts files in 3.2.9 finds 6 instances of fec@ and 0 instances of ethernet@ +

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-21 Thread Dong Aisheng
On Tue, Mar 20, 2012 at 09:17:48PM +0800, Lothar Waßmann wrote: Hi, Dong Aisheng writes: On Mon, Mar 19, 2012 at 3:02 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Mon, 19 Mar 2012 17:49:02 +0100, Lothar Waßmann l...@karo-electronics.de wrote: Hi, Grant Likely

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-20 Thread Dong Aisheng
On Mon, Mar 19, 2012 at 3:02 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Mon, 19 Mar 2012 17:49:02 +0100, Lothar Waßmann l...@karo-electronics.de wrote: Hi, Grant Likely writes: On Mon, 19 Mar 2012 07:54:33 +0100, Lothar Waßmann l...@karo-electronics.de wrote: Grant Likely

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-20 Thread Lothar Waßmann
Hi, Dong Aisheng writes: On Mon, Mar 19, 2012 at 3:02 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Mon, 19 Mar 2012 17:49:02 +0100, Lothar Waßmann l...@karo-electronics.de wrote: Hi, Grant Likely writes: On Mon, 19 Mar 2012 07:54:33 +0100, Lothar Waßmann

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-19 Thread Lothar Waßmann
Hi, Grant Likely writes: On Fri, 16 Mar 2012 11:01:35 +0800, Dong Aisheng aisheng.d...@freescale.com wrote: On Thu, Mar 15, 2012 at 07:22:04PM +0800, Lothar Waßmann wrote: Hi, Dong Aisheng writes: On Thu, Mar 15, 2012 at 02:53:29PM +0800, Lothar Waßmann wrote: Hi,

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-19 Thread Grant Likely
On Mon, 19 Mar 2012 07:54:33 +0100, Lothar Waßmann l...@karo-electronics.de wrote: Grant Likely writes: On Fri, 16 Mar 2012 11:01:35 +0800, Dong Aisheng aisheng.d...@freescale.com wrote: On Thu, Mar 15, 2012 at 07:22:04PM +0800, Lothar Waßmann wrote: Dong Aisheng writes: On

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-19 Thread Lothar Waßmann
Hi, Grant Likely writes: On Mon, 19 Mar 2012 07:54:33 +0100, Lothar Waßmann l...@karo-electronics.de wrote: Grant Likely writes: On Fri, 16 Mar 2012 11:01:35 +0800, Dong Aisheng aisheng.d...@freescale.com wrote: On Thu, Mar 15, 2012 at 07:22:04PM +0800, Lothar Waßmann wrote:

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-19 Thread Grant Likely
On Mon, 19 Mar 2012 17:49:02 +0100, Lothar Waßmann l...@karo-electronics.de wrote: Hi, Grant Likely writes: On Mon, 19 Mar 2012 07:54:33 +0100, Lothar Waßmann l...@karo-electronics.de wrote: Grant Likely writes: On Fri, 16 Mar 2012 11:01:35 +0800, Dong Aisheng

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-18 Thread Grant Likely
On Fri, 16 Mar 2012 11:01:35 +0800, Dong Aisheng aisheng.d...@freescale.com wrote: On Thu, Mar 15, 2012 at 07:22:04PM +0800, Lothar Waßmann wrote: Hi, Dong Aisheng writes: On Thu, Mar 15, 2012 at 02:53:29PM +0800, Lothar Waßmann wrote: Hi, Dong Aisheng writes: On

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-16 Thread Lothar Waßmann
Hi, Dong Aisheng writes: On Thu, Mar 15, 2012 at 07:22:04PM +0800, Lothar Waßmann wrote: [...] My proposal is only set the fixed part(first two octets) in board dts file, each board knows it's value, and read the left 4 octets from OCOTP dynamically. The OUI part is three bytes, not two!

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-16 Thread Dong Aisheng
On Fri, Mar 16, 2012 at 03:48:13PM +0800, Lothar Waßmann wrote: Hi, Dong Aisheng writes: On Thu, Mar 15, 2012 at 07:22:04PM +0800, Lothar Waßmann wrote: [...] My proposal is only set the fixed part(first two octets) in board dts file, each board knows it's value, and read the left 4

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-15 Thread Dong Aisheng
On Thu, Mar 15, 2012 at 02:53:29PM +0800, Lothar Waßmann wrote: Hi, Dong Aisheng writes: On Wed, Mar 14, 2012 at 10:16:43PM +0800, s.ha...@pengutronix.de wrote: On Wed, Mar 14, 2012 at 08:45:23PM +0800, Dong Aisheng wrote: On Wed, Mar 14, 2012 at 01:23:51AM +0800, Grant Likely wrote:

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-15 Thread Lothar Waßmann
Hi, Dong Aisheng writes: On Thu, Mar 15, 2012 at 02:53:29PM +0800, Lothar Waßmann wrote: Hi, Dong Aisheng writes: On Wed, Mar 14, 2012 at 10:16:43PM +0800, s.ha...@pengutronix.de wrote: On Wed, Mar 14, 2012 at 08:45:23PM +0800, Dong Aisheng wrote: On Wed, Mar 14, 2012 at

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-15 Thread s.ha...@pengutronix.de
On Thu, Mar 15, 2012 at 06:59:28PM +0800, Dong Aisheng wrote: On Thu, Mar 15, 2012 at 02:53:29PM +0800, Lothar Waßmann wrote: Hi, Dong Aisheng writes: On Wed, Mar 14, 2012 at 10:16:43PM +0800, s.ha...@pengutronix.de wrote: On Wed, Mar 14, 2012 at 08:45:23PM +0800, Dong Aisheng

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-15 Thread Dong Aisheng
On Thu, Mar 15, 2012 at 07:24:19PM +0800, s.ha...@pengutronix.de wrote: On Thu, Mar 15, 2012 at 06:59:28PM +0800, Dong Aisheng wrote: On Thu, Mar 15, 2012 at 02:53:29PM +0800, Lothar Waßmann wrote: Hi, Dong Aisheng writes: On Wed, Mar 14, 2012 at 10:16:43PM +0800,

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-14 Thread Marek Vasut
Dear Shawn Guo, On Tue, Mar 13, 2012 at 11:23:51AM -0600, Grant Likely wrote: ... + apb@8000 { + compatible = simple-bus; + #address-cells = 1; + #size-cells = 1; + reg = 0x8000 0x8; + ranges; + +

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-14 Thread Marek Vasut
Dear Dong Aisheng, On Tue, Mar 13, 2012 at 09:35:43AM -0500, Rob Herring wrote: On 03/13/2012 03:47 AM, Dong Aisheng wrote: From: Dong Aisheng dong.aish...@linaro.org This patch includes basic dt support which can boot via nfs rootfs. Signed-off-by: Dong Aisheng

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-14 Thread Dong Aisheng
On Wed, Mar 14, 2012 at 01:23:51AM +0800, Grant Likely wrote: On Tue, 13 Mar 2012 16:47:04 +0800, Dong Aisheng b29...@freescale.com wrote: From: Dong Aisheng dong.aish...@linaro.org This patch includes basic dt support which can boot via nfs rootfs. Signed-off-by: Dong Aisheng

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-14 Thread Rob Herring
On 03/14/2012 01:23 AM, Dong Aisheng wrote: On Tue, Mar 13, 2012 at 09:35:43AM -0500, Rob Herring wrote: On 03/13/2012 03:47 AM, Dong Aisheng wrote: From: Dong Aisheng dong.aish...@linaro.org This patch includes basic dt support which can boot via nfs rootfs. Signed-off-by: Dong Aisheng

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-14 Thread s.ha...@pengutronix.de
On Wed, Mar 14, 2012 at 08:45:23PM +0800, Dong Aisheng wrote: On Wed, Mar 14, 2012 at 01:23:51AM +0800, Grant Likely wrote: On Tue, 13 Mar 2012 16:47:04 +0800, Dong Aisheng b29...@freescale.com wrote: From: Dong Aisheng dong.aish...@linaro.org This patch includes basic dt support

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-14 Thread Sascha Hauer
On Tue, Mar 13, 2012 at 04:47:04PM +0800, Dong Aisheng wrote: From: Dong Aisheng dong.aish...@linaro.org This patch includes basic dt support which can boot via nfs rootfs. Signed-off-by: Dong Aisheng dong.aish...@linaro.org --- Documentation/devicetree/bindings/arm/fsl.txt |4 +

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-14 Thread Dong Aisheng
On Wed, Mar 14, 2012 at 09:05:34PM +0800, Rob Herring wrote: On 03/14/2012 01:23 AM, Dong Aisheng wrote: On Tue, Mar 13, 2012 at 09:35:43AM -0500, Rob Herring wrote: On 03/13/2012 03:47 AM, Dong Aisheng wrote: From: Dong Aisheng dong.aish...@linaro.org This patch includes basic dt

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-14 Thread Dong Aisheng
On Thu, Mar 15, 2012 at 03:41:23AM +0800, Sascha Hauer wrote: On Tue, Mar 13, 2012 at 04:47:04PM +0800, Dong Aisheng wrote: From: Dong Aisheng dong.aish...@linaro.org This patch includes basic dt support which can boot via nfs rootfs. Signed-off-by: Dong Aisheng

[PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-13 Thread Dong Aisheng
From: Dong Aisheng dong.aish...@linaro.org This patch includes basic dt support which can boot via nfs rootfs. Signed-off-by: Dong Aisheng dong.aish...@linaro.org --- Documentation/devicetree/bindings/arm/fsl.txt |4 + arch/arm/boot/dts/imx28-evk.dts | 31 +

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-13 Thread Rob Herring
On 03/13/2012 03:47 AM, Dong Aisheng wrote: From: Dong Aisheng dong.aish...@linaro.org This patch includes basic dt support which can boot via nfs rootfs. Signed-off-by: Dong Aisheng dong.aish...@linaro.org --- Documentation/devicetree/bindings/arm/fsl.txt |4 +

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-13 Thread Grant Likely
On Tue, 13 Mar 2012 16:47:04 +0800, Dong Aisheng b29...@freescale.com wrote: From: Dong Aisheng dong.aish...@linaro.org This patch includes basic dt support which can boot via nfs rootfs. Signed-off-by: Dong Aisheng dong.aish...@linaro.org ---

Re: [PATCH v1 1/5] ARM: imx28: add basic dt support

2012-03-13 Thread Grant Likely
On Tue, 13 Mar 2012 09:59:39 -0500, Zach Sadecki zsade...@itwatchdogs.com wrote: On 03/13/2012 09:35 AM, Rob Herring wrote: + ahb@8008 { + fec@800f { Use generic names: ethernet@800f Generic is good, but consistency is better, IMHO. grepping existing dts files