Re: [PATCH v2] hwmon: Driver for Maxim MAX6697 and compatibles

2013-01-14 Thread Jean Delvare
Hi Guenter, Sorry for the late review, originally I planned to do a quick review but apparently I am simply unable to do that. So here comes a complete review. As usual, pick what you agree with and feel free to ignore the rest :) On Sun, 16 Dec 2012 21:33:09 -0800, Guenter Roeck wrote: Add

Re: [PATCH v2] hwmon: Driver for Maxim MAX6697 and compatibles

2013-01-14 Thread Guenter Roeck
On Mon, Jan 14, 2013 at 10:24:04PM +0100, Jean Delvare wrote: Hi Guenter, Sorry for the late review, originally I planned to do a quick review but apparently I am simply unable to do that. So here comes a complete review. As usual, pick what you agree with and feel free to ignore the rest

Re: [PATCH v2] hwmon: Driver for Maxim MAX6697 and compatibles

2013-01-12 Thread Jean Delvare
Hi Guenter, On Fri, 11 Jan 2013 09:41:05 -0800, Guenter Roeck wrote: On Sun, Dec 16, 2012 at 09:33:09PM -0800, Guenter Roeck wrote: Add support for MAX6581, MAX6602, MAX6622, MAX6636, MAX6689, MAX6693, MAX6694, MAX6697, MAX6698, and MAX6699 temperature sensors Signed-off-by: Guenter

Re: [PATCH v2] hwmon: Driver for Maxim MAX6697 and compatibles

2013-01-11 Thread Guenter Roeck
On Sun, Dec 16, 2012 at 09:33:09PM -0800, Guenter Roeck wrote: Add support for MAX6581, MAX6602, MAX6622, MAX6636, MAX6689, MAX6693, MAX6694, MAX6697, MAX6698, and MAX6699 temperature sensors Signed-off-by: Guenter Roeck li...@roeck-us.net I plan to line this driver up for 3.9. Only change

[PATCH v2] hwmon: Driver for Maxim MAX6697 and compatibles

2012-12-16 Thread Guenter Roeck
Add support for MAX6581, MAX6602, MAX6622, MAX6636, MAX6689, MAX6693, MAX6694, MAX6697, MAX6698, and MAX6699 temperature sensors Signed-off-by: Guenter Roeck li...@roeck-us.net --- v2: - Add suppport for platform data and devicetree based chip initialization - Drop S_IRUGOWU macro: