Re: [PATCH v2] i2c: core: make it possible to match a pure device tree driver

2013-06-18 Thread Linus Walleij
On Tue, Jun 18, 2013 at 9:33 AM, Wolfram Sang w...@the-dreams.de wrote: On Mon, Jun 17, 2013 at 11:15:30PM +0100, Grant Likely wrote: On Mon, Jun 17, 2013 at 5:33 PM, Linus Walleij linus.wall...@linaro.org wrote: OK that works for me, I'm not in any hurry. Deferring by a merge window isn't

Re: [PATCH v2] i2c: core: make it possible to match a pure device tree driver

2013-06-17 Thread Stephen Warren
On 05/22/2013 01:56 AM, Linus Walleij wrote: On Mon, May 13, 2013 at 10:18 PM, Linus Walleij linus.wall...@linaro.org wrote: This tries to address an issue found when writing an MFD driver for the Nomadik STw481x PMICs: as the platform is using device tree exclusively I want to specify the

Re: [PATCH v2] i2c: core: make it possible to match a pure device tree driver

2013-06-17 Thread Stephen Warren
On 06/17/2013 10:33 AM, Linus Walleij wrote: On Mon, Jun 17, 2013 at 5:48 PM, Stephen Warren swar...@wwwdotorg.org wrote: This has just shown up in next-20130617, and breaks at least the TPS65910 and TPS62360 drivers, since they assume that the id parameter passed to probe is non-NULL.

Re: [PATCH v2] i2c: core: make it possible to match a pure device tree driver

2013-06-17 Thread Grant Likely
On Mon, Jun 17, 2013 at 5:33 PM, Linus Walleij linus.wall...@linaro.org wrote: On Mon, Jun 17, 2013 at 5:48 PM, Stephen Warren swar...@wwwdotorg.org wrote: This has just shown up in next-20130617, and breaks at least the TPS65910 and TPS62360 drivers, since they assume that the id parameter

Re: [PATCH v2] i2c: core: make it possible to match a pure device tree driver

2013-06-17 Thread Stephen Warren
On 06/17/2013 04:15 PM, Grant Likely wrote: On Mon, Jun 17, 2013 at 5:33 PM, Linus Walleij linus.wall...@linaro.org wrote: On Mon, Jun 17, 2013 at 5:48 PM, Stephen Warren swar...@wwwdotorg.org wrote: This has just shown up in next-20130617, and breaks at least the TPS65910 and TPS62360

Re: [PATCH v2] i2c: core: make it possible to match a pure device tree driver

2013-06-12 Thread Grant Likely
On Fri, 7 Jun 2013 23:32:42 +0200, Wolfram Sang w...@the-dreams.de wrote: ... I2C devices probed from device tree should subsequently be fixed to handle the case where of_match_table() is used (I think none of them do that today), and platforms should fix their device trees to use

Re: [PATCH v2] i2c: core: make it possible to match a pure device tree driver

2013-06-12 Thread Grant Likely
On Mon, 10 Jun 2013 15:40:14 +0200, Wolfram Sang w...@the-dreams.de wrote: On Mon, Jun 10, 2013 at 02:18:17PM +0200, Linus Walleij wrote: On Fri, Jun 7, 2013 at 11:32 PM, Wolfram Sang w...@the-dreams.de wrote: ... I2C devices probed from device tree should subsequently be fixed to

Re: [PATCH v2] i2c: core: make it possible to match a pure device tree driver

2013-06-10 Thread Linus Walleij
On Fri, Jun 7, 2013 at 11:32 PM, Wolfram Sang w...@the-dreams.de wrote: ... I2C devices probed from device tree should subsequently be fixed to handle the case where of_match_table() is used (I think none of them do that today), and platforms should fix their device trees to use compatible

Re: [PATCH v2] i2c: core: make it possible to match a pure device tree driver

2013-05-30 Thread Linus Walleij
On Wed, May 22, 2013 at 9:56 AM, Linus Walleij linus.wall...@linaro.org wrote: On Mon, May 13, 2013 at 10:18 PM, Linus Walleij linus.wall...@linaro.org wrote: This tries to address an issue found when writing an MFD driver for the Nomadik STw481x PMICs: as the platform is using device tree

[PATCH v2] i2c: core: make it possible to match a pure device tree driver

2013-05-13 Thread Linus Walleij
This tries to address an issue found when writing an MFD driver for the Nomadik STw481x PMICs: as the platform is using device tree exclusively I want to specify the driver matching like this: static const struct of_device_id stw481x_match[] = { { .compatible = st,stw4810, }, {