Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-19 Thread Artem Bityutskiy
On Wed, 2011-07-20 at 13:52 +0800, Shawn Guo wrote: > The argument about this #ifdef thing was the driver could be used by > some platforms that will never migrate to device tree. This table > will be just a waste of bytes for those platforms, if we do not > protect the table by '#ifdef CONFIG_OF'

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-19 Thread Shawn Guo
On Wed, Jul 20, 2011 at 08:32:45AM +0300, Artem Bityutskiy wrote: > On Wed, 2011-07-20 at 13:28 +0800, Shawn Guo wrote: > > On Wed, Jul 20, 2011 at 08:17:45AM +0300, Artem Bityutskiy wrote: > > > On Wed, 2011-07-20 at 12:55 +0800, Shawn Guo wrote: > > > > On Wed, Jul 20, 2011 at 07:40:38AM +0300, A

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-19 Thread Mike Frysinger
On Wed, Jul 20, 2011 at 01:32, Artem Bityutskiy wrote: > On Wed, 2011-07-20 at 13:28 +0800, Shawn Guo wrote: >> On Wed, Jul 20, 2011 at 08:17:45AM +0300, Artem Bityutskiy wrote: >> > On Wed, 2011-07-20 at 12:55 +0800, Shawn Guo wrote: >> > > On Wed, Jul 20, 2011 at 07:40:38AM +0300, Artem Bityutski

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-19 Thread Artem Bityutskiy
On Wed, 2011-07-20 at 13:28 +0800, Shawn Guo wrote: > On Wed, Jul 20, 2011 at 08:17:45AM +0300, Artem Bityutskiy wrote: > > On Wed, 2011-07-20 at 12:55 +0800, Shawn Guo wrote: > > > On Wed, Jul 20, 2011 at 07:40:38AM +0300, Artem Bityutskiy wrote: > > > > On Fri, 2011-07-15 at 12:49 +0800, Shawn Gu

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-19 Thread Shawn Guo
On Wed, Jul 20, 2011 at 08:17:45AM +0300, Artem Bityutskiy wrote: > On Wed, 2011-07-20 at 12:55 +0800, Shawn Guo wrote: > > On Wed, Jul 20, 2011 at 07:40:38AM +0300, Artem Bityutskiy wrote: > > > On Fri, 2011-07-15 at 12:49 +0800, Shawn Guo wrote: > > > > > > +static const struct of_device_id dataf

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-19 Thread Artem Bityutskiy
On Wed, 2011-07-20 at 12:55 +0800, Shawn Guo wrote: > On Wed, Jul 20, 2011 at 07:40:38AM +0300, Artem Bityutskiy wrote: > > On Fri, 2011-07-15 at 12:49 +0800, Shawn Guo wrote: > > > > > +static const struct of_device_id dataflash_dt_ids[] = { > > > > > + { .compatible = "atmel,at45xxx", }, > >

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-19 Thread Shawn Guo
On Wed, Jul 20, 2011 at 07:40:38AM +0300, Artem Bityutskiy wrote: > On Fri, 2011-07-15 at 12:49 +0800, Shawn Guo wrote: > > > > +static const struct of_device_id dataflash_dt_ids[] = { > > > > + { .compatible = "atmel,at45xxx", }, > > > > + { .compatible = "atmel,dataflash", }, > > > >

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-19 Thread Artem Bityutskiy
On Fri, 2011-07-15 at 12:49 +0800, Shawn Guo wrote: > > > +static const struct of_device_id dataflash_dt_ids[] = { > > > + { .compatible = "atmel,at45xxx", }, > > > + { .compatible = "atmel,dataflash", }, > > > + { /* sentinel */ } > > > +}; > > > + > > > > This should be protected with a #ifdef C

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-14 Thread Shawn Guo
On Thu, Jul 14, 2011 at 08:54:07PM -0600, Grant Likely wrote: > On Thu, Jul 14, 2011 at 11:52:37PM +0800, Shawn Guo wrote: > > It adds device tree probe support for mtd_dataflash driver. > > > > Signed-off-by: Shawn Guo > > Cc: Grant Likely > > Cc: David Woodhouse > > Cc: Artem Bityutskiy > >

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-14 Thread Shawn Guo
On Thu, Jul 14, 2011 at 09:52:02PM +0400, Dmitry Eremin-Solenikov wrote: > On Thu, Jul 14, 2011 at 11:52:37PM +0800, Shawn Guo wrote: > > It adds device tree probe support for mtd_dataflash driver. > > > > Signed-off-by: Shawn Guo > > Cc: Grant Likely > > Cc: David Woodhouse > > Cc: Artem Bityu

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-14 Thread Grant Likely
On Thu, Jul 14, 2011 at 11:52:37PM +0800, Shawn Guo wrote: > It adds device tree probe support for mtd_dataflash driver. > > Signed-off-by: Shawn Guo > Cc: Grant Likely > Cc: David Woodhouse > Cc: Artem Bityutskiy > --- > Changes since v1: > * Add "atmel,at45xxx" into the match table > * Add

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-14 Thread Grant Likely
On Thu, Jul 14, 2011 at 09:52:02PM +0400, Dmitry Eremin-Solenikov wrote: > On Thu, Jul 14, 2011 at 11:52:37PM +0800, Shawn Guo wrote: > > It adds device tree probe support for mtd_dataflash driver. > > > > Signed-off-by: Shawn Guo > > Cc: Grant Likely > > Cc: David Woodhouse > > Cc: Artem Bityu

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-14 Thread Dmitry Eremin-Solenikov
On Thu, Jul 14, 2011 at 11:52:37PM +0800, Shawn Guo wrote: > It adds device tree probe support for mtd_dataflash driver. > > Signed-off-by: Shawn Guo > Cc: Grant Likely > Cc: David Woodhouse > Cc: Artem Bityutskiy > --- > Changes since v1: > * Add "atmel,at45xxx" into the match table > * Add

Re: [PATCH v2] mtd: dataflash: add device tree probe support

2011-07-14 Thread Mike Frysinger
shouldnt there be #ifdef's around this ? not everyone supports devicetrees. -mike ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

[PATCH v2] mtd: dataflash: add device tree probe support

2011-07-14 Thread Shawn Guo
It adds device tree probe support for mtd_dataflash driver. Signed-off-by: Shawn Guo Cc: Grant Likely Cc: David Woodhouse Cc: Artem Bityutskiy --- Changes since v1: * Add "atmel,at45xxx" into the match table * Add binding document .../devicetree/bindings/mtd/atmel-dataflash.txt| 14 +