Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-02-09 Thread Grant Likely
On Wed, 9 Jan 2013 01:19:39 -0800, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Jan 09, 2013 at 08:07:45AM +0100, Thierry Reding wrote: On Sun, Jan 06, 2013 at 11:57:48AM -0800, Dmitry Torokhov wrote: On Sun, Jan 06, 2013 at 08:27:39PM +0100, Thierry Reding wrote: On Sat,

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-15 Thread Wolfram Sang
On Mon, Jan 14, 2013 at 10:24:11PM +, Arnd Bergmann wrote: On Monday 14 January 2013, Thierry Reding wrote: It certainly sounds like a less complicated way to do it. But it also involves adding a function with a made up name and drop a function with a perfectly good name instead. I

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-15 Thread Wolfram Sang
Hi, I am sorry, but I do not consider a function that was added a little over a year ago as a canon. If you look at the uses of EADDRNOTAVAIL it is used predominantly in networking code to indicate that attempted _network_ address is not available. EBUSY might

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-15 Thread Thierry Reding
On Tue, Jan 15, 2013 at 02:06:23PM +0100, Wolfram Sang wrote: Hi, I am sorry, but I do not consider a function that was added a little over a year ago as a canon. If you look at the uses of EADDRNOTAVAIL it is used predominantly in networking code to indicate that

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-15 Thread Wolfram Sang
Hi, Then, I added the example code in the documentation using EADDRNOTAVAIL. Yes, I was brave with this one. Yet, EINVAL, EBUSY, ENOENT, did not really cut it and are so heavily used in drivers that they turned into a generic something is wrong error. I tried here to use a not overloaded

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-14 Thread Thierry Reding
On Wed, Jan 09, 2013 at 10:23:52AM +0100, Thierry Reding wrote: On Wed, Jan 09, 2013 at 01:19:39AM -0800, Dmitry Torokhov wrote: On Wed, Jan 09, 2013 at 08:07:45AM +0100, Thierry Reding wrote: On Sun, Jan 06, 2013 at 11:57:48AM -0800, Dmitry Torokhov wrote: On Sun, Jan 06, 2013 at

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-14 Thread Greg Kroah-Hartman
On Mon, Jan 14, 2013 at 04:49:59PM +0100, Thierry Reding wrote: On Wed, Jan 09, 2013 at 10:23:52AM +0100, Thierry Reding wrote: On Wed, Jan 09, 2013 at 01:19:39AM -0800, Dmitry Torokhov wrote: On Wed, Jan 09, 2013 at 08:07:45AM +0100, Thierry Reding wrote: On Sun, Jan 06, 2013 at

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-14 Thread Thierry Reding
On Mon, Jan 14, 2013 at 08:16:44AM -0800, Greg Kroah-Hartman wrote: On Mon, Jan 14, 2013 at 04:49:59PM +0100, Thierry Reding wrote: On Wed, Jan 09, 2013 at 10:23:52AM +0100, Thierry Reding wrote: On Wed, Jan 09, 2013 at 01:19:39AM -0800, Dmitry Torokhov wrote: On Wed, Jan 09, 2013 at

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-14 Thread Arnd Bergmann
On Monday 14 January 2013, Thierry Reding wrote: It certainly sounds like a less complicated way to do it. But it also involves adding a function with a made up name and drop a function with a perfectly good name instead. I wouldn't even know what name to choose for the new API. How about

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-14 Thread Thierry Reding
On Mon, Jan 14, 2013 at 10:24:11PM +, Arnd Bergmann wrote: On Monday 14 January 2013, Thierry Reding wrote: It certainly sounds like a less complicated way to do it. But it also involves adding a function with a made up name and drop a function with a perfectly good name instead. I

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-09 Thread Dmitry Torokhov
On Wed, Jan 09, 2013 at 08:07:45AM +0100, Thierry Reding wrote: On Sun, Jan 06, 2013 at 11:57:48AM -0800, Dmitry Torokhov wrote: On Sun, Jan 06, 2013 at 08:27:39PM +0100, Thierry Reding wrote: On Sat, Jan 05, 2013 at 12:06:58AM -0800, Dmitry Torokhov wrote: On Sat, Jan 05, 2013 at

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-08 Thread Thierry Reding
On Sun, Jan 06, 2013 at 11:57:48AM -0800, Dmitry Torokhov wrote: On Sun, Jan 06, 2013 at 08:27:39PM +0100, Thierry Reding wrote: On Sat, Jan 05, 2013 at 12:06:58AM -0800, Dmitry Torokhov wrote: On Sat, Jan 05, 2013 at 01:15:08PM +0530, Laxman Dewangan wrote: [...] @@ -735,25 +738,16 @@

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-06 Thread Laxman Dewangan
On Sunday 06 January 2013 04:48 AM, Dmitry Torokhov wrote: On Sat, Jan 05, 2013 at 04:50:58PM +0530, Laxman Dewangan wrote: HI Dmitry, Thanks for quick review. I will take care of your comment in next version. Some have my answer. On Saturday 05 January 2013 01:36 PM, Dmitry Torokhov wrote:

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-06 Thread Thierry Reding
On Sat, Jan 05, 2013 at 12:06:58AM -0800, Dmitry Torokhov wrote: On Sat, Jan 05, 2013 at 01:15:08PM +0530, Laxman Dewangan wrote: [...] @@ -735,25 +738,16 @@ static int tegra_kbc_probe(struct platform_device *pdev) spin_lock_init(kbc-lock); setup_timer(kbc-timer,

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-06 Thread Dmitry Torokhov
On Sun, Jan 06, 2013 at 08:27:39PM +0100, Thierry Reding wrote: On Sat, Jan 05, 2013 at 12:06:58AM -0800, Dmitry Torokhov wrote: On Sat, Jan 05, 2013 at 01:15:08PM +0530, Laxman Dewangan wrote: [...] @@ -735,25 +738,16 @@ static int tegra_kbc_probe(struct platform_device *pdev)

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-05 Thread Laxman Dewangan
HI Dmitry, Thanks for quick review. I will take care of your comment in next version. Some have my answer. On Saturday 05 January 2013 01:36 PM, Dmitry Torokhov wrote: Hi Laxman, On Sat, Jan 05, 2013 at 01:15:08PM +0530, Laxman Dewangan wrote: Use devm_* for memory, clock, input device

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-05 Thread Dmitry Torokhov
On Sat, Jan 05, 2013 at 04:50:58PM +0530, Laxman Dewangan wrote: HI Dmitry, Thanks for quick review. I will take care of your comment in next version. Some have my answer. On Saturday 05 January 2013 01:36 PM, Dmitry Torokhov wrote: Hi Laxman, On Sat, Jan 05, 2013 at 01:15:08PM