[PATCH v4] clocksource:arm_global_timer: Add ARM global timer support.

2013-06-21 Thread Srinivas KANDAGATLA
From: Stuart Menefy This is a simple driver for the global timer module found in the Cortex A9-MP cores from revision r1p0 onwards. This should be able to perform the functions of the system timer and the local timer in an SMP system. The global timer has the following features: The global t

Re: [PATCH v4] clocksource:arm_global_timer: Add ARM global timer support.

2013-06-21 Thread Thomas Gleixner
On Fri, 21 Jun 2013, Srinivas KANDAGATLA wrote: > +static void gt_clockevent_set_mode(enum clock_event_mode mode, > +struct clock_event_device *clk) > +{ > + unsigned long ctrl; > + > + ctrl = readl(gt_base + GT_CONTROL); > + switch (mode) { > + case

Re: [PATCH v4] clocksource:arm_global_timer: Add ARM global timer support.

2013-06-21 Thread Stephen Boyd
On 06/21/13 08:56, Thomas Gleixner wrote: > >> +static irqreturn_t gt_clockevent_interrupt(int irq, void *dev_id) >> +{ >> +struct clock_event_device *evt = *(struct clock_event_device **)dev_id; > What kind of construct is this? > > You are using request_percpu_irq() and the device id is point

Re: [PATCH v4] clocksource:arm_global_timer: Add ARM global timer support.

2013-06-21 Thread Thomas Gleixner
On Fri, 21 Jun 2013, Stephen Boyd wrote: > On 06/21/13 08:56, Thomas Gleixner wrote: > > > >> +static irqreturn_t gt_clockevent_interrupt(int irq, void *dev_id) > >> +{ > >> + struct clock_event_device *evt = *(struct clock_event_device **)dev_id; > > What kind of construct is this? > > > > You a

Re: [PATCH v4] clocksource:arm_global_timer: Add ARM global timer support.

2013-06-21 Thread Stephen Boyd
On 06/21/13 14:00, Thomas Gleixner wrote: > On Fri, 21 Jun 2013, Stephen Boyd wrote: > >> On 06/21/13 08:56, Thomas Gleixner wrote: +static irqreturn_t gt_clockevent_interrupt(int irq, void *dev_id) +{ + struct clock_event_device *evt = *(struct clock_event_device **)dev_id; >>> Wha

Re: [PATCH v4] clocksource:arm_global_timer: Add ARM global timer support.

2013-06-24 Thread Srinivas KANDAGATLA
Thankyou for the comments. On 21/06/13 16:56, Thomas Gleixner wrote: > On Fri, 21 Jun 2013, Srinivas KANDAGATLA wrote: >> +static void gt_clockevent_set_mode(enum clock_event_mode mode, >> + struct clock_event_device *clk) >> +{ >> +unsigned long ctrl; >> + >> +