Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2013-04-14 Thread Anton Vorontsov
On Mon, Apr 08, 2013 at 12:54:01PM -0700, Bryan Freed wrote: [...] > And as a more general question, why should we try not to put > configuration in the device tree? It seems like a great (and > portable) place to put this stuff. > It certainly seems better to have it there than hardwired in the >

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2013-04-08 Thread Rob Herring
On 04/08/2013 02:54 PM, Bryan Freed wrote: > Sorry for dropping the ball on this one, Anton. > > Thank you for your feedback and modifications in the code. > I gotta ask, however, why do you completely remove key ramoops fields > like record_size and ftrace_size? > > From your 9/7/2012 comments (

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2013-04-07 Thread Anton Vorontsov
On Thu, Apr 04, 2013 at 09:03:47PM -0500, Rob Herring wrote: > On Mon, Sep 17, 2012 at 1:23 AM, Anton Vorontsov > wrote: > > On Fri, Sep 07, 2012 at 10:29:10PM -0700, Anton Vorontsov wrote: > >> On Fri, Sep 07, 2012 at 11:29:36AM -0700, Bryan Freed wrote: > >> > When called with a non-zero of_nod

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2013-04-04 Thread Rob Herring
On Mon, Sep 17, 2012 at 1:23 AM, Anton Vorontsov wrote: > On Fri, Sep 07, 2012 at 10:29:10PM -0700, Anton Vorontsov wrote: >> On Fri, Sep 07, 2012 at 11:29:36AM -0700, Bryan Freed wrote: >> > When called with a non-zero of_node, fill out a new ramoops_platform_data >> > with data from the specifie

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2012-09-16 Thread Anton Vorontsov
On Fri, Sep 07, 2012 at 10:29:10PM -0700, Anton Vorontsov wrote: > On Fri, Sep 07, 2012 at 11:29:36AM -0700, Bryan Freed wrote: > > When called with a non-zero of_node, fill out a new ramoops_platform_data > > with data from the specified Flattened Device Tree node. > > Update ramoops documentation

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2012-09-08 Thread Anton Vorontsov
On Sat, Sep 08, 2012 at 09:23:40AM +0200, Marco Stornelli wrote: [...] > >>+ pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); > >>+ if (pdata == NULL) > > > >I wonder why people prefer to not write !pdata, which is more natural > >when reading the code.. :-) > > I think it's the same for

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2012-09-07 Thread Anton Vorontsov
On Fri, Sep 07, 2012 at 11:29:36AM -0700, Bryan Freed wrote: > When called with a non-zero of_node, fill out a new ramoops_platform_data > with data from the specified Flattened Device Tree node. > Update ramoops documentation with the new FDT interface. > Update devicetree/binding documentation wi