[PATCH v7 01/14] usb: chipidea: remove unneeded NULL check

2012-06-24 Thread Richard Zhao
From: Alexander Shishkin As reported by Dan Carpenter, there is a NULL check in udc_start() that follows a dereference of the pointer that's being checked. However, at that point udc pointer shouldn't ever be NULL and if it is, the dereference should cause an oops. Signed-off-by: Alexander Shish

Re: [PATCH v7 01/14] usb: chipidea: remove unneeded NULL check

2012-06-26 Thread Greg KH
On Mon, Jun 25, 2012 at 02:56:18PM +0800, Richard Zhao wrote: > From: Alexander Shishkin > > As reported by Dan Carpenter, there is a NULL check in udc_start() that > follows a dereference of the pointer that's being checked. However, at > that point udc pointer shouldn't ever be NULL and if it i

Re: [PATCH v7 01/14] usb: chipidea: remove unneeded NULL check

2012-06-26 Thread Marek Vasut
Dear Richard Zhao, > From: Alexander Shishkin > > As reported by Dan Carpenter, there is a NULL check in udc_start() that > follows a dereference of the pointer that's being checked. However, at > that point udc pointer shouldn't ever be NULL and if it is, the dereference > should cause an oops.

Re: [PATCH v7 01/14] usb: chipidea: remove unneeded NULL check

2012-06-26 Thread Richard Zhao
On Tue, Jun 26, 2012 at 02:43:11PM -0700, Greg KH wrote: > On Mon, Jun 25, 2012 at 02:56:18PM +0800, Richard Zhao wrote: > > From: Alexander Shishkin > > > > As reported by Dan Carpenter, there is a NULL check in udc_start() that > > follows a dereference of the pointer that's being checked. Howe