Re: [PATCH v8 3/6] fbmon: add videomode helpers

2012-11-13 Thread Steffen Trumtrar
On Tue, Nov 13, 2012 at 12:22:58PM +0100, Thierry Reding wrote: > On Mon, Nov 12, 2012 at 04:37:03PM +0100, Steffen Trumtrar wrote: > [...] > > +#if IS_ENABLED(CONFIG_VIDEOMODE) > > +int videomode_to_fb_videomode(struct videomode *vm, struct fb_videomode > > *fbmode) > > The other helpers are nam

Re: [PATCH v8 3/6] fbmon: add videomode helpers

2012-11-13 Thread Thierry Reding
On Mon, Nov 12, 2012 at 04:37:03PM +0100, Steffen Trumtrar wrote: [...] > +#if IS_ENABLED(CONFIG_VIDEOMODE) > +int videomode_to_fb_videomode(struct videomode *vm, struct fb_videomode > *fbmode) The other helpers are named _from_(), maybe this should follow that example for consistency? > +{ > +

[PATCH v8 3/6] fbmon: add videomode helpers

2012-11-12 Thread Steffen Trumtrar
Add a function to convert from the generic videomode to a fb_videomode. Signed-off-by: Steffen Trumtrar --- drivers/video/fbmon.c | 37 + include/linux/fb.h|2 ++ 2 files changed, 39 insertions(+) diff --git a/drivers/video/fbmon.c b/drivers/video/f