Re: [PATCHv1 1/3] hwmon: Add support for GMT G762/G763 PWM fan controller

2013-04-27 Thread Guenter Roeck
On Sat, Apr 27, 2013 at 04:03:31PM +0200, Simon Guinot wrote: > On Wed, Apr 24, 2013 at 12:05:56AM +0200, Arnaud Ebalard wrote: > > + /* > > +* Set default configuration values before passing the structure > > +* to OF helpers to overload them using those provided by .dts > > +* file

Re: [PATCHv1 1/3] hwmon: Add support for GMT G762/G763 PWM fan controller

2013-04-27 Thread Jean Delvare
On Sat, 27 Apr 2013 16:03:31 +0200, Simon Guinot wrote: > On Wed, Apr 24, 2013 at 12:05:56AM +0200, Arnaud Ebalard wrote: > > + /* > > +* Set default configuration values before passing the structure > > +* to OF helpers to overload them using those provided by .dts > > +* file (if an

Re: [PATCHv1 1/3] hwmon: Add support for GMT G762/G763 PWM fan controller

2013-04-24 Thread Guenter Roeck
On Wed, Apr 24, 2013 at 12:05:56AM +0200, Arnaud Ebalard wrote: > > Signed-off-by: Arnaud Ebalard > Tested-by: Arnaud Ebalard Tested-by is not needed here; I sure hope you tested your own code. It is only used if someone else tested it. > --- > drivers/hwmon/Kconfig | 10 + > drivers/hwmon

Re: [PATCHv1 1/3] hwmon: Add support for GMT G762/G763 PWM fan controller

2013-04-24 Thread Guenter Roeck
On Wed, Apr 24, 2013 at 10:28:47PM +0200, Arnaud Ebalard wrote: > Hi, > > Guenter Roeck writes: > > >> > You could consider using regmap for holding this cache. > >> > > >> > http://elceurope2012.sched.org/event/100619b669ce5767341624253aa03659?iframe=no&w=900&sidebar=yes&bg=no#.UXdspHLQ5jM > >>

Re: [PATCHv1 1/3] hwmon: Add support for GMT G762/G763 PWM fan controller

2013-04-24 Thread Guenter Roeck
On Wed, Apr 24, 2013 at 11:06:57AM +0200, Arnaud Ebalard wrote: > Hi Andrew, > > Andrew Lunn writes: > > >> +struct g762_data { > >> + struct i2c_client *client; > >> + struct device *hwmon_dev; > >> + > >> + /* update mutex */ > >> + struct mutex update_lock; > >> + > >> + /* board specifi

Re: [PATCHv1 1/3] hwmon: Add support for GMT G762/G763 PWM fan controller

2013-04-23 Thread Andrew Lunn
On Wed, Apr 24, 2013 at 12:05:56AM +0200, Arnaud Ebalard wrote: > > Signed-off-by: Arnaud Ebalard > Tested-by: Arnaud Ebalard > --- > drivers/hwmon/Kconfig | 10 + > drivers/hwmon/Makefile |1 + > drivers/hwmon/g762.c | 1058 > > 3 file