Re: [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver

2013-06-24 Thread Lars-Peter Clausen
On 06/24/2013 12:37 PM, Alexandre Belloni wrote: > On 24/06/2013 08:41, Lars-Peter Clausen wrote: >> On 06/20/2013 08:57 PM, Alexandre Belloni wrote: >>> The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable >>> gain and sampling rates. >>> >>> Signed-off-by: Alexandre Belloni >>

Re: [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver

2013-06-23 Thread Lars-Peter Clausen
On 06/20/2013 08:57 PM, Alexandre Belloni wrote: > The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable > gain and sampling rates. > > Signed-off-by: Alexandre Belloni > Signed-off-by: Maxime Ripard > --- > .../bindings/iio/adc/nuvoton-nau7802.txt | 17 + > drivers

Re: [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver

2013-06-23 Thread Jonathan Cameron
On 06/23/2013 02:54 PM, Lars-Peter Clausen wrote: > On 06/22/2013 03:28 PM, Alexandre Belloni wrote: >> On 22/06/2013 15:20, Lars-Peter Clausen wrote: >>> On 06/22/2013 03:07 PM, Alexandre Belloni wrote: On 22/06/2013 14:02, Lars-Peter Clausen wrote: > On 06/22/2013 01:55 PM, Jonathan Came

Re: [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver

2013-06-23 Thread Lars-Peter Clausen
On 06/22/2013 03:28 PM, Alexandre Belloni wrote: > On 22/06/2013 15:20, Lars-Peter Clausen wrote: >> On 06/22/2013 03:07 PM, Alexandre Belloni wrote: >>> On 22/06/2013 14:02, Lars-Peter Clausen wrote: On 06/22/2013 01:55 PM, Jonathan Cameron wrote: > On 06/20/2013 07:57 PM, Alexandre Bello

Re: [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver

2013-06-22 Thread Lars-Peter Clausen
On 06/22/2013 03:07 PM, Alexandre Belloni wrote: > On 22/06/2013 14:02, Lars-Peter Clausen wrote: >> On 06/22/2013 01:55 PM, Jonathan Cameron wrote: >>> On 06/20/2013 07:57 PM, Alexandre Belloni wrote: The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable gain and sampli

Re: [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver

2013-06-22 Thread Lars-Peter Clausen
On 06/22/2013 01:55 PM, Jonathan Cameron wrote: > On 06/20/2013 07:57 PM, Alexandre Belloni wrote: >> The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable >> gain and sampling rates. >> > Sorry, somewhat low on time today so only a quick review. > > 1) Missing userspace ABI docu

Re: [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver

2013-06-22 Thread Jonathan Cameron
On 06/20/2013 07:57 PM, Alexandre Belloni wrote: > The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable > gain and sampling rates. > Sorry, somewhat low on time today so only a quick review. 1) Missing userspace ABI documentation. Also, perhaps min_conversions is a little va