Re: [PATCHv7 08/17] pci: PCIe driver for Marvell Armada 370/XP systems

2013-04-09 Thread Thomas Petazzoni
Dear Arnd Bergmann, On Tue, 9 Apr 2013 00:14:06 +0200, Arnd Bergmann wrote: pcie-realio.type = IORESOURCE_IO; pcie-realio.start = max(PCIBIOS_MIN_IO, range-pci_addr); pcie-realio.end = max(IO_SPACE_LIMIT, range-pci_addr + range-size); Shouldn't this last line be using min()

Re: [PATCHv7 08/17] pci: PCIe driver for Marvell Armada 370/XP systems

2013-04-09 Thread Arnd Bergmann
On Tuesday 09 April 2013, Thomas Petazzoni wrote: Dear Arnd Bergmann, On Tue, 9 Apr 2013 00:14:06 +0200, Arnd Bergmann wrote: pcie-realio.type = IORESOURCE_IO; pcie-realio.start = max(PCIBIOS_MIN_IO, range-pci_addr); pcie-realio.end = max(IO_SPACE_LIMIT,

Re: [PATCHv7 08/17] pci: PCIe driver for Marvell Armada 370/XP systems

2013-04-08 Thread Bjorn Helgaas
On Wed, Mar 27, 2013 at 8:40 AM, Thomas Petazzoni thomas.petazz...@free-electrons.com wrote: This driver implements the support for the PCIe interfaces on the Marvell Armada 370/XP ARM SoCs. In the future, it might be extended to cover earlier families of Marvell SoCs, such as Dove, Orion and

Re: [PATCHv7 08/17] pci: PCIe driver for Marvell Armada 370/XP systems

2013-04-08 Thread Thomas Petazzoni
Dear Bjorn Helgaas, On Mon, 8 Apr 2013 14:29:59 -0600, Bjorn Helgaas wrote: Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com Acked-by: Bjorn Helgaas bhelg...@google.com A few trivial comments below; it's up to you whether you do anything with them or not. It's OK

Re: [PATCHv7 08/17] pci: PCIe driver for Marvell Armada 370/XP systems

2013-04-08 Thread Arnd Bergmann
On Monday 08 April 2013, Bjorn Helgaas wrote: On Wed, Mar 27, 2013 at 8:40 AM, Thomas Petazzoni diff --git a/drivers/pci/host/Makefile b/drivers/pci/host/Makefile new file mode 100644 index 000..3ad563f --- /dev/null +++ b/drivers/pci/host/Makefile @@ -0,0 +1,4 @@

Re: [PATCHv7 08/17] pci: PCIe driver for Marvell Armada 370/XP systems

2013-04-08 Thread Thomas Petazzoni
Dear Arnd Bergmann, On Mon, 8 Apr 2013 23:31:30 +0200, Arnd Bergmann wrote: Too bad to have to adjust CFLAGS here. Seems like I remember earlier discussion, but I didn't pay much attention, and if this is the best we can do, I guess it's OK. I'm pretty sure I NAK'ed this part. I'm

Re: [PATCHv7 08/17] pci: PCIe driver for Marvell Armada 370/XP systems

2013-04-08 Thread Arnd Bergmann
On Monday 08 April 2013, Thomas Petazzoni wrote: + pcie-io.name = I/O; + pcie-realio.start = PCIBIOS_MIN_IO; + pcie-realio.end = min(resource_size(pcie-io), +

Re: [PATCHv7 08/17] pci: PCIe driver for Marvell Armada 370/XP systems

2013-04-08 Thread Thomas Petazzoni
Dear Arnd Bergmann, On Mon, 8 Apr 2013 23:34:12 +0200, Arnd Bergmann wrote: No, I'm assuming PCIBIOS_MIN_IO is always 0. So presumarly, this should be something like: pcie-realio.end = min(PCIBIOS_MIN_IO + resource_size(pcie-io),

Re: [PATCHv7 08/17] pci: PCIe driver for Marvell Armada 370/XP systems

2013-04-08 Thread Arnd Bergmann
On Monday 08 April 2013, Thomas Petazzoni wrote: Dear Arnd Bergmann, On Mon, 8 Apr 2013 23:34:12 +0200, Arnd Bergmann wrote: No, I'm assuming PCIBIOS_MIN_IO is always 0. So presumarly, this should be something like: pcie-realio.end = min(PCIBIOS_MIN_IO +

[PATCHv7 08/17] pci: PCIe driver for Marvell Armada 370/XP systems

2013-03-27 Thread Thomas Petazzoni
This driver implements the support for the PCIe interfaces on the Marvell Armada 370/XP ARM SoCs. In the future, it might be extended to cover earlier families of Marvell SoCs, such as Dove, Orion and Kirkwood. The driver implements the hw_pci operations needed by the core ARM PCI code to setup