Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-10 Thread Russell King - ARM Linux
On Wed, May 08, 2013 at 09:36:13AM -0700, Greg KH wrote: > On Wed, May 08, 2013 at 06:31:48PM +0200, Arnd Bergmann wrote: > > On Wednesday 08 May 2013, Greg KH wrote: > > > > just mention there is not hardware reason to not use the generic ttySx > > > > in place of ttyAS as we have only one IP that

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-10 Thread Greg KH
On Fri, May 10, 2013 at 04:45:15PM +0200, Ben Dooks wrote: > On 08/05/13 17:34, Greg KH wrote: > >On Wed, May 08, 2013 at 04:34:43PM +0200, Arnd Bergmann wrote: > >>>+#define ASC_MAJOR 204 > >>>+#define ASC_MINOR_START 40 > >> > >>I don't know what the current policy is on allocat

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-09 Thread Jean-Christophe PLAGNIOL-VILLARD
On 20:35 Wed 08 May , Arnd Bergmann wrote: > On Wednesday 08 May 2013, Nicolas Pitre wrote: > > I tried to fix this up over 10 years ago. RMK tried as well. This > > failed because X86 people insisted on always having COM1 as /dev/ttyS0, > > COM3 as /dev/ttyS2 and so on, even when some of th

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Arnd Bergmann
On Wednesday 08 May 2013, Srinivas KANDAGATLA wrote: > > On 08/05/13 15:39, Jean-Christophe PLAGNIOL-VILLARD wrote: > >>> + > >> > > >> > Please remove all forward declarations, by reordering the functions in > >> > the way they are called. > >> > > > and drop the dummy functions > > We can not

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Arnd Bergmann
On Wednesday 08 May 2013, Nicolas Pitre wrote: > I tried to fix this up over 10 years ago. RMK tried as well. This > failed because X86 people insisted on always having COM1 as /dev/ttyS0, > COM3 as /dev/ttyS2 and so on, even when some of them weren't present. > > A common and dynamic namespace

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Srinivas KANDAGATLA
On 08/05/13 15:39, Jean-Christophe PLAGNIOL-VILLARD wrote: >>> + >> > >> > Please remove all forward declarations, by reordering the functions in >> > the way they are called. >> > > and drop the dummy functions We can not remove the dummy functions, as the serial-core does not check it before us

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Srinivas KANDAGATLA
Thankyou for the comments. On 08/05/13 15:34, Arnd Bergmann wrote: > On Wednesday 08 May 2013, Srinivas KANDAGATLA wrote: >> From: Srinivas Kandagatla >> +*st-asc(Serial Port) >> + >> +Required properties: >> +- compatible : Should be "st,asc". > Are there any hardware revision numbers for the asc

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Jean-Christophe PLAGNIOL-VILLARD
On May 9, 2013, at 12:31 AM, Arnd Bergmann wrote: > On Wednesday 08 May 2013, Greg KH wrote: >>> just mention there is not hardware reason to not use the generic ttySx >>> in place of ttyAS as we have only one IP that handle serial on this >>> family of SoC >>> >>> personally I'll switch to tty

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Nicolas Pitre
On Wed, 8 May 2013, Arnd Bergmann wrote: > On Wednesday 08 May 2013, Greg KH wrote: > > > just mention there is not hardware reason to not use the generic ttySx > > > in place of ttyAS as we have only one IP that handle serial on this > > > family of SoC > > > > > > personally I'll switch to ttyS

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Greg KH
On Wed, May 08, 2013 at 06:31:48PM +0200, Arnd Bergmann wrote: > On Wednesday 08 May 2013, Greg KH wrote: > > > just mention there is not hardware reason to not use the generic ttySx > > > in place of ttyAS as we have only one IP that handle serial on this > > > family of SoC > > > > > > personall

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Arnd Bergmann
On Wednesday 08 May 2013, Greg KH wrote: > > just mention there is not hardware reason to not use the generic ttySx > > in place of ttyAS as we have only one IP that handle serial on this > > family of SoC > > > > personally I'll switch to ttySx > > Great, then you can use the same major/minor ra

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Greg KH
On Thu, May 09, 2013 at 12:03:05AM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On May 8, 2013, at 11:53 PM, Greg KH wrote: > > > On Wed, May 08, 2013 at 05:40:57PM +0200, Jean-Christophe PLAGNIOL-VILLARD > > wrote: > >> On 08:34 Wed 08 May , Greg KH wrote: > >>> On Wed, May 08, 2013

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Jean-Christophe PLAGNIOL-VILLARD
On May 8, 2013, at 11:53 PM, Greg KH wrote: > On Wed, May 08, 2013 at 05:40:57PM +0200, Jean-Christophe PLAGNIOL-VILLARD > wrote: >> On 08:34 Wed 08 May , Greg KH wrote: >>> On Wed, May 08, 2013 at 04:34:43PM +0200, Arnd Bergmann wrote: > +#define ASC_MAJOR204 > +#de

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Greg KH
On Wed, May 08, 2013 at 05:40:57PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 08:34 Wed 08 May , Greg KH wrote: > > On Wed, May 08, 2013 at 04:34:43PM +0200, Arnd Bergmann wrote: > > > > +#define ASC_MAJOR 204 > > > > +#define ASC_MINOR_START40 > > > > >

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Jean-Christophe PLAGNIOL-VILLARD
On 08:34 Wed 08 May , Greg KH wrote: > On Wed, May 08, 2013 at 04:34:43PM +0200, Arnd Bergmann wrote: > > > +#define ASC_MAJOR204 > > > +#define ASC_MINOR_START 40 > > > > I don't know what the current policy is on allocating major/minor numbers, > > but I'm sure you c

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Greg KH
On Wed, May 08, 2013 at 04:34:43PM +0200, Arnd Bergmann wrote: > > +#define ASC_MAJOR 204 > > +#define ASC_MINOR_START40 > > I don't know what the current policy is on allocating major/minor numbers, > but I'm sure you cannot just reuse one that is already used. I agree, why

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Jean-Christophe PLAGNIOL-VILLARD
On 16:34 Wed 08 May , Arnd Bergmann wrote: > On Wednesday 08 May 2013, Srinivas KANDAGATLA wrote: > > From: Srinivas Kandagatla > > > +*st-asc(Serial Port) > > + > > +Required properties: > > +- compatible : Should be "st,asc". > > Are there any hardware revision numbers for the asc? If ther

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Arnd Bergmann
On Wednesday 08 May 2013, Srinivas KANDAGATLA wrote: > From: Srinivas Kandagatla > +*st-asc(Serial Port) > + > +Required properties: > +- compatible : Should be "st,asc". Are there any hardware revision numbers for the asc? If there are potentially incompatible or backwards-compatible variants,

[RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Srinivas KANDAGATLA
From: Srinivas Kandagatla This patch adds support to ASC (asynchronous serial controller) driver, which is basically a standard serial driver. This IP is common across all the ST parts for settop box platforms. ASC is embedded in ST COMMS IP block. It supports Rx & Tx functionality. It support a