Re: [RFC PATCH v2 11/15] cpufreq: kirkwood-cpufreq: remove device tree parsing for cpu nodes

2013-07-18 Thread Viresh Kumar
On 17 July 2013 20:13, Andrew Lunn and...@lunn.ch wrote: Are we not going a bit backwards here? You are replacing two lines with 10 lines. How about putting these 10 lines into some helper, of_get_cpu_device()? It would be useful for spear, kirkwood and imx6q, and maybe others. +1

Re: [RFC PATCH v2 11/15] cpufreq: kirkwood-cpufreq: remove device tree parsing for cpu nodes

2013-07-18 Thread Sudeep KarkadaNagesha
On 18/07/13 09:24, Sudeep KarkadaNagesha wrote: On 17/07/13 15:43, Andrew Lunn wrote: On Wed, Jul 17, 2013 at 03:06:20PM +0100, sudeep.karkadanage...@arm.com wrote: From: Sudeep KarkadaNagesha sudeep.karkadanage...@arm.com [...] diff --git a/drivers/cpufreq/kirkwood-cpufreq.c

Re: [RFC PATCH v2 11/15] cpufreq: kirkwood-cpufreq: remove device tree parsing for cpu nodes

2013-07-18 Thread Rob Herring
On 07/18/2013 05:14 AM, Sudeep KarkadaNagesha wrote: On 18/07/13 09:24, Sudeep KarkadaNagesha wrote: On 17/07/13 15:43, Andrew Lunn wrote: On Wed, Jul 17, 2013 at 03:06:20PM +0100, sudeep.karkadanage...@arm.com wrote: From: Sudeep KarkadaNagesha sudeep.karkadanage...@arm.com [...] Are we

[RFC PATCH v2 11/15] cpufreq: kirkwood-cpufreq: remove device tree parsing for cpu nodes

2013-07-17 Thread Sudeep . KarkadaNagesha
From: Sudeep KarkadaNagesha sudeep.karkadanage...@arm.com Now that the cpu device registration initialises the of_node(if available) appropriately for all the cpus, parsing here is redundant. This patch removes all DT parsing and uses cpu-of_node instead. Cc: Andrew Lunn and...@lunn.ch Cc:

Re: [RFC PATCH v2 11/15] cpufreq: kirkwood-cpufreq: remove device tree parsing for cpu nodes

2013-07-17 Thread Andrew Lunn
On Wed, Jul 17, 2013 at 03:06:20PM +0100, sudeep.karkadanage...@arm.com wrote: From: Sudeep KarkadaNagesha sudeep.karkadanage...@arm.com Now that the cpu device registration initialises the of_node(if available) appropriately for all the cpus, parsing here is redundant. This patch removes