Re: CoreSight framework and drivers

2013-01-17 Thread Will Deacon
On Wed, Jan 16, 2013 at 12:14:59AM +, Pratik Patel wrote: On Mon, Jan 07, 2013 at 11:58:36AM +, Will Deacon wrote: On Thu, Jan 03, 2013 at 06:06:43PM +, Pratik Patel wrote: Whats the advantage in using debugfs here? The main things I like about debugfs are (a) it's a

Re: CoreSight framework and drivers

2013-01-15 Thread Pratik Patel
On Mon, Jan 07, 2013 at 11:58:36AM +, Will Deacon wrote: On Thu, Jan 03, 2013 at 06:06:43PM +, Pratik Patel wrote: On Sun, Dec 23, 2012 at 11:32:39AM +, Will Deacon wrote: On Fri, Dec 21, 2012 at 10:18:28PM +, Pratik Patel wrote: What user interface do you plan to provide

Re: CoreSight framework and drivers

2013-01-07 Thread Will Deacon
On Thu, Jan 03, 2013 at 06:06:43PM +, Pratik Patel wrote: On Sun, Dec 23, 2012 at 11:32:39AM +, Will Deacon wrote: On Fri, Dec 21, 2012 at 10:18:28PM +, Pratik Patel wrote: What user interface do you plan to provide for the CTI? Maybe something consistent with other CoreSight

Re: CoreSight framework and drivers

2013-01-03 Thread Pratik Patel
On Sun, Dec 23, 2012 at 11:32:39AM +, Will Deacon wrote: On Fri, Dec 21, 2012 at 10:18:28PM +, Pratik Patel wrote: What user interface do you plan to provide for the CTI? Maybe something consistent with other CoreSight components in sysfs to allow users to enable, disable, map and

Re: CoreSight framework and drivers

2013-01-03 Thread Pratik Patel
On Wed, Jan 02, 2013 at 02:00:21PM -0600, Jon Hunter wrote: The code is largely based upon the existing cti helpers, which just had a cti_map_trigger() function. The use-case you described is not supported by the current helpers and so also not supported in my initial implementation

Re: CoreSight framework and drivers

2013-01-02 Thread Jon Hunter
On 12/21/2012 04:18 PM, Pratik Patel wrote: On Thu, Dec 20, 2012 at 04:54:38PM -0600, Jon Hunter wrote: On 12/20/2012 01:51 PM, Pratik Patel wrote: On Thu, Dec 20, 2012 at 11:46:13AM -0600, Jon Hunter wrote: On 12/19/2012 03:24 PM, Pratik Patel wrote: [snip] Currently we use the

Re: CoreSight framework and drivers

2012-12-23 Thread Will Deacon
On Fri, Dec 21, 2012 at 10:18:28PM +, Pratik Patel wrote: What user interface do you plan to provide for the CTI? Maybe something consistent with other CoreSight components in sysfs to allow users to enable, disable, map and unmap ??? Please let me know your thoughts. Rather than have

Re: CoreSight framework and drivers

2012-12-21 Thread Pratik Patel
On Thu, Dec 20, 2012 at 09:16:15PM +0100, Jean Pihet wrote: Hi Pratik, On Thu, Dec 20, 2012 at 8:51 PM, Pratik Patel prat...@codeaurora.org wrote: On Thu, Dec 20, 2012 at 11:46:13AM -0600, Jon Hunter wrote: On 12/19/2012 03:24 PM, Pratik Patel wrote: [snip] Currently we use the

Re: CoreSight framework and drivers

2012-12-21 Thread Pratik Patel
On Thu, Dec 20, 2012 at 11:40:11PM +, Russell King - ARM Linux wrote: On Thu, Dec 20, 2012 at 04:54:38PM -0600, Jon Hunter wrote: On 12/20/2012 01:51 PM, Pratik Patel wrote: Ok, so are you referring to making CoreSight devices register with AMBA bus instead of platform bus keeping

Re: CoreSight framework and drivers

2012-12-21 Thread Pratik Patel
On Thu, Dec 20, 2012 at 04:54:38PM -0600, Jon Hunter wrote: On 12/20/2012 01:51 PM, Pratik Patel wrote: On Thu, Dec 20, 2012 at 11:46:13AM -0600, Jon Hunter wrote: On 12/19/2012 03:24 PM, Pratik Patel wrote: [snip] Currently we use the CoreSight virtual bus to conveniently list

Re: CoreSight framework and drivers

2012-12-20 Thread Jon Hunter
On 12/19/2012 03:24 PM, Pratik Patel wrote: [snip] Currently we use the CoreSight virtual bus to conveniently list sysfs configuration attributes for all the registered CoreSight devices. For eg: /sys/bus/coresight/devices/coresight-etm0/attribute

Re: CoreSight framework and drivers

2012-12-20 Thread Pratik Patel
On Thu, Dec 20, 2012 at 11:46:13AM -0600, Jon Hunter wrote: On 12/19/2012 03:24 PM, Pratik Patel wrote: [snip] Currently we use the CoreSight virtual bus to conveniently list sysfs configuration attributes for all the registered CoreSight devices. For eg:

Re: CoreSight framework and drivers

2012-12-20 Thread Jean Pihet
Hi Pratik, On Thu, Dec 20, 2012 at 8:51 PM, Pratik Patel prat...@codeaurora.org wrote: On Thu, Dec 20, 2012 at 11:46:13AM -0600, Jon Hunter wrote: On 12/19/2012 03:24 PM, Pratik Patel wrote: [snip] Currently we use the CoreSight virtual bus to conveniently list sysfs configuration

Re: CoreSight framework and drivers

2012-12-20 Thread Jon Hunter
On 12/20/2012 01:51 PM, Pratik Patel wrote: On Thu, Dec 20, 2012 at 11:46:13AM -0600, Jon Hunter wrote: On 12/19/2012 03:24 PM, Pratik Patel wrote: [snip] Currently we use the CoreSight virtual bus to conveniently list sysfs configuration attributes for all the registered CoreSight

Re: CoreSight framework and drivers

2012-12-20 Thread Russell King - ARM Linux
On Thu, Dec 20, 2012 at 04:54:38PM -0600, Jon Hunter wrote: On 12/20/2012 01:51 PM, Pratik Patel wrote: Ok, so are you referring to making CoreSight devices register with AMBA bus instead of platform bus keeping everything else intact? Yes exactly. However, please note I am not saying

CoreSight framework and drivers

2012-12-19 Thread pratikp
This RFC is aimed at introducing CoreSight framework as well as individual CoreSight trace component drivers adhering to ARM CoreSight specification. Some prior discussion on this can be referred at [1]. There are 3 kinds of CoreSight trace components: * Sources: Responsible for producing trace

Re: CoreSight framework and drivers

2012-12-19 Thread Will Deacon
Hi Pratik, On Tue, Dec 18, 2012 at 07:19:17PM +, prat...@codeaurora.org wrote: This RFC is aimed at introducing CoreSight framework as well as individual CoreSight trace component drivers adhering to ARM CoreSight specification. Some prior discussion on this can be referred at [1].

Re: CoreSight framework and drivers

2012-12-19 Thread Jon Hunter
On 12/19/2012 05:23 AM, Will Deacon wrote: Hi Pratik, On Tue, Dec 18, 2012 at 07:19:17PM +, prat...@codeaurora.org wrote: This RFC is aimed at introducing CoreSight framework as well as individual CoreSight trace component drivers adhering to ARM CoreSight specification. Some prior

Re: CoreSight framework and drivers

2012-12-19 Thread Pratik Patel
On Wed, Dec 19, 2012 at 11:03:58AM -0600, Jon Hunter wrote: On 12/19/2012 05:23 AM, Will Deacon wrote: Hi Pratik, On Tue, Dec 18, 2012 at 07:19:17PM +, prat...@codeaurora.org wrote: This RFC is aimed at introducing CoreSight framework as well as individual CoreSight trace