Re: Fix test relying in wrong behavior of is_printable

2013-01-08 Thread David Gibson
On Sun, Jan 06, 2013 at 01:41:56PM +0200, Pantelis Antoniou wrote: > Hi David > > Από το iPhone μου > > 6 Ιαν 2013, 5:58, ο/η David Gibson έγραψε: > > > On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote: > >> After fixing the is_printable bug the test suite fails. > >> Fix it wi

Re: Fix test relying in wrong behavior of is_printable

2013-01-07 Thread Jon Loeliger
> Err, > > I can rework and resubmit to remove the comment, but the test doesn't = > fail: > > > $ make check | grep 'MyBoardName.*-t s.*compatible' > > fdtget-runtest.sh MyBoardName MyBoardFamilyName -t s > > label01.dts.fdtget.test.dtb / compatible: PASS > > > > As of today's pull. My b

Re: Fix test relying in wrong behavior of is_printable

2013-01-07 Thread Pantelis Antoniou
Err, I can rework and resubmit to remove the comment, but the test doesn't fail: > $ make check | grep 'MyBoardName.*-t s.*compatible' > fdtget-runtest.sh MyBoardName MyBoardFamilyName -t s > label01.dts.fdtget.test.dtb / compatible:PASS > As of today's pull. Regards -- Pantelis On

Re: Fix test relying in wrong behavior of is_printable

2013-01-06 Thread Jon Loeliger
> Hi David > > =CE=91=CF=80=CF=8C =CF=84=CE=BF iPhone =CE=BC=CE=BF=CF=85 > > 6 =CE=99=CE=B1=CE=BD 2013, 5:58, =CE=BF/=CE=B7 David Gibson opbear.id.au> =CE=AD=CE=B3=CF=81=CE=B1=CF=88=CE=B5: > > > On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote: > >> After fixing the is_printabl

Re: Fix test relying in wrong behavior of is_printable

2013-01-06 Thread Pantelis Antoniou
Hi David Από το iPhone μου 6 Ιαν 2013, 5:58, ο/η David Gibson έγραψε: > On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote: >> After fixing the is_printable bug the test suite fails. >> Fix it with this patch >> >> Signed-off-by: Pantelis Antoniou > > Rather than just removing

Re: Fix test relying in wrong behavior of is_printable

2013-01-05 Thread David Gibson
On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote: > After fixing the is_printable bug the test suite fails. > Fix it with this patch > > Signed-off-by: Pantelis Antoniou Rather than just removing the test, it would be better to still run it using an explicit -t bi to force the b

Fix test relying in wrong behavior of is_printable

2013-01-04 Thread Pantelis Antoniou
After fixing the is_printable bug the test suite fails. Fix it with this patch Signed-off-by: Pantelis Antoniou --- tests/run_tests.sh | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/run_tests.sh b/tests/run_tests.sh index dd7f217..43279c9 100755 --- a/tests/run_te

[PATCH 3/4] Fix test relying in wrong behavior of is_printable

2013-01-04 Thread Pantelis Antoniou
After fixing the is_printable bug the test suite fails. Fix it with this patch Signed-off-by: Pantelis Antoniou --- tests/run_tests.sh | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/run_tests.sh b/tests/run_tests.sh index dd7f217..43279c9 100755 --- a/tests/run_te